From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 69E1A386F477 for ; Fri, 29 May 2020 14:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 69E1A386F477 Received: by mail-qt1-x82f.google.com with SMTP id z1so1989418qtn.2 for ; Fri, 29 May 2020 07:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T/HlNxi1qU2d8gIijwElHVMZpetTpVxi60un8ve9+lg=; b=NEk3GujcFwR53uIDIdNOMW7ePLN7lviTYHAKjZc2qXVNmASQoUL/nufJTERB/VpMo+ LyYUi2/FiEC/jhvUGiAKafJCBKotMZopTD1UTvdXihs+nm+ay7RVRcMvEJTLy/jwkpG4 m4pxL33cOrRfau/vDnLbdR5fq6AEVDqlWgzoaz9To4QeuAZQpnLEBe48/T+SLqsGJf9U yaPO2vivWczblL99yOi+v05kc8fmHJPKErX8W7tgkelbSz5KvMvpJiMfNuZc0JRXqtBm kPRd1h1bPCxc5a8mt3VU2+UXChX8icgbbaGIn3IYW10rIvxtULQvuvE9evwh44+IgWM2 O2mg== X-Gm-Message-State: AOAM532E/zKI0OgeziSbqhkFafslqPH8hpkUHsYmPTCvSX71M2YvETJK SFUUm1iqCZv8oVbPsw5QNk5p1nmcUqQ= X-Google-Smtp-Source: ABdhPJwmpf9z2lu9cktn7YKJrNnZBEmp2d29CpQQLarqx8sTnL2wuLGCSk9z4QOel4z0XEmZ5IxrRw== X-Received: by 2002:ac8:2db1:: with SMTP id p46mr8048360qta.337.1590760976773; Fri, 29 May 2020 07:02:56 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id p22sm743056qtc.7.2020.05.29.07.02.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 07:02:56 -0700 (PDT) To: libc-alpha@sourceware.org References: <20200423014126.10417-1-vgupta@synopsys.com> <20200423014126.10417-6-vgupta@synopsys.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v6 05/13] ARC: math soft float support Message-ID: <00f5ef87-90cc-2606-4d96-f423acf20eb6@linaro.org> Date: Fri, 29 May 2020 11:02:53 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200423014126.10417-6-vgupta@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 14:03:00 -0000 On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote: > Signed-off-by: Vineet Gupta As prior patch we do not use DCO, but rather copyright assignment. Looks ok in general, with some comments below. > --- > sysdeps/arc/bits/fenv.h | 77 +++++++++++++++++++++++ > sysdeps/arc/nofpu/Implies | 1 + > sysdeps/arc/nofpu/math-tests-exceptions.h | 27 ++++++++ > sysdeps/arc/nofpu/math-tests-rounding.h | 27 ++++++++ > sysdeps/arc/sfp-machine.h | 73 +++++++++++++++++++++ > 5 files changed, 205 insertions(+) > create mode 100644 sysdeps/arc/bits/fenv.h > create mode 100644 sysdeps/arc/nofpu/Implies > create mode 100644 sysdeps/arc/nofpu/math-tests-exceptions.h > create mode 100644 sysdeps/arc/nofpu/math-tests-rounding.h > create mode 100644 sysdeps/arc/sfp-machine.h > > diff --git a/sysdeps/arc/bits/fenv.h b/sysdeps/arc/bits/fenv.h > new file mode 100644 > index 000000000000..80afa50db9c6 > --- /dev/null > +++ b/sysdeps/arc/bits/fenv.h > @@ -0,0 +1,77 @@ Missing one line description. > +/* Copyright (C) 2012-2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _FENV_H > +# error "Never use directly; include instead." > +#endif > + > +enum > + { > + FE_INVALID = > +# define FE_INVALID (0x01) > + FE_INVALID, > + FE_DIVBYZERO = > +# define FE_DIVBYZERO (0x02) > + FE_DIVBYZERO, > + FE_OVERFLOW = > +# define FE_OVERFLOW (0x04) > + FE_OVERFLOW, > + FE_UNDERFLOW = > +# define FE_UNDERFLOW (0x08) > + FE_UNDERFLOW, > + FE_INEXACT = > +# define FE_INEXACT (0x10) > + FE_INEXACT > + }; > + > +# define FE_ALL_EXCEPT \ > + (FE_INVALID | FE_DIVBYZERO | FE_OVERFLOW | FE_UNDERFLOW | FE_INEXACT) > + > +enum > + { > + FE_TOWARDZERO = > +# define FE_TOWARDZERO (0x0) > + FE_TOWARDZERO, > + FE_TONEAREST = > +# define FE_TONEAREST (0x1) /* default */ > + FE_TONEAREST, > + FE_UPWARD = > +# define FE_UPWARD (0x2) > + FE_UPWARD, > + FE_DOWNWARD = > +# define FE_DOWNWARD (0x3) > + FE_DOWNWARD > + }; > + > +typedef unsigned int fexcept_t; > + > +typedef struct > +{ > + unsigned int __fpcr; > + unsigned int __fpsr; > +} fenv_t; > + > +/* If the default argument is used we use this value. */ > +#define FE_DFL_ENV ((const fenv_t *) -1) > + > +#if __GLIBC_USE (IEC_60559_BFP_EXT) > +/* Type representing floating-point control modes. */ > +typedef unsigned int femode_t; > + > +/* Default floating-point control modes. */ > +# define FE_DFL_MODE ((const femode_t *) -1L) > +#endif Ok. > diff --git a/sysdeps/arc/nofpu/Implies b/sysdeps/arc/nofpu/Implies > new file mode 100644 > index 000000000000..abcbadb25f22 > --- /dev/null > +++ b/sysdeps/arc/nofpu/Implies > @@ -0,0 +1 @@ > +ieee754/soft-fp Ok. > diff --git a/sysdeps/arc/nofpu/math-tests-exceptions.h b/sysdeps/arc/nofpu/math-tests-exceptions.h > new file mode 100644 > index 000000000000..2ec58e088ebf > --- /dev/null > +++ b/sysdeps/arc/nofpu/math-tests-exceptions.h > @@ -0,0 +1,27 @@ > +/* Configuration for math tests. exceptions support ARC version. Double space after period and capitalize 'exceptions'. > + Copyright (C) 2017-2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#ifndef ARC_NOFPU_MATH_TESTS_EXCEPTIONS_H > +#define ARC_NOFPU_MATH_TESTS_EXCEPTIONS_H 1 > + > +/* Soft-float does not support exceptions. */ > +#define EXCEPTION_TESTS_float 0 > +#define EXCEPTION_TESTS_double 0 > +#define EXCEPTION_TESTS_long_double 0 > + > +#endif Ok. > diff --git a/sysdeps/arc/nofpu/math-tests-rounding.h b/sysdeps/arc/nofpu/math-tests-rounding.h > new file mode 100644 > index 000000000000..6e5376cb35b5 > --- /dev/null > +++ b/sysdeps/arc/nofpu/math-tests-rounding.h > @@ -0,0 +1,27 @@ > +/* Configuration for math tests: rounding mode support. ARC version. > + Copyright (C) 2017-2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#ifndef ARC_NOFPU_MATH_TESTS_ROUNDING_H > +#define ARC_NOFPU_MATH_TESTS_ROUNDING_H 1 > + > +/* Soft-float only supports to-nearest rounding mode. */ > +#define ROUNDING_TESTS_float(MODE) ((MODE) == FE_TONEAREST) > +#define ROUNDING_TESTS_double(MODE) ((MODE) == FE_TONEAREST) > +#define ROUNDING_TESTS_long_double(MODE) ((MODE) == FE_TONEAREST) > + > +#endif Ok. > diff --git a/sysdeps/arc/sfp-machine.h b/sysdeps/arc/sfp-machine.h > new file mode 100644 > index 000000000000..b2bfd33e944c > --- /dev/null > +++ b/sysdeps/arc/sfp-machine.h > @@ -0,0 +1,73 @@ > +/* Machine-dependent software floating-point definitions. ARC version. > + Copyright (C) 2004-2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + Contributed by Richard Henderson (rth@cygnus.com), > + Jakub Jelinek (jj@ultra.linux.cz) and > + David S. Miller (davem@redhat.com). We don't add 'Contributed by' anymore in new files, but I am not sure how should we proceed with code that might be shared with gcc. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > + > +#define _FP_W_TYPE_SIZE 32 > +#define _FP_W_TYPE unsigned long > +#define _FP_WS_TYPE signed long > +#define _FP_I_TYPE long > + > +#define _FP_MUL_MEAT_S(R,X,Y) \ > + _FP_MUL_MEAT_1_wide(_FP_WFRACBITS_S,R,X,Y,umul_ppmm) > +#define _FP_MUL_MEAT_D(R,X,Y) \ > + _FP_MUL_MEAT_2_wide(_FP_WFRACBITS_D,R,X,Y,umul_ppmm) > +#define _FP_MUL_MEAT_Q(R,X,Y) \ > + _FP_MUL_MEAT_4_wide(_FP_WFRACBITS_Q,R,X,Y,umul_ppmm) > + > +#define _FP_MUL_MEAT_DW_S(R,X,Y) \ > + _FP_MUL_MEAT_DW_1_wide(_FP_WFRACBITS_S,R,X,Y,umul_ppmm) > +#define _FP_MUL_MEAT_DW_D(R,X,Y) \ > + _FP_MUL_MEAT_DW_2_wide(_FP_WFRACBITS_D,R,X,Y,umul_ppmm) > +#define _FP_MUL_MEAT_DW_Q(R,X,Y) \ > + _FP_MUL_MEAT_DW_4_wide(_FP_WFRACBITS_Q,R,X,Y,umul_ppmm) > + > +#define _FP_DIV_MEAT_S(R,X,Y) _FP_DIV_MEAT_1_loop(S,R,X,Y) > +#define _FP_DIV_MEAT_D(R,X,Y) _FP_DIV_MEAT_2_udiv(D,R,X,Y) > +#define _FP_DIV_MEAT_Q(R,X,Y) _FP_DIV_MEAT_4_udiv(Q,R,X,Y) > + > +#define _FP_NANFRAC_S ((_FP_QNANBIT_S << 1) - 1) > +#define _FP_NANFRAC_D ((_FP_QNANBIT_D << 1) - 1), -1 > +#define _FP_NANFRAC_Q ((_FP_QNANBIT_Q << 1) - 1), -1, -1, -1 > +#define _FP_NANSIGN_S 0 > +#define _FP_NANSIGN_D 0 > +#define _FP_NANSIGN_Q 0 > + > +#define _FP_KEEPNANFRACP 1 > +#define _FP_QNANNEGATEDP 0 > + > +/* This is arbitrarily taken from the PowerPC version. */ > +#define _FP_CHOOSENAN(fs, wc, R, X, Y, OP) \ > + do { \ > + if ((_FP_FRAC_HIGH_RAW_##fs(X) & _FP_QNANBIT_##fs) \ > + && !(_FP_FRAC_HIGH_RAW_##fs(Y) & _FP_QNANBIT_##fs)) \ > + { \ > + R##_s = Y##_s; \ > + _FP_FRAC_COPY_##wc(R,Y); \ > + } \ > + else \ > + { \ > + R##_s = X##_s; \ > + _FP_FRAC_COPY_##wc(R,X); \ > + } \ > + R##_c = FP_CLS_NAN; \ > + } while (0) > + > +#define _FP_TININESS_AFTER_ROUNDING 1 > Ok.