From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>,
Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/3] Disable stack protector for ifunc resolvers in tests
Date: Wed, 10 Mar 2021 15:08:08 +0530 [thread overview]
Message-ID: <0276568c-7d8c-6f51-759a-2240596653f4@sourceware.org> (raw)
In-Reply-To: <875z1zwia5.fsf@oldenburg.str.redhat.com>
On 3/10/21 1:29 PM, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar via Libc-alpha:
>
>> IFUNC resolvers get called too early for stack protector to be useful,
>> so fix the elf tests to disable stack protector for the resolver
>> functions. This fixes test failures in the static tests on x86_64.
>
> With -fstack-protector-all, presumably. Does this need a bug in
> Bugzilla?
I started to file it and found there already was a report[1] and a patch
that fixes it. I'll remove the overlapping hunk from my patch and
credit David with it and close that bug once this goes in.
Siddhesh
next prev parent reply other threads:[~2021-03-10 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 18:12 [PATCH 0/3] Clean up stack-protector-all build Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 1/3] Build get-cpuid-feature-leaf.c without stack-protector Siddhesh Poyarekar
2021-03-10 7:58 ` Florian Weimer
2021-03-09 18:12 ` [PATCH 2/3] Disable stack protector for ifunc resolvers in tests Siddhesh Poyarekar
2021-03-10 7:59 ` Florian Weimer
2021-03-10 9:38 ` Siddhesh Poyarekar [this message]
2021-03-10 9:39 ` Florian Weimer
2021-03-10 9:57 ` Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 3/3] Build libc-start with stack protector for SHARED Siddhesh Poyarekar
2021-03-10 8:00 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0276568c-7d8c-6f51-759a-2240596653f4@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).