From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id F13F0384AB63 for ; Tue, 21 May 2024 12:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F13F0384AB63 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F13F0384AB63 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296103; cv=none; b=BfxKRX5L5b6KpIIakez0+BTe5e32TiG0Re15GxYSPgYSeANiNwx0yZ0TkY4hXQqtZl0kJ7rJgyF+cvVXTkAy0t8So6rCue8nyEhUBiTH0ncZIeWIdL5+F0xefmmNG36A/La3LOjAsWCwM8XhYTJOcwQk6WZr1EuFA/BOXQWIqlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716296103; c=relaxed/simple; bh=y4OHX35pQymN6d6v4IULSiVL+gy3O/HlA+/LigOI1Lo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gppcyd0yFiq9PKEm1HWR7DW+S2FTn4edGTxKcfMSY/Oh/HXJNFgfj0AHsKNJ6nclEG5YSUQYXvTELY4Rzds8bWffa3wLMMzwzrhIGAby+5vW9kA+Us3wuQLFAjX/Rgl4ZGR36F+I/2baMtSVEPEabfw4BKSH1KgHL+f0t2MGI8s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6f44a2d1e3dso389657b3a.3 for ; Tue, 21 May 2024 05:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716296099; x=1716900899; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=b5Ibs5DFU5iCeydWf9jSwLwp1AehM8XidJow1FfqKjE=; b=oESDqpprBr8h67C/CasctaYCw7FXd8XigyjxeE6eG6J60NThngv3odaQ/2k6axhG9E tduvAuQF/oUQ8UyYuCjnB503TwofHI0+XJC+Ce1+anpwDhrjKux4+1wulXNAV6A7TChK zRa7VKtAry4+MsmTz2JiSpwxHfSYofHsv2f9Go9ir1QESFINodLyKbUjNt05OzbzDNxZ +qz2ilfdbCHz+6pPHqBRCY0Yl3PMVezKWvjXHY53ZdZKHRnyDFe4aElpJVA+TpOdiVgu UiVRyQU+MTidWh84aJzTI5PzKhS8fPzpCgqFqv39rwmxo6vZr9kc9CN+5ulMCAuhCh5F aJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716296099; x=1716900899; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b5Ibs5DFU5iCeydWf9jSwLwp1AehM8XidJow1FfqKjE=; b=HPExlqp+A40uMCwevhSxBZNnTDcBn1rrp2I5Nm9vZJ/I3YBhXZFlAPuv36tsuGk8xc VeR13t8FM/DXr3ab0L3YHKKa6kc+fz0zoIXRfDPor2tUgJzy30FFrjMQlp/awJLekHdq DnVqdo8ImkTy903hWxnBXPC2e2U3Fhr+C32tFyTMr1Lj6+8kmxuiIMWOWaShWU/QK4p3 0e6TgR1PUTJvDRa/Qhzc3NpfbOsm6/zD7kWcFYLe2ZujeM7elQ7+3OFGmyfvwYqSglAv 8NQt8W32HBgT7CpNtQ+GmaJJ+S/kMogGS0ZdhwUN0aANHNrpSOu3uE6ygsAIdiuhvedy 4I6w== X-Gm-Message-State: AOJu0YyMrWbXvXnM7f+6WdOUae3K3xiu7VGNWIwxPQfboKunElNbG0hN axV+EBW+BK62PPsrwnGS2THcAxIIDuCU+Ck/ySl9C6h5WlI4xrqJlZNr1w2YHZU= X-Google-Smtp-Source: AGHT+IFi+TuI3gqfpk2vGF0bYOfFZSWRqYfbtKqDOuoRlBYLCl1iYD0wq3ZLDEuZFjF4sTiTKqyOWQ== X-Received: by 2002:a17:903:48c:b0:1e3:c5d0:9fb8 with SMTP id d9443c01a7336-1ef4404fd76mr268245855ad.42.1716296098944; Tue, 21 May 2024 05:54:58 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf? ([2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f306deff6fsm28816435ad.133.2024.05.21.05.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 05:54:58 -0700 (PDT) Message-ID: <028a8dcb-60b8-4932-804d-21a4164ef35d@linaro.org> Date: Tue, 21 May 2024 09:54:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/7] math: Fix i386 and m68k exp10 on static build To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-4-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/05/24 09:48, H.J. Lu wrote: > On Tue, Apr 2, 2024 at 7:06 AM Adhemerval Zanella > wrote: >> >> The commit 08ddd26814 removed the static exp10 on i386 and m68k with an >> empty w_exp10.c (required for the ABIs that uses the newly >> implementation). This patch fixes by adding the required symbols on the >> arch-specific w_exp{f}_compat.c implementation. >> >> Checked on i686-linux-gnu and with a build for m68k-linux-gnu with >> 'make test t=math/test-{float,double}-exp10-static build-math-static-tests=yes' >> --- >> sysdeps/i386/fpu/w_exp10_compat.c | 9 +++++++-- >> sysdeps/m68k/m680x0/fpu/w_exp10_compat.c | 9 +++++++-- >> 2 files changed, 14 insertions(+), 4 deletions(-) >> >> diff --git a/sysdeps/i386/fpu/w_exp10_compat.c b/sysdeps/i386/fpu/w_exp10_compat.c >> index b53455386e..49a0e03385 100644 >> --- a/sysdeps/i386/fpu/w_exp10_compat.c >> +++ b/sysdeps/i386/fpu/w_exp10_compat.c >> @@ -1,3 +1,8 @@ >> /* i386 provides an optimized __ieee754_exp10. */ >> -#define NO_COMPAT_NEEDED 1 >> -#include >> +#ifdef SHARED >> +# define NO_COMPAT_NEEDED 1 >> +# include >> +#else >> +# include >> +# include >> +#endif >> diff --git a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> index 0d3e718626..350f2e4b4d 100644 >> --- a/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> +++ b/sysdeps/m68k/m680x0/fpu/w_exp10_compat.c >> @@ -1,3 +1,8 @@ >> /* m68k provides an optimized __ieee754_exp10. */ >> -#define NO_COMPAT_NEEDED 1 >> -#include >> +#ifdef SHARED >> +# define NO_COMPAT_NEEDED 1 >> +# include >> +#else >> +# include >> +# include >> +#endif >> -- >> 2.34.1 >> > > Please mention: > > https://sourceware.org/bugzilla/show_bug.cgi?id=31775 > > in the commit log. > Ack.