From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Daniel Cederman <cederman@gaisler.com>, libc-alpha@sourceware.org
Cc: daniel@gaisler.com, andreas@gaisler.com
Subject: Re: [PATCH v3] sparc: Force calculation that raises exception
Date: Wed, 17 Jan 2024 08:27:33 -0300 [thread overview]
Message-ID: <029c229b-b112-417a-a6df-8a156d545cb5@linaro.org> (raw)
In-Reply-To: <20240116151641.3583965-1-cederman@gaisler.com>
On 16/01/24 12:16, Daniel Cederman wrote:
> Use the math_force_eval() macro to force the calculation to complete and
> raise the exception.
>
> With this change the math/test-fenv test pass.
>
> Signed-off-by: Daniel Cederman <cederman@gaisler.com>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/sparc/fpu/fraiseexcpt.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/sysdeps/sparc/fpu/fraiseexcpt.c b/sysdeps/sparc/fpu/fraiseexcpt.c
> index 26a7720ec9..642666c12a 100644
> --- a/sysdeps/sparc/fpu/fraiseexcpt.c
> +++ b/sysdeps/sparc/fpu/fraiseexcpt.c
> @@ -20,6 +20,7 @@
> #include <float.h>
> #include <math.h>
> #include <shlib-compat.h>
> +#include <math-barriers.h>
>
> int
> __feraiseexcept (int excepts)
> @@ -42,7 +43,7 @@ __feraiseexcept (int excepts)
> /* One example of an invalid operation is 0/0. */
> __asm ("" : "=e" (d) : "0" (c.zero));
> d /= c.zero;
> - __asm __volatile ("" : : "e" (d));
> + math_force_eval (d);
> }
>
> /* Next: division by zero. */
> @@ -50,7 +51,7 @@ __feraiseexcept (int excepts)
> {
> __asm ("" : "=e" (d) : "0" (c.one));
> d /= c.zero;
> - __asm __volatile ("" : : "e" (d));
> + math_force_eval (d);
> }
>
> /* Next: overflow. */
> @@ -58,7 +59,7 @@ __feraiseexcept (int excepts)
> {
> __asm ("" : "=e" (d) : "0" (c.max));
> d *= d;
> - __asm __volatile ("" : : "e" (d));
> + math_force_eval (d);
> }
>
> /* Next: underflow. */
> @@ -66,7 +67,7 @@ __feraiseexcept (int excepts)
> {
> __asm ("" : "=e" (d) : "0" (c.min));
> d *= d;
> - __asm __volatile ("" : : "e" (d));
> + math_force_eval (d);
> }
>
> /* Last: inexact. */
> @@ -74,7 +75,7 @@ __feraiseexcept (int excepts)
> {
> __asm ("" : "=e" (d) : "0" (c.one));
> d /= c.pi;
> - __asm __volatile ("" : : "e" (d));
> + math_force_eval (d);
> }
>
> /* Success. */
prev parent reply other threads:[~2024-01-17 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 15:16 Daniel Cederman
2024-01-17 11:27 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=029c229b-b112-417a-a6df-8a156d545cb5@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=andreas@gaisler.com \
--cc=cederman@gaisler.com \
--cc=daniel@gaisler.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).