* [PATCH] tests: Remove NULL check for an array
@ 2020-11-11 17:29 Siddhesh Poyarekar
2020-11-12 8:01 ` Siddhesh Poyarekar
0 siblings, 1 reply; 2+ messages in thread
From: Siddhesh Poyarekar @ 2020-11-11 17:29 UTC (permalink / raw)
To: libc-alpha
The NULL check for an array on stack is pointless since it will always
be false, so drop it.
---
This is fairly obvious, so I'll commit it in a day if nobody objects.
Siddhesh
stdio-common/scanf14.c | 2 --
stdio-common/scanf15.c | 2 --
stdio-common/scanf16.c | 2 --
stdio-common/scanf17.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/stdio-common/scanf14.c b/stdio-common/scanf14.c
index f92838edd2..4c2feea7ba 100644
--- a/stdio-common/scanf14.c
+++ b/stdio-common/scanf14.c
@@ -86,8 +86,6 @@ main (void)
char fname[strlen (tmpdir) + sizeof "/tst-scanf14.XXXXXX"];
sprintf (fname, "%s/tst-scanf14.XXXXXX", tmpdir);
- if (fname == NULL)
- FAIL ();
/* Create a temporary file. */
int fd = mkstemp (fname);
diff --git a/stdio-common/scanf15.c b/stdio-common/scanf15.c
index a937815b14..6e4980c2e1 100644
--- a/stdio-common/scanf15.c
+++ b/stdio-common/scanf15.c
@@ -69,8 +69,6 @@ main (void)
char fname[strlen (tmpdir) + sizeof "/tst-scanf15.XXXXXX"];
sprintf (fname, "%s/tst-scanf15.XXXXXX", tmpdir);
- if (fname == NULL)
- FAIL ();
/* Create a temporary file. */
int fd = mkstemp (fname);
diff --git a/stdio-common/scanf16.c b/stdio-common/scanf16.c
index b4ba3e6fe3..073a77efbe 100644
--- a/stdio-common/scanf16.c
+++ b/stdio-common/scanf16.c
@@ -117,8 +117,6 @@ main (void)
char fname[strlen (tmpdir) + sizeof "/tst-scanf16.XXXXXX"];
sprintf (fname, "%s/tst-scanf16.XXXXXX", tmpdir);
- if (fname == NULL)
- FAIL ();
/* Create a temporary file. */
int fd = mkstemp (fname);
diff --git a/stdio-common/scanf17.c b/stdio-common/scanf17.c
index 428f22e45c..3224573733 100644
--- a/stdio-common/scanf17.c
+++ b/stdio-common/scanf17.c
@@ -100,8 +100,6 @@ main (void)
char fname[strlen (tmpdir) + sizeof "/tst-scanf17.XXXXXX"];
sprintf (fname, "%s/tst-scanf17.XXXXXX", tmpdir);
- if (fname == NULL)
- FAIL ();
/* Create a temporary file. */
int fd = mkstemp (fname);
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: Remove NULL check for an array
2020-11-11 17:29 [PATCH] tests: Remove NULL check for an array Siddhesh Poyarekar
@ 2020-11-12 8:01 ` Siddhesh Poyarekar
0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2020-11-12 8:01 UTC (permalink / raw)
To: libc-alpha
On 11/11/20 10:59 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The NULL check for an array on stack is pointless since it will always
> be false, so drop it.
> ---
>
> This is fairly obvious, so I'll commit it in a day if nobody objects.
Committed now.
Siddhesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 17:29 [PATCH] tests: Remove NULL check for an array Siddhesh Poyarekar
2020-11-12 8:01 ` Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).