From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2CA0B3894C1A for ; Thu, 20 Jun 2024 18:23:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CA0B3894C1A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CA0B3894C1A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718907791; cv=none; b=nAmDFkFGGmaCx9Rc1wx5bZDkeknxUiQWXp2FcHst4OT6ZZNIFgchWMX2KfKaxHi3bUy5WHQiwluFqrbGVUCnqCR9zgCQwICIkvphFD/GK99zG7+DBkEIUbWgglBP7cDHE5AoSvnRwtaTFcNCPf169GkgZqUcdIdTVLkPXT1dtPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718907791; c=relaxed/simple; bh=uUf+qTnwabb8/yYsOG8famVgew6p4j1bZnGkUM/pm3Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kVSSqYal1IH6u3N3+wAUZ7thF5uUixDOmxkWXsVl/dnM4LbksCyzRs+lW1jIrDNw+qo1A57nmpHP06bRvpIKNAOoj67JAZ5FmCD+v44L3yeXFY8LB9cvccMVLz/n58l7c/RZPfPekR51NeUfOgg9jVl/iJYcm2WYZWSQkRq5TBg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718907786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r4y1hD8eGNRJmtLxWxIpIfJtR3N+AS3ISq0lku5wBwI=; b=LgBZIGElGdABHsaa/dSv91lsdCtePoCYTFWP9NGO0X2p9F3VSeYO4DZFECq353ls5eWtBv GMmJRlf9n6vOAi5N8OV4zXiNGgcqrrD9M/B34y9aZJaejMa60MriIL/5WJfWJyfLUmH5YX TaeCXnYR3UtlP0A5jk9+igsV9NRhkk0= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-A0wigF2HPXm-SMd75bi6Wg-1; Thu, 20 Jun 2024 14:23:02 -0400 X-MC-Unique: A0wigF2HPXm-SMd75bi6Wg-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5baf13f9c83so1283596eaf.3 for ; Thu, 20 Jun 2024 11:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718907781; x=1719512581; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r4y1hD8eGNRJmtLxWxIpIfJtR3N+AS3ISq0lku5wBwI=; b=noAAB2r0vlIKGGqHNn91D1vAl7ZyAmfKeMMGlVxiF/+QoXfx1skCrRKx8sWMmSg2sj SdZH6DR69QYpG7ovH5tt+2dUgglMKpzsUMTVMQUpUptoSjkQtADDHC4xrldwZKMeP3Xe Z8rEJ3EMnLvdrB2onK5c6Ypr00Q8eccQuGFMruJVxgfb5zMDK2uB/uaD+y4EA03FWr3X k6JBT4CvJ0Hd0BpRvXS4+YSf89QAEraUejnHHC+UPHR3Fk5hgB5BqDQ6vO5zCLlBs0YY 32tMUlE2+90JfE/j/6Z6ZCP/xlG0S/wnqnYg5nPUNKZUzw05l8XULRExe977n8piR1vv QS6Q== X-Forwarded-Encrypted: i=1; AJvYcCUCRsbluy4tVybJkucpWuN4x7kWh2cna7WvrnAr9xIGVMdq1yIRie3vmOoGofi7WuQvxsUR53S8Gx5MNTwUfeLnsI1fD/jsqJ34 X-Gm-Message-State: AOJu0YwRNMmXh/DQ9KtCM2WAFsZA5CTUd10D5AOu/v7z8tCltsTZLX/O o75aj1aeUOKLleuLBZo7mLz+oMg1zPWCUEQvw1YN3UZfPKnYfwLqm2wTrOQP3ojNyGJCCyD4SpE M/3cvXpcXI1k0qhx8EBpphZxvWXG59SPMLfz6C2CWA7gJx+sO5OsFi2u0wg== X-Received: by 2002:a05:6870:e40b:b0:251:2766:deb5 with SMTP id 586e51a60fabf-25c94905ff1mr7084952fac.9.1718907781563; Thu, 20 Jun 2024 11:23:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjJ/p/6JRF+207YGKmy73y0cb22nkPn5i+++XBJ83aQIksYPc0JsSRinJ0mq6ns6+DmyJ0sA== X-Received: by 2002:a05:6870:e40b:b0:251:2766:deb5 with SMTP id 586e51a60fabf-25c94905ff1mr7084929fac.9.1718907781157; Thu, 20 Jun 2024 11:23:01 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5eb4a8esm90973286d6.81.2024.06.20.11.23.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 11:23:00 -0700 (PDT) Message-ID: <034f94c0-bc79-408c-97cb-580afb48ed21@redhat.com> Date: Thu, 20 Jun 2024 14:22:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] Add --disable-static-c++-link-check option [BZ #31412] To: "H.J. Lu" , libc-alpha@sourceware.org Cc: fweimer@redhat.com References: <20240525122641.3154365-1-hjl.tools@gmail.com> <20240525122641.3154365-2-hjl.tools@gmail.com> From: Carlos O'Donell Autocrypt: addr=carlos@redhat.com; keydata= xsFNBFef5BoBEACvJ15QMMZh4stKHbz0rs78XsOdxuug37dumTx6ngrDCwZ61k7nHQ+uxLuo QvLSc6YJGBEfiNFbs1hvhRFNR7xJbzRYmin7kJZZ/06fH2cgTkQhN0mRBP8KsKKT+7SvvBL7 85ZfAhArWf5m5Tl0CktZ8yoG8g9dM4SgdvdSdzZUaWBVHc6TjdAb9YEQ1/jpyfHsQp+PWLuQ ZI8nZUm+I3IBDLkbbuJVQklKzpT1b8yxVSsHCyIPFRqDDUjPL5G4WnUVy529OzfrciBvHdxG sYYDV8FX7fv6V/S3eL6qmZbObivIbLD2NbeDqw6vNpr+aehEwgwNbMVuVfH1PVHJV8Qkgxg4 PqPgQC7GbIhxxYroGbLJCQ41j25M+oqCO/XW/FUu/9x0vY5w0RsZFhlmSP5lBDcaiy3SUgp3 MSTePGuxpPlLVMePxKvabSS7EErLKlrAEmDgnUYYdPqGCefA+5N9Rn2JPfP7SoQEp2pHhEyM 6Xg9x7TJ+JNuDowQCgwussmeDt2ZUeMl3s1f6/XePfTd3l8c8Yn5Fc8reRa28dFANU6oXiZf 7/h3iQXPg81BsLMJK3aA/nyajRrNxL8dHIx7BjKX0/gxpOozlUHZHl73KhAvrBRaqLrr2tIP LkKrf3d7wdz4llg4NAGIU4ERdTTne1QAwS6x2tNa9GO9tXGPawARAQABzSpDYXJsb3MgTydE b25lbGwgKFdvcmspIDxjYXJsb3NAcmVkaGF0LmNvbT7CwZUEEwEIAD8CGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEcnNUKzmWLfeymZMUFnkrTqJTQPgFAmStkMYFCQ8AA6UACgkQ FnkrTqJTQPjRTxAAnKmRztRqcP4bgMeweR3rMxDEtwQhciDybB7RgBeuZHCbY6Hmqx2so4gH 2rG9EoBJM1RZKyqztVJ2WbGPzEb4ZAW/AjmttIoN1tSdACGBbd8kPNUzJd+QsCiWGNtyaJw6 /HTLj9JRdGN16b+DzUJxww3gYZYTTkhSNUVjcrw7hzXU0Zb3z9/evXv26SDbNCqSfhAm7tNE 8ceH9H8dTcalNUPJO7bgXRhXORj9OciJrMnpPs6P4U5f/IkcVSZS1t+6R0KPWeEUXGlegTFK F1cKsSoil8mYajqAheuqbjtPHPh55dHTbG35ngjNSZyiM54PdMW5SR6zog3RAlYnuPg09g21 n9Y/ihuEZZve57Gp5wHUwNE+RKRByLlRF3Zezz6jKfjLyHqJYK8d8+vuFO1vca5OfxCEf33Y 8pLhARmHXG6mzRdji1e7Ugob2OQbvM1XWkInA+NyGeqLlE7ZnzVME5kmYVa/+qjdoqEgAqKz EdcknAZ0uud8xuAqven5X17+bBY16RZHOysOcBiGGC2E1A8Xni8cO+vH6NTCjK+OAk7UXgWB +9MFvsi7WHDJAjVlpOwuRYDWjZ8o8HhkByMAhPEzjySR9G1bzHKNOVQNFpHPTP8a5LJR6nX/ QdjKAC0bOR1TxNeK6T0h+E0iPnwWIJ6ezimzwdRl0oCbj02giyPOwU0EV5/kGgEQAKvTJke+ QSjATmz11ALKle/SSEpUwL5QOpt3xomEATcYAamww0HADfGTKdUR+aWgOK3vqu6Sicr1zbuZ jHCs2GaIgRoqh1HKVgCmaJYjizvidHluqrox6qqc9PG0bWb0f5xGQw+X2z+bEinzv4qaep1G 1OuYgvG49OpHTgZMiJq9ncHCxkD2VEJKgMywGJ4Agdl+NWVn0T7w6J+/5QmBIE8hh4NzpYfr xzWCJ9iZ3skG4zBGB4YEacc3+oeEoybc10h6tqhQNrtIiSRJH+SUJvOiNH8oMXPLAjfFVy3d 4BOgyxJhE0UhmQIQHMJxCBw81fQD10d0dcru0rAIEldEpt2UXqOr0rOALDievMF/2BKQiOA7 PbMC3/dwuNHDlClQzdjil8O7UsIgf3IMFaIbQoUEvjlgf5cm9a94gWABcfI1xadAq9vcIB5v +9fM71xDgdELnZThTd8LByrG99ExVMcG2PZYXJllVDQDZqYA1PjD9e0yHq5whJi3BrZgwDaL 5vYZEb1EMyH+BQLO3Zw/Caj8W6mooGHgNveRQ1g9FYn3NUp7UvS22Zt/KW4pCpbgkQZefxup KO6QVNwwggV44cTQ37z5onGbNPD8+2k2mmC0OEtGBkj+VH39tRk+uLOcuXlGNSVk3xOyxni0 Nk9M0GvTvPKoah9gkvL/+AofN/31ABEBAAHCwXwEGAEIACYCGwwWIQRyc1QrOZYt97KZkxQW eStOolNA+AUCZK2RDAUJDwAD8gAKCRAWeStOolNA+B0MEACVxFO++NroEQxSQ0NCWod3aDmY mYn+/08wLTeMP+ajq19FEjU0Lh/GBJl6WlSHeJ5ZJlNSiXZuiSYGMYm73DBaoZlyjbD+H9NL LwLXgtfCZYlN6Iu8JRMfk9yevVBay7Be9DkPAk565ggo0UkIjpYftiLF4TUfqnI1yO6QKXgr J2DDwlP3iiCYnWFpHdBTB2/BRurpZoRquhRGzgcdGfRDtp16Pzm/u8BjfaU5/AFRjM0IDYQ6 PaQld0uZSZ0qOn0ts6usJws5gANq4U1oWJlqL/PHOFy9mbwUnKqq0oiWrmj+Mb+Ic6m9fqB3 5CHWUhxC1QozvkuY/sTsmXnG/mnbq2oFIVcgXDsnrDHf+0GyR+TrE4AQw1Pt2utsmU67LqNB Ru/2NbSFgwPv5wWjtNwDVGSZEXlV4qJGjh8S9aaGXhRTwJsnN6qkFS1m6vHKwqnRb5Qy4XDg 7kDrhFnTWe+XSwQt+HtGvIiXcR3EScJky76YlVsWDtvZMo3NePaC3qV5HAC8d2ZL3sFqxJRu sRyjE2l6s0EEK2MUgV/dwodftECrMdGktndVTYPqLnsua/PWWKYwYrNvD8slL6VFkXDZvLLv nat9vl9mBm15b76RHvKNlRcPbB9YYCbS5fhN2ObAsVbV1c5TdBCp8lp1Fa3YK0TA+WpNZVHK vjq6hMJAjA== Organization: Red Hat In-Reply-To: <20240525122641.3154365-2-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/25/24 8:26 AM, H.J. Lu wrote: > The current minimum GCC version of glibc build is GCC 6.2 or newer. But > building i686 glibc with GCC 6.4 on Fedora 40 failed since the C++ header > files couldn't be found which was caused by the static C++ link check > failure due to missing __divmoddi4 which was referenced in i686 libc.a > and added to GCC 7. Add --disable-static-c++-link-check configure option > to disable the static C++ link test. The newly built i686 libc.a can be > used by GCC 6.4 to create static C++ tests. This fixes BZ #31412. OK with the suggested text changes. You may keep my RB if you make the suggested textual changes. Reviewed-by: Carlos O'Donell > Signed-off-by: H.J. Lu > --- > INSTALL | 8 ++++++++ > configure | 24 +++++++++++++++++++----- > configure.ac | 22 +++++++++++++++------- > manual/install.texi | 8 ++++++++ > 4 files changed, 50 insertions(+), 12 deletions(-) > > diff --git a/INSTALL b/INSTALL > index c8c524527b..d8b06f20aa 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -224,6 +224,14 @@ if 'CFLAGS' is specified it must enable optimization. For example: > By default for x86_64, the GNU C Library is built with the vector > math library. Use this option to disable the vector math library. > > +'--disable-static-c++-link-check' > + By default, if the C++ toolchain doesn't not support static > + linking, configure couldn't find the C++ header files and the glibc > + build fails. Use this option to disable the static C++ link check > + so that the C++ header files can be located. The newly built > + libc.a can be used to create static C++ tests if the C++ toolchain > + has necessary static C++ libraries. > + > '--disable-scv' > Disable using 'scv' instruction for syscalls. All syscalls will > use 'sc' instead, even if the kernel supports 'scv'. PowerPC only. > diff --git a/configure b/configure > index 432e40a592..31205ce568 100755 > --- a/configure > +++ b/configure > @@ -778,6 +778,7 @@ ac_user_opts=' > enable_option_checking > with_pkgversion > with_bugurl > +enable_static_c___link_check > with_gd > with_gd_include > with_gd_lib > @@ -1447,6 +1448,8 @@ Optional Features: > --disable-option-checking ignore unrecognized --enable/--with options > --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) > --enable-FEATURE[=ARG] include FEATURE [ARG=yes] > + --disable-static-c++-link-check > + disable static C++ link check [default=no] > --disable-sanity-checks really do not use threads (should not be used except > in special situations) [default=yes] > --enable-shared build shared library [default=yes if GNU ld] > @@ -3810,6 +3813,15 @@ if test -z "$CPP"; then > fi > > > +# Check whether --enable-static-c++-link-check was given. > +if test ${enable_static_c___link_check+y} > +then : > + enableval=$enable_static_c___link_check; static_cxx_link_check=$enableval > +else $as_nop > + static_cxx_link_check=yes > +fi > + > + > # We need the C++ compiler only for testing. > > > @@ -4220,10 +4232,11 @@ else $as_nop > fi > rm -f core conftest.err conftest.$ac_objext conftest.beam \ > conftest$ac_exeext conftest.$ac_ext > -# Static case. > -old_LDFLAGS="$LDFLAGS" > -LDFLAGS="$LDFLAGS -static" > -cat confdefs.h - <<_ACEOF >conftest.$ac_ext > +if test $static_cxx_link_check = yes; then > + # Static case. > + old_LDFLAGS="$LDFLAGS" > + LDFLAGS="$LDFLAGS -static" > + cat confdefs.h - <<_ACEOF >conftest.$ac_ext > /* end confdefs.h. */ > > #include > @@ -4244,7 +4257,8 @@ else $as_nop > fi > rm -f core conftest.err conftest.$ac_objext conftest.beam \ > conftest$ac_exeext conftest.$ac_ext > -LDFLAGS="$old_LDFLAGS" > + LDFLAGS="$old_LDFLAGS" > +fi > ac_ext=c > ac_cpp='$CPP $CPPFLAGS' > ac_compile='$CC -c $CFLAGS $CPPFLAGS conftest.$ac_ext >&5' > diff --git a/configure.ac b/configure.ac > index bdc385d03c..ee64d49b03 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -52,6 +52,12 @@ fi > AC_SUBST(cross_compiling) > AC_PROG_CPP > > +AC_ARG_ENABLE([static-c++-link-check], > + AS_HELP_STRING([--disable-static-c++-link-check], > + [disable static C++ link check @<:@default=no@:>@]), > + [static_cxx_link_check=$enableval], > + [static_cxx_link_check=yes]) > + > # We need the C++ compiler only for testing. > AC_PROG_CXX > # It's useless to us if it can't link programs (e.g. missing -lstdc++). > @@ -61,10 +67,11 @@ AC_LANG_PUSH([C++]) > AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])], > [libc_cv_cxx_link_ok=yes], > [libc_cv_cxx_link_ok=no]) > -# Static case. > -old_LDFLAGS="$LDFLAGS" > -LDFLAGS="$LDFLAGS -static" > -AC_LINK_IFELSE([AC_LANG_SOURCE([ > +if test $static_cxx_link_check = yes; then > + # Static case. > + old_LDFLAGS="$LDFLAGS" > + LDFLAGS="$LDFLAGS -static" > + AC_LINK_IFELSE([AC_LANG_SOURCE([ > #include > > int > @@ -74,9 +81,10 @@ main() > return 0; > } > ])], > - [], > - [libc_cv_cxx_link_ok=no]) > -LDFLAGS="$old_LDFLAGS" > + [], > + [libc_cv_cxx_link_ok=no]) > + LDFLAGS="$old_LDFLAGS" > +fi > AC_LANG_POP([C++])]) > AS_IF([test $libc_cv_cxx_link_ok != yes], [CXX=]) > > diff --git a/manual/install.texi b/manual/install.texi > index 7c44594617..ac3728c301 100644 > --- a/manual/install.texi > +++ b/manual/install.texi > @@ -252,6 +252,14 @@ configure with @option{--disable-werror}. > By default for x86_64, @theglibc{} is built with the vector math library. > Use this option to disable the vector math library. > > +@item --disable-static-c++-link-check > +By default, if the C++ toolchain doesn't not support static linking, > +configure couldn't find the C++ header files and the glibc build fails. > +Use this option to disable the static C++ link check so that the C++ > +header files can be located. The newly built libc.a can be used to > +create static C++ tests if the C++ toolchain has necessary static C++ > +libraries. Suggest: By default, if the C++ toolchain lacks support for static linking, configure fails to find the C++ header files and the glibc build fails. Use this option to disable the static C++ link check so that the C++ header files can be located. The newly built libc.a can be used to create static C++ tests if the C++ toolchain has the necessary static C++ libraries. > + > @item --disable-scv > Disable using @code{scv} instruction for syscalls. All syscalls will use > @code{sc} instead, even if the kernel supports @code{scv}. PowerPC only. -- Cheers, Carlos.