From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 1C481385417E for ; Mon, 11 Jul 2022 12:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C481385417E Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-10bf634bc50so6578449fac.3 for ; Mon, 11 Jul 2022 05:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vf3hqtLor5tUZOPF9o2OWoOiSIf4DKcpZRhbM8SGHUU=; b=3WkLojfxXlpyHKQ7Ux0jGq2kOhleJ43y2Y2wvLDbNRu/G+4Lybh7t7Y/vpZQjWj3Xm 7xS4T4xTpXO0CX8/oThsFsL1le2DcLJfbS+yKcwthoE43d5wDIbRQeLWd+v6Va3aVx3I 68hQMtecp2QnidHDKu6hQGeKSOCAcV+jOL2tDcOJcrWDxmIXGPAkiddrF392Y0KftkZO SWWKs/dX0//Di529ymvQU6FpvJcF0whsLECZ1Zk2DRugjZD6TbA8YnsNpT95Z06SmMsy Q7xNxsAmpItOvwLiL3HT29q+6ueDEqnjBo2fA/GcuQsxV7eF6DJK82+JEFavQSYP4UMg B2kw== X-Gm-Message-State: AJIora+QhWmN5rjzeIVUFTuHWRYAi6WzyHiHuSozUqGv32xmBNDjqNMl PoUjhNb2SVZTHk764ivJBZmA3Q== X-Google-Smtp-Source: AGRyM1sbOq+KVPgGk/OgZ8yPewMEvCkb22B+GL10mvDanmAk/rSA4Rt3FpnlP175Ucmu0pTBLJQbpw== X-Received: by 2002:a05:6870:33a7:b0:f6:dd:902 with SMTP id w39-20020a05687033a700b000f600dd0902mr6812989oae.104.1657543886409; Mon, 11 Jul 2022 05:51:26 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7cb:5bec:a591:bf2:d8b8:7a84]) by smtp.gmail.com with ESMTPSA id t11-20020a0568301e2b00b0061c266a1bf8sm2562569otr.26.2022.07.11.05.51.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2022 05:51:26 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v7 5/5] linux: Add mount_setattr From: Adhemerval Zanella In-Reply-To: <20220710022804.GA9@4928bf7262b9> Date: Mon, 11 Jul 2022 09:51:23 -0300 Cc: schwab@suse.de, carlos@redhat.com, libc-alpha@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <03C5E291-37F6-4798-B50F-48C9DC49E3B7@linaro.org> References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-6-adhemerval.zanella@linaro.org> <0c64445d-a4f7-bb60-d165-e3c02d89549e@redhat.com> <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> <20220710022804.GA9@4928bf7262b9> To: Rudi Heitbaum X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 12:51:30 -0000 > On 9 Jul 2022, at 23:28, Rudi Heitbaum wrote: >=20 > I am facing the same issue compiling gcc-12.1.0. but since > linux-Add-fsconfig.patch also facing the following error with > systemd-251.2. >=20 > I was successfully able to compile systemd-251.2 by reverting: > - linux-Add-fsconfig.patch > - linux-Add-fspick.patch > - linux-Add-open_tree.patch > - linux-Add-tst-mount-to-check-for-Linux-new-mount-API.patch > - linux-Add-mount_setattr.patch > - stdlib-Implement-mbrtoc8-c8rtomb-and-the-char8_t-typ.patch > from 2a5b4f7a715921a232f67f6810268c6cd6aa0af2 Which patch exactly broke the build, because from the logs is hard to tell exactly (specially because it should not interfere with statx definition)? >=20 > Executing (target): ninja=20 > [100/868] Compiling C object src/basic/libbasic.a.p/chase-symlinks.c.o > FAILED: src/basic/libbasic.a.p/chase-symlinks.c.o=20 > = /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0= -devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc = -Isrc/basic/libbasic.a.p -Isrc/basic -I../src/basic -Isrc/fundamental = -I../src/fundamental -Isrc/systemd -I../src/systemd -I. -I.. = -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11= .0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include = -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall = -Winvalid-pch -Wextra -std=3Dgnu11 -O0 -Wno-format-signedness = -Wno-missing-field-initializers -Wno-unused-parameter -Wdate-time = -Wendif-labels -Werror=3Dformat=3D2 = -Werror=3Dimplicit-function-declaration = -Werror=3Dincompatible-pointer-types -Werror=3Dint-conversion = -Werror=3Doverflow -Werror=3Doverride-init -Werror=3Dreturn-type = -Werror=3Dshift-count-overflow -Werror=3Dshift-overflow=3D2 = -Werror=3Dundef -Wfloat-equal -Wimplicit-fallthrough=3D5 -Winit-self = -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs = -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow = -Wstrict-aliasing=3D2 -Wstrict-prototypes -Wsuggest-attribute=3Dnoreturn = -Wunused-function -Wwrite-strings -Wno-unused-result = -Werror=3Dmissing-declarations -Werror=3Dmissing-prototypes = -fdiagnostics-show-option -fno-common -fno-strict-aliasing = -fstack-protector -fstack-protector-strong -fvisibility=3Dhidden = --param=3Dssp-buffer-size=3D4 -ffunction-sections -fdata-sections = -Werror=3Dshadow -include config.h -march=3Dx86-64-v3 -Wall -pipe -O2 = -fomit-frame-pointer -DNDEBUG -fno-schedule-insns -fno-schedule-insns2 = -Wno-format-truncation -fPIC -pthread -fvisibility=3Ddefault -MD -MQ = src/basic/libbasic.a.p/chase-symlinks.c.o -MF = src/basic/libbasic.a.p/chase-symlinks.c.o.d -o = src/basic/libbasic.a.p/chase-symlinks.c.o -c = ../src/basic/chase-symlinks.c > In file included from ../src/basic/stat-util.h:13, > from ../src/basic/chase-symlinks.h:7, > from ../src/basic/chase-symlinks.c:6: > ../src/basic/missing_stat.h:39:8: error: redefinition of 'struct = statx_timestamp' > 39 | struct statx_timestamp { > | ^~~~~~~~~~~~~~~ > In file included from = /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0= -devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/bits/statx= .h:31, > from = /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0= -devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/sys/stat.h= :465, > from ../src/basic/stat-util.h:7: > = /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0= -devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/linux/stat= .h:56:8: note: originally defined here > 56 | struct statx_timestamp { > | ^~~~~~~~~~~~~~~ > ../src/basic/missing_stat.h:45:8: error: redefinition of 'struct = statx' > 45 | struct statx STATX_DEFINITION; > | ^~~~~ > = /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0= -devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/linux/stat= .h:99:8: note: originally defined here > 99 | struct statx { > | ^~~~~ >=20 > Regards > Rudi >=20 > On Wed, Jul 06, 2022 at 09:21:32AM -0300, Adhemerval Zanella wrote: >>=20 >>> On 6 Jul 2022, at 06:25, Andreas Schwab wrote: >>>=20 >>> This is causing a conflict with , breaking the build = of >>> gcc. >>>=20 >>> In file included from /usr/include/linux/fs.h:19, >>> from = ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.= cpp:76: >>> /usr/include/linux/mount.h:95:6: error: multiple definition of 'enum = fsconfig_command' >>> 95 | enum fsconfig_command { >>> | ^~~~~~~~~~~~~~~~ >>> In file included from = ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.= cpp:63: >>> /usr/include/sys/mount.h:189:6: note: previous definition here >>> 189 | enum fsconfig_command >>> | ^~~~~~~~~~~~~~~~ >>> /usr/include/linux/mount.h:129:8: error: redefinition of 'struct = mount_attr' >>> 129 | struct mount_attr { >>> | ^~~~~~~~~~ >>> /usr/include/sys/mount.h:161:8: note: previous definition of 'struct = mount_attr' >>> 161 | struct mount_attr >>> | ^~~~~~~~~~ >>> make[4]: *** [Makefile:617: sanitizer_platform_limits_posix.lo] = Error 1 >>=20 >> I am not sure how to handle it, glibc sys/mount.h should be a = standalone >> header. Maybe check if _UAPI_LINUX_MOUNT_H is defined so to use the >> kernel definition? Or check the kernel version and __has_include and = use >> kernel version instead? >>=20 >>>=20 >>> --=20 >>> Andreas Schwab, SUSE Labs, schwab@suse.de >>> GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 = 0EEA B9D7 >>> "And now for something completely different." >>=20