From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 052EF3858D1E for ; Tue, 21 May 2024 19:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 052EF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 052EF3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716321179; cv=none; b=RZlPoMXvrfEd+37cJmPLrqNB1G9Upvbz6a+/HQme71hYdisCiyowtCiYjpSksD6cAT6Jzt1G+r/J8UxTi7LQefUklPP1KXgrRo0mubluQc8NklV2DpbWWQYcVsAOV5vSQpHN44OcwczHjXJJcjtwW4VmWLYjAD8lmWDecoW5kd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716321179; c=relaxed/simple; bh=F6GGkLp/UmEKUnitBAg0fafJ7F3zyX6mvTOhKZKiUDw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LwemkQwr3rCwHt1801PPZg6Wf4ph5j7noZUT8tGiDmjdxCr0u7Pv4SmeUAF+jucDLcgJragITCvj0sED7U7QIrPWQXOf1CbGMe2BZ4wVwyFFDBHS5SoAomkQpNkRna4/AUOrT0qQjqDTuXB/qDMuvdGWYry8AYD+QHao7tj3mjo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1ec92e355bfso5683995ad.3 for ; Tue, 21 May 2024 12:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716321176; x=1716925976; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=+Q95x3XvWC+4Xewk/TC7EbDjXJKDRj+5hUVAVa4992A=; b=vo8vN2LaJBIRkaohvshlP/OwOU2n3NaXdCr+NSrwS4/CjH+4MNDkYEabrDTY814fea 92RzdAYgPuQufgj/FPnAHH2+uWbX5CUZq9NrVYmb7Knh98aFtsv+5bNOU8xSNwCdfpGM cFCQTGbNVfxOaO9GTeY6xPaTVabaNV38TpXhjV/GsHRWM6jAI5Ch/v/5DfrAli0h8bEp apEuKsUbYg0ks/4ZcUq9bRsx+joyfSoFlMOH+VxWctPQFfd/7ke2TBppLo0WqEwmrla/ O565VkI32IgkpbBFZ6n8sOpZKlZNFfvoKIfJ2HWSBRmzORQ9f4hCFiVJwxa9gUjA8FsT kiPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716321176; x=1716925976; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Q95x3XvWC+4Xewk/TC7EbDjXJKDRj+5hUVAVa4992A=; b=Dv6H2kIw8+y9xYA52NLgNoBVpf6e6gHGMOjxnZurRydZ2OjECVb1TIUl1bWe+KKLN8 4LsVJiH16QYmE0EvMJgx/10nFzyoAJZHc7e23sTnXQFFwZhd5yIzsgl+Pfmx2cRhPJml bJxvp/tniB4EM6ko6hQtQtgHniJ5nwIlPZ2cMjezK8N6ykIMj6Yw3KPCBgpkJXLgsjhV TGDAvSqerY37rnLl6zl3hZZaxy3gFjq6XaqJwJMZag8VOUlwBBtvZRL/vwgazLiJRZel e0/9m55MXCX/CkauzkdGgoWNckgYKRd8oFUHYAy7rc2SDzYRFJEK3NzAxsnNJYQ7xWsh gXJw== X-Gm-Message-State: AOJu0YwVDinbpsqGMIDbIpn6Fsw+SjjijzE8HGlfGHcm/djyDOrzZbBw sSWaKWDzrToI0aKCt4f/mxNKVqIaehriwRV1SeDS/tc/OXaisLdkDUUKicP/k7A= X-Google-Smtp-Source: AGHT+IEFYZhVhTKzZCcx9mIpTPpwuS3+cRe/gk/2K/M23N6TTo5nheKQtoIbhrCXQ6st5rTJsJeFvA== X-Received: by 2002:a17:902:e5cd:b0:1f3:164a:4b4c with SMTP id d9443c01a7336-1f3164a4c8amr9000485ad.12.1716321175781; Tue, 21 May 2024 12:52:55 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf? ([2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f31406ee31sm7742885ad.95.2024.05.21.12.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 12:52:55 -0700 (PDT) Message-ID: <03c27032-173e-45aa-8bcc-f37177a1fedb@linaro.org> Date: Tue, 21 May 2024 16:52:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 To: "H.J. Lu" Cc: libc-alpha@sourceware.org References: <20240521165430.2998944-1-adhemerval.zanella@linaro.org> <20240521165430.2998944-4-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/05/24 14:34, H.J. Lu wrote: > On Tue, May 21, 2024 at 9:54 AM Adhemerval Zanella > wrote: >> >> Checked with a static build for the affected ABIs. >> --- >> sysdeps/ieee754/ldbl-64-128/s_copysignl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> index 11b42d04ba..80137847d3 100644 >> --- a/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> +++ b/sysdeps/ieee754/ldbl-64-128/s_copysignl.c >> @@ -1,10 +1,10 @@ >> #include >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED >> # undef libm_alias_ldouble >> # define libm_alias_ldouble(from, to) >> #endif >> #include >> -#if IS_IN (libc) >> +#if IS_IN (libc) && defined SHARED >> long_double_symbol (libc, __copysignl, copysignl); >> #endif >> -- >> 2.43.0 >> > > I think you should combine copysignf128, frexpf128, modff128 patches > and also fix scalbnf128 in a single patch for: > > https://sourceware.org/bugzilla/show_bug.cgi?id=31781 > Ack, although scalbnf128 is already exported by libc.a.