From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward502a.mail.yandex.net (forward502a.mail.yandex.net [178.154.239.82]) by sourceware.org (Postfix) with ESMTPS id 892A8385843E for ; Wed, 15 Feb 2023 13:33:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 892A8385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yandex.ru Received: from vla3-23c3b031fed5.qloud-c.yandex.net (vla3-23c3b031fed5.qloud-c.yandex.net [IPv6:2a02:6b8:c15:2582:0:640:23c3:b031]) by forward502a.mail.yandex.net (Yandex) with ESMTP id 0D4E25F063; Wed, 15 Feb 2023 16:33:47 +0300 (MSK) Received: by vla3-23c3b031fed5.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id jXkWY11Yc4Y1-Ruafa2jp; Wed, 15 Feb 2023 16:33:46 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1676468026; bh=Ro0alJcC8I5sN67O+YKA810srhpLrSCR4qsLHD1Hr2I=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=rNVM3KehZqGaVgRRzhUjEnLUrcr+Q36+b6+/zm0WHGTGHOJFdT5cLBRwWjCtOiFrh HgKv9TK0715VU0OMr43Gbb6LMTFRTGVqd3AUqD3qdDo+61sTw9YPgMAQ6C9WUGtnIT mjdTYf0yv5yWX8NlMEXU539r7Ayj7LRl1e++mPI8= Authentication-Results: vla3-23c3b031fed5.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <03f0825e-7d30-9c9a-1c7a-f3a805a98a60@yandex.ru> Date: Wed, 15 Feb 2023 18:33:45 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] elf: strdup() l_name if no realname [BZ #30100] Content-Language: en-US To: Andreas Schwab , Stas Sergeev via Libc-alpha References: <20230215112110.2426646-1-stsp2@yandex.ru> <20230215112110.2426646-2-stsp2@yandex.ru> From: stsp In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, 15.02.2023 17:35, Andreas Schwab пишет: > On Feb 15 2023, Stas Sergeev via Libc-alpha wrote: > >> diff --git a/elf/dl-object.c b/elf/dl-object.c >> index f1f2ec956c..c92daf37d1 100644 >> --- a/elf/dl-object.c >> +++ b/elf/dl-object.c >> @@ -122,7 +122,7 @@ _dl_new_object (char *realname, const char *libname, int type, >> #endif >> new->l_name = realname; >> else >> - new->l_name = (char *) newname->name + libname_len - 1; >> + new->l_name = __strdup ((char *) newname->name + libname_len - 1); > Since the point of that assignment is to create a pointer to an > allocated empty string, it would be better to make that explicit by > using __strdup (""), with a suitable adjustment of the comment. Done and re-sent.