From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 8AB9E3858418 for ; Wed, 6 Sep 2023 16:56:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AB9E3858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6beff322a97so69960a34.3 for ; Wed, 06 Sep 2023 09:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694019404; x=1694624204; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3/oVeEqkMnjDRsWx0Ufs/rxZVuqIt6EIeAkQZJUmqFc=; b=p/ILd8CcdjwKhNCAnHaFGwdBV823iYcdt7uvb1wX2KeukUEEe/AbLkXpm56rx/Ux9i koKcvT+3B1Jsmk8JkrSBlhYVggpM7Ignc5Znw9wRo9/vhK2RrnVbKD+768n/25jQWp+s I+hDvO9bY8Dwdaefa9zWSuyiAwhjwi+Frhupatc91H0Gy1K9VO3eCaU9hovariQxHIgH PwpepYLTNh9dbpc28NtwO1tKOKZ8JtZphzfLtjjVaokWbmSzbqBnU4/EMGVX+YEop13Z 7rjTi1p65FkpBb6mxj1+2no8DMXXST8Zc08FZ5CopM61nkIQyc8HyDuBvYJLdnil4sGZ h0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694019404; x=1694624204; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3/oVeEqkMnjDRsWx0Ufs/rxZVuqIt6EIeAkQZJUmqFc=; b=dS0ffimsx0tCeZ/cEbbxyaUI9Sx0ZRjOA8ZSRdh1wc1VjRqJSpW95E0FkqdCeM+VzB d3gaDwXo09dXp8kAcW33LFCaBjSCVU8UVIAfu9EcU6BQXTV/iCwLpk5P7MLJ5SfuZgzZ 1FtPBuOjAjtaIEDoUkCaRMBWYUUIdoe/HBYVyYuPM/BgmbHUFnFgH5ZJl5b2mXAJSenI nL9jVhF4GVJ2/yrasIdFKvSLRP06sh+vEm/3dXIwtpnYXoDwCK31/LkTfWiG6GobmAc7 llMxBEvD5YdfgngOqPoirb2hHQd08pxgtj/6jzPekjxIdmdPH8OTLvAdGGeLNViNNsAR 5tTw== X-Gm-Message-State: AOJu0YyXkkSSQuWBz4seVRNIJ5AR6E+a2d3B0hG5+kcRpQAyWOdTpCP2 m4j9VIa3+a7jIW1ReuzD2Oy658tnxbGRBKxRRv8WLQ== X-Google-Smtp-Source: AGHT+IHEpImiJPj4Y3WTw537phKHLoP0UVrAQGcY3WZZ6Exoel7Z0UzHRv5BCjQVvpSW/G9IFC1peg== X-Received: by 2002:a9d:744d:0:b0:6b8:6f94:d3a2 with SMTP id p13-20020a9d744d000000b006b86f94d3a2mr16748967otk.25.1694019403906; Wed, 06 Sep 2023 09:56:43 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:fee4:992a:f56:846:f11c? ([2804:1b3:a7c3:fee4:992a:f56:846:f11c]) by smtp.gmail.com with ESMTPSA id z14-20020a9d65ce000000b006b871010cb1sm6729900oth.46.2023.09.06.09.56.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 09:56:43 -0700 (PDT) Message-ID: <04402456-1e27-835a-8c39-d1d0388da65c@linaro.org> Date: Wed, 6 Sep 2023 13:56:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] fxprintf: Get rid of alloca Content-Language: en-US To: Joe Simmons-Talbott Cc: libc-alpha@sourceware.org References: <20230707175349.2096131-1-josimmon@redhat.com> <20230810133344.GH3849957@oak> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230810133344.GH3849957@oak> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/08/23 10:34, Joe Simmons-Talbott wrote: > On Wed, Jul 19, 2023 at 03:12:43PM -0300, Adhemerval Zanella Netto wrote: >> >> >> On 07/07/23 14:53, Joe Simmons-Talbott via Libc-alpha wrote: >>> Use a scratch_buffer rather than alloca/malloc to avoid potential stack >>> overflow. >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella > > Should I apply this despite the seemingly unrelated test timeout[1] in > CI? > > [1] > https://patchwork.sourceware.org/project/glibc/patch/20230707175349.2096131-1-josimmon@redhat.com/ Yes, I think this failure is transient.