From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100135 invoked by alias); 28 Oct 2016 15:08:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 100058 invoked by uid 89); 28 Oct 2016 15:08:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-qt0-f171.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=BPsTGfsmSPPdCUIE3L/ReuBaXZ3a17/oq3jNzQU1CFU=; b=HcKCfbXrO3gC/L19TrW45Hv3bRrU/fUct/b4rICY2XilRGuH1IOLCEg0f3Zxt4KwWb C5rt5YvSiSkk6eH3YVzdqVPt8i861L9H/wosNlA/2eCuU30XR15BbuKY/n/V3jXEj+JA FlAfR4Y0tZmcAxOBWW+veiL78XoKOVv23bvI2iryhMszIFdPrDrRDtjpBTFdmCMU8Y4n UdbWvF7ze5l8bWRPTCYcPJ0v0qutLnZDB5ondYg2Hxz/9IfmORdYnyO1V/oa3l4CvOAt 3ioBeURsjaay0nH6sW/jk5Nu7keS8qvcuR9q95fBvqFtZVqRJMF5+izlQM89il83D1YX UwKg== X-Gm-Message-State: ABUngvcSHco1NhEjGiswIMczq9npUjnX5ulCP6FphPFS12d+Z3emt285ypXOnO4eD0rtXao7 X-Received: by 10.200.58.135 with SMTP id x7mr12044377qte.93.1477667315847; Fri, 28 Oct 2016 08:08:35 -0700 (PDT) Subject: Re: [PATCH] i386: Support CFLAGS which imply -fno-omit-frame-pointer [BZ #20729] To: Florian Weimer , libc-alpha@sourceware.org References: <20161028150542.A781D439942E0@oldenburg.str.redhat.com> From: Carlos O'Donell Message-ID: <044f7bf1-4aa6-ba2d-db81-d93459bf06ab@redhat.com> Date: Fri, 28 Oct 2016 15:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161028150542.A781D439942E0@oldenburg.str.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00547.txt.bz2 On 10/28/2016 11:05 AM, Florian Weimer wrote: > 2016-10-28 Florian Weimer > > [BZ #20729] > Support i386 builds with CFLAGS which imply -fno-omit-frame-pointer. > * sysdeps/unix/sysv/linux/i386/Makefile > (uses-6-syscall-arguments): Define. > [subdir == misc] (CFLAGS-epoll_pwait.o, CFLAGS-epoll_pwait.os) > (CFLAGS-mmap.o, CFLAGS-mmap.os, CFLAGS-mmap64.o, CFLAGS-mmap64.os) > (CFLAGS-pselect.o, CFLAGS-pselect.os, CFLAGS-rtld-mmap.os): Use it. > [subdir = sysvipc] (CFLAGS-semtimedop.o, CFLAGS-semtimedop.os): > Likewise. > [subdir = io] (CFLAGS-posix_fadvise64.o, CFLAGS-posix_fadvise64.os) > (CFLAGS-posix_fallocate.o, CFLAGS-posix_fallocate.os) > (CFLAGS-posix_fallocate64.o, CFLAGS-posix_fallocate64.os) > (CFLAGS-sync_file_range.o, CFLAGS-sync_file_range.os) > (CFLAGS-fallocate.o, CFLAGS-fallocate.os, CFLAGS-fallocate64.o) > (CFLAGS-fallocate64.os): Likewise. > [subdir = nptl] (CFLAGS-pthread_rwlock_timedrdlock.o) > (CFLAGS-pthread_rwlock_timedrdlock.os) > (CFLAGS-pthread_rwlock_timedwrlock.o) > (CFLAGS-pthread_rwlock_timedwrlock.os, CFLAGS-sem_wait.o) > (CFLAGS-sem_wait.os, CFLAGS-sem_timedwait.o) > (CFLAGS-sem_timedwait.os): Likewise. I like 'uses-6-syscall-arguments' to make this more readable. LGTM. Tested on i486 build. -- Cheers, Carlos.