From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BD3B3386001F for ; Mon, 31 Jan 2022 16:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD3B3386001F Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-6nbh4CE8N3m_9du5GuQvjw-1; Mon, 31 Jan 2022 11:07:30 -0500 X-MC-Unique: 6nbh4CE8N3m_9du5GuQvjw-1 Received: by mail-qv1-f69.google.com with SMTP id kc19-20020a056214411300b00422b7cdea6eso13077282qvb.19 for ; Mon, 31 Jan 2022 08:07:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=egWWJ6cpqp7pSU5fOP7TyGxfI39a9uRrgFqbSD73diI=; b=rHK4Cmwz68QDWY+YZt42DawYCXTw9dY2HCKGYZ5Bnzxp3MAtpVHS4lO27ZJJdAc9Hc 4GUxwZQt5+Ky4QLHC9Zvc/tEDChtYl3n6sW7A+vwJFkvwPgoPOJzoE4Ju695dY8s3DTg 957Cao+sYAxY69wDuoknSbeTKY6n0GsICCFCoeq2qHHsaTK3C1l2OmUJJ74XpcAkrZsH 2jKNEB0By93AwrdzoDhhZdT8HA5sRGG0yeilLOy1pDVzquhtw4zmenzEomfmuzWGL+Od sedXcydeJV2PnAuqtdnubT0YhpwSVePlip3+LzoCpn2GwSdzcyoo6tvblh18/CEql+1o M4Zg== X-Gm-Message-State: AOAM532TQCA4mO3UjJkWox6knKLEa+JJLrUZNbslxq5RfjUT7AVxEGsK ZK9qbSMtU8vuM9B2Fez7yeg/lSMXVnmYFZyZL13vUOswdbW54Czf9QiwoR0AzjV3+aKvLEkGVDn p+r7xojgdTsllaJVl2btE X-Received: by 2002:ae9:eb89:: with SMTP id b131mr13637681qkg.509.1643645249191; Mon, 31 Jan 2022 08:07:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSlcknE5L1X7vvrez8var/Xokx4mgNly/zPE4ULwWcTSH+/ATiJvGjD3rQvpC16NLOvwJa9g== X-Received: by 2002:ae9:eb89:: with SMTP id b131mr13637661qkg.509.1643645248943; Mon, 31 Jan 2022 08:07:28 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id m16sm1743596qkp.21.2022.01.31.08.07.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 08:07:28 -0800 (PST) Message-ID: <046496d5-ab92-f568-47f2-2e39aaeffc76@redhat.com> Date: Mon, 31 Jan 2022 11:07:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/2] localedata: Adjust C.UTF-8 to align with C/POSIX. To: Andreas Schwab , Carlos O'Donell via Libc-alpha Cc: fweimer@redhat.com, michael.hudson@canonical.com References: <20220131053442.3995804-1-carlos@redhat.com> <20220131053442.3995804-3-carlos@redhat.com> <87k0eg70mm.fsf@igel.home> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87k0eg70mm.fsf@igel.home> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 16:07:33 -0000 On 1/31/22 03:47, Andreas Schwab wrote: > On Jan 31 2022, Carlos O'Donell via Libc-alpha wrote: > >> +% >> +% This field is consciously aligned with ISO 30112 and the C/POSIX locale. >> +week 7;19971130;4 > > The copy of ISO 30112 that I could find says 7;19971201;4. > First and foremost we try to align with C/POSIX builtin locale. Aligning with C/POSIX ensures that application developers can seamlessly change from "C" to "C.UTF-8" without breaking existing tests. e.g. locale/C-time.c 135 { .string = "\7" }, 136 { .word = 19971130 }, 137 { .string = "\4" }, I'm using ISO 30112 WD12 (2018-02-12), which I have access to as part of my SC22 involvement. This version would go on to become the final published standard 2020-09, though I don't yet have a copy of this version. Section 4.7 "LC_TIME" under week: ~~~ If the keyword is not specified the values are taken as 7, 19971130 (a Sunday), and 7 (Saturday), respectively. ISO 8601 conforming applications should use the values 7, 19971201 (a Monday), and 4 (Thursday), respectively. ~~~ This matches the ISO 30112 WD10 [2014] that was used when creating the defaults in ld-time.c: 482 /* Set up defaults based on ISO 30112 WD10 [2014]. */ 483 if (time->week_ndays == 0) 484 time->week_ndays = 7; 485 486 if (time->week_1stday == 0) 487 time->week_1stday = 19971130; 488 489 if (time->week_1stweek == 0) 490 time->week_1stweek = 7; This also matches the legacy withdrawn ISO/IEC 14652:2002. I could change the comment to read: % This field is consciously aligned with the builtin C/POSIX locale. Would a new comment resolve your review? -- Cheers, Carlos.