From: Florian Weimer <fweimer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] ldconfig: Call fsync on temporary files before renaming them [BZ #20890]
Date: Fri, 12 Jan 2018 11:54:00 -0000 [thread overview]
Message-ID: <04ab390b-f7e9-86b8-b0e2-92035347d4b4@redhat.com> (raw)
In-Reply-To: <20180112113748.GA27109@lst.de>
On 01/12/2018 12:37 PM, Christoph Hellwig wrote:
> On Fri, Jan 12, 2018 at 12:07:57PM +0100, Florian Weimer wrote:
>> If the system crashes before the file data has been written to disk, the
>> file system recovery upon the next mount may restore a partially
>> rewritten temporary file under the non-temporary (final) name (after the
>> rename operation).
>>
>> Some file systems perform an implicit fsync before renaming a file over
>> another one, but XFS does not, for example.
>
> At least on Linux no file system performs an actual fsync equivalent.
> A few do start a writeout, but don't actually wait on it.
Oh. I'll drop the last paragraph from the commit message, then.
Thanks,
Florian
next prev parent reply other threads:[~2018-01-12 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 11:08 Florian Weimer
2018-01-12 11:37 ` Christoph Hellwig
2018-01-12 11:54 ` Florian Weimer [this message]
2018-01-13 2:28 ` Paul Eggert
2018-01-19 16:40 ` Florian Weimer
2018-02-20 14:03 ` Florian Weimer
2018-02-20 14:23 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ab390b-f7e9-86b8-b0e2-92035347d4b4@redhat.com \
--to=fweimer@redhat.com \
--cc=hch@lst.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).