From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id E52C4388C012 for ; Wed, 28 Jul 2021 17:35:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E52C4388C012 Received: by mail-pj1-x1033.google.com with SMTP id ca5so6214528pjb.5 for ; Wed, 28 Jul 2021 10:35:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zuKhzqqJC1n7OXuzQLHPbBWDCEkwKB1JD3URdBPPqAg=; b=jYjw36STKg0BqXgcibvUYs0pawyRWK0kh+84mkHNN+r1S+53IciaBnbH795ZSgJiDW US7i4KBesWooVqfMPweT2svwGQIy9p/G4DiFfYjC3peBdPStEhZiCGd3bnwUiTTEoXdH eHwWlCv+eyy7ncmdd4mDU42uAB9vU2Il1nYbPJncVXp5RDaZ0cBDcxGq0F0o0T3Gdfb1 k0PrEup+kuoIdGynFIeQ8jY08uWMZ0UuxjlyfGlvgp9WxYj/xWdTt3lWO6pHHMJsCeRL 1EaCCo81rfINhzOzKyDEcB+Iv/O0jEj3KChb/bM3kbTvQC3UDbqJumxaXyQyjhQgmRJh lFAw== X-Gm-Message-State: AOAM5309s5F0NKmahlgAVKpcVHixzTe0K5a8gLCXAQvWibta3zqhnrxO oYrYGMnY7vzT+JoiE7YCjJS0pbdFKF4mEQ== X-Google-Smtp-Source: ABdhPJzhzOJGQ+YihhWnk6Jjnh3QwjA7J9iaC2L3SZQQNzKoYEY4BxnIYaoe4WbzsCg918yiilo41Q== X-Received: by 2002:a62:798e:0:b029:327:6d4a:c4db with SMTP id u136-20020a62798e0000b02903276d4ac4dbmr879322pfc.50.1627493719793; Wed, 28 Jul 2021 10:35:19 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:43e2:b556:b9a4:7138:fcc1? ([2804:431:c7cb:43e2:b556:b9a4:7138:fcc1]) by smtp.gmail.com with ESMTPSA id dw15sm327304pjb.42.2021.07.28.10.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 10:35:19 -0700 (PDT) Subject: Re: [PATCH] Typo: Rename HAVE_CLONE3_WAPPER to HAVE_CLONE3_WRAPPER To: "H.J. Lu" , Florian Weimer , Carlos O'Donell Cc: "Andreas K. Huettel via Libc-alpha" References: <87eebkf8ph.fsf@oldenburg.str.redhat.com> <5551022.NgBsaNRSFp@pinacolada> <87y29r9gqc.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <04bd7e3b-621f-a9ba-de73-82f8ad5b7552@linaro.org> Date: Wed, 28 Jul 2021 14:35:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 17:35:23 -0000 On 28/07/2021 14:22, H.J. Lu via Libc-alpha wrote: > On Tue, Jul 27, 2021 at 9:59 PM Florian Weimer via Libc-alpha > wrote: >> >> * Andreas K. Huettel via Libc-alpha: >> >>> Semi-related... >>> >>>> int ret; >>>> -#ifdef HAVE_CLONE3_WAPPER >>>> - /* Try clone3 first. */ >>>> - int saved_errno = errno; >>> >>> shouldn't this be WRAPPER ? >>> >>> (It seems to be consistent in the code, so no harm done so far...) >> >> Yes, it should be. And yes, it's currently consistent. But it's >> confusing if you search for it and don't make the typo. >> >> Thanks, >> Florian >> > > Here is the patch. OK for master? > LGTM, thanks.