From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 1/5] Sync getcwd with gnulib
Date: Wed, 2 Sep 2020 08:50:45 -0300 [thread overview]
Message-ID: <04cffabc-c36c-5906-f12c-3aed9ee36acb@linaro.org> (raw)
In-Reply-To: <c01cc5a3-8c88-d6ae-055e-3017e2e35890@cs.ucla.edu>
On 01/09/2020 18:24, Paul Eggert wrote:
> On 9/1/20 1:37 PM, Adhemerval Zanella via Libc-alpha wrote:
>
>> It sync with gnulib version 615b43e1f9. The only change is the usage
>> of GETCWD_RETURN_TYPE so the linux getcwd implementation defines the
>> generic implementation as static.
>
> That particular patch results in other changes with Gnulib version 615b43e1f, such as __readdir64 vs __readdir. Perhaps change the wording to:
>
> "This is the first of a series of patches to sync with Gnulib commit 615b43e1f9. This patch adopts most of the changes of Gnulib, except it retains GETCWD_RETURN_TYPE and does not always use a 64-bit internal API. These remaining discrepancies will be addressed in later patches in this series."
Ack, I will use. I usually avoid refer to other patches to make this change
somewhat independent.
>
>> +#if !_LIBC
>> +# include <config.h>
>> +# include <unistd.h>
>> +#else
>
> This needs '# include "pathmax.h"' after '# include <unistd.h>' so that the entire set of patches will result in the Gnulib version you mentioned. This include does not affect Glibc, only the Gnulib side.
Ack.
>
> Otherwise, this patch looks good, as do the 2nd and 3rd patches. The remaining ones could use another pair of eyes.
Thanks.
prev parent reply other threads:[~2020-09-02 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 20:37 Adhemerval Zanella
2020-09-01 20:37 ` [PATCH v2 2/5] linux: Remove __ASSUME_ATFCTS Adhemerval Zanella
2020-09-01 20:37 ` [PATCH v2 3/5] Use LFS readdir in generic POSIX getcwd [BZ# 22899] Adhemerval Zanella
2020-09-01 20:37 ` [PATCH v2 4/5] linux: Simplify getcwd implementation Adhemerval Zanella
2020-09-01 20:37 ` [PATCH v2 5/5] io: Reorganize the " Adhemerval Zanella
2020-09-01 21:24 ` [PATCH v2 1/5] Sync getcwd with gnulib Paul Eggert
2020-09-02 11:50 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04cffabc-c36c-5906-f12c-3aed9ee36acb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).