From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 9A1713858407 for ; Fri, 17 Dec 2021 18:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A1713858407 Received: by mail-vk1-xa30.google.com with SMTP id b192so2144484vkf.3 for ; Fri, 17 Dec 2021 10:46:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=EFXf8dm/X7/OKoViOjf91MKMdi3HINQO+FS9YI8ccXo=; b=PHjMawpBuyKluJ16lQWE2HBrfvh37RzxxLe9CC0EuQRgMM0Y9IzuzKHoySeZI6f0i+ EcIfUpXIikLUFRM6Uhj4fe0vMc4SEIjVNnaGE/J5GPhO6XRS0pLAEbfzqhgw0y+ESesr fZuT28+J+IoFSPBoYQYddcjCHh1zRaucEfOycYSJ/3vgOHLG2+dVY8bzjVE9HWmR5cl6 GDw/LKyl7BPJvGEfXajR6qNFk09+HmdwHVH5+RuyvBu8J+JbLDUOvE1Kk5ESWlaIL6Og XcxpqWSltX/b9gHepVafc17NGA5HB0Pkxz29kkd2koCLdOZxFpmxcuHFO6XQClguL5Je 8S3w== X-Gm-Message-State: AOAM530RSenDx+reLskbnSao0bju/yTmPIfDZyiQ3/i5eWunxs4AK0NA rpHnY43NvSJoAMb4ccQJCpzazQ== X-Google-Smtp-Source: ABdhPJyK0QxBwbuzyyucRAN1sgROehEyRLbwog/ThxB4xofKY6aK46G4XFPHLGlvx/698H/HfK+uqA== X-Received: by 2002:ac5:ccb8:: with SMTP id p24mr2021623vkm.31.1639766781963; Fri, 17 Dec 2021 10:46:21 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id t128sm594277vkf.32.2021.12.17.10.46.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 10:46:21 -0800 (PST) Message-ID: <04fc34a4-9662-aff0-4565-2195eacf7768@linaro.org> Date: Fri, 17 Dec 2021 15:46:19 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 06/20] elf: Add _dl_audit_symbind_alt and _dl_audit_symbind Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-7-adhemerval.zanella@linaro.org> <87fsqri3a7.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87fsqri3a7.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 18:46:23 -0000 On 17/12/2021 13:50, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/elf/dl-audit.c b/elf/dl-audit.c >> index ef34ff761c..8e4c65fdaf 100644 >> --- a/elf/dl-audit.c >> +++ b/elf/dl-audit.c >> @@ -16,6 +16,7 @@ > >> +void >> +_dl_audit_symbind_alt (struct link_map *l, const ElfW(Sym) *ref, void **value, >> + lookup_t result) > >> +_dl_audit_symbind (struct link_map *l, struct reloc_result *reloc_result, >> + const ElfW(Sym) *defsym, DL_FIXUP_VALUE_TYPE *value, >> + lookup_t result) >> +{ > > The call to _dl_audit_symbind is added in patch 10 of the series (“elf: > Avoid unnecessary slowdown from profiling with audit (BZ#15533)”). > > But I would expected this patch here to replace the copy in > elf/dl-runtime.c. It does make sense, ack.