From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 4265A3857C70 for ; Tue, 25 Jan 2022 18:27:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4265A3857C70 Received: by mail-ot1-x32e.google.com with SMTP id g15-20020a9d6b0f000000b005a062b0dc12so5842629otp.4 for ; Tue, 25 Jan 2022 10:27:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=InuD/p++Uxmyoi2OBKMsPCNlKo+S7M1GIuUp/7AO+jE=; b=hhGjzsQDMxNRTK1j3x3dO+9EFx/77q6lKDGC7IY4jxJI+FXO18al/0IkO4oOxVOIJR aqHDLoqu9RFbO/fGQstt8oBSB6pznFzRztN62vjeS1hrStApl6BozzabfoZ7QZOFX9fq cV7Nbg/EvxWXykEILi6lmubWkp27RfAifaTUIQ4PpKKDBItB8V7cS2KukOEqUr46gPfw hQxdRHdy5cEvf6frQnLx5JOxs8PFSNzcodUsA+4rJPoR1j+lz4dyngRTabM1iJVn61rb c6sYKexjDAr784aDw5kXC4Pslad2qN/TVPdS7CYx4Gmy8YOk+cpafAzTzOm+W6fBWLaR 3smg== X-Gm-Message-State: AOAM531RzSylCNdT/99EzxbWMvczLKkV+Jx4rETecN6J2XQ3u8U9m/LI DiAyC1DxEo+TUXn5lL3I+huVgA== X-Google-Smtp-Source: ABdhPJwgpYcxKYp3FsQ2jf0a7vV4eMjhE+j2HxdZX1YKaHcWvIA/fp48a+VRsdZb1U+ymuMZF1LYNg== X-Received: by 2002:a9d:34b:: with SMTP id 69mr4272205otv.259.1643135270566; Tue, 25 Jan 2022 10:27:50 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:27f8:5bed:1499:268c:5587? ([2804:431:c7cb:27f8:5bed:1499:268c:5587]) by smtp.gmail.com with ESMTPSA id w7sm6259447oou.13.2022.01.25.10.27.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 10:27:49 -0800 (PST) Message-ID: <051f1439-038e-3f0f-f014-0eb8ac48d94d@linaro.org> Date: Tue, 25 Jan 2022 15:27:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v11 1/4] elf: Add la_activity during application exit Content-Language: en-US From: Adhemerval Zanella To: Carlos O'Donell , libc-alpha@sourceware.org, jma14 Cc: John Mellor-Crummey , Ben Woodard References: <20220124134618.992988-1-adhemerval.zanella@linaro.org> <20220124134618.992988-2-adhemerval.zanella@linaro.org> <9a2bd363-d48e-6e20-0bd2-a7e374c6e3cd@redhat.com> <978ef9e9-a0bc-a9ad-0675-6b7c3c706742@linaro.org> In-Reply-To: <978ef9e9-a0bc-a9ad-0675-6b7c3c706742@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 18:27:52 -0000 On 25/01/2022 00:06, Adhemerval Zanella wrote: > > > On 24/01/2022 18:47, Carlos O'Donell wrote: >> On 1/24/22 08:46, Adhemerval Zanella wrote: >>> la_activity is not called during application exit, even though >>> la_objclose is. >> >> This fails on my x86_64 tester. >> >> tst-audit23.c:150: numeric comparison failure >> left: 140392013825880 (0x7faf901d0758); from: cookie >> right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie >> tst-audit23.c:150: numeric comparison failure >> left: 140392013825880 (0x7faf901d0758); from: cookie >> right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie >> tst-audit23.c:150: numeric comparison failure >> left: 93825010503032 (0x5555566c0d78); from: cookie >> right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie >> tst-audit23.c:145: numeric comparison failure >> left: 2 (0x2); from: acts[nacts] >> right: 140392013825880 (0x7faf901d0758); from: cookie >> tst-audit23.c:214: numeric comparison failure >> left: 2 (0x2); from: last_act_cookie >> right: 140392013825880 (0x7faf901d0758); from: cookie >> tst-audit23.c:132: numeric comparison failure >> left: 2 (0x2); from: last_act >> right: 0 (0x0); from: LA_ACT_CONSISTENT >> tst-audit23.c:150: numeric comparison failure >> left: 140392013825880 (0x7faf901d0758); from: cookie >> right: 2 (0x2); from: last_act_cookie >> error: 7 test failures >> >> Reproduces with: >> make test t=elf/tst-audit23 >> >> Tester is using: "--enable-hardcoded-path-in-tests" to exercise slightly >> different testing paths. > > I really can't reproduce it neither on x86_64 nor on i686 with both > gcc 11 and 12. And the buildbot also did not trigger any failure. > I checked with both with and without --enable-hardcoded-path-in-tests, > and also on aarch64 and powerpc64le. > > So maybe is it something in your environment? It is a failure on the test in fact, the patch below fixed it: diff --git a/elf/tst-audit23.c b/elf/tst-audit23.c index c6393a31ff..abc35791a5 100644 --- a/elf/tst-audit23.c +++ b/elf/tst-audit23.c @@ -131,7 +131,7 @@ do_test (int argc, char *argv[]) if (cookie != last_act_cookie && last_act_cookie != -1) TEST_COMPARE (last_act, LA_ACT_CONSISTENT); - if (this_act == LA_ACT_ADD && acts[nacts - 1] != cookie) + if (this_act == LA_ACT_ADD && acts[nacts] != cookie) { acts[nacts++] = cookie; last_act_cookie = cookie;