From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11957 invoked by alias); 30 Nov 2016 12:24:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11743 invoked by uid 89); 30 Nov 2016 12:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=month X-HELO: mail-ua0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=P+QWdFiqzpHq3HiYf+77os3aTTl7Pff9YLscL3pHPPc=; b=WZgUG+u8LLvXb6cuIja+LCPo/E31N08Ucb8aB+cg3zFVyMI3ofpx4L4g3v3yhruD1W AIoaJkPxunA1Rwxc0uhttop14xUf3g68KD9Pfg98Q9vNj6dgOFxm0k47YQ9fUNz2XUDq zvsRgKnGTyyPLLDZzMCv1rLQa6npTMMCn2BokeiOMksMc5oZrXwGQLSgn+7/xEp2OuP2 eJjfKeW0lonWdRwrord9TeNM2/tquoFgzESOD+ZF+NoP8xB1wL5Vu1M8FMdxBlWhCW7T FPKemAD3mxUjhlSVEU5TO8xA+oGkn8Pw+rGu8OClNJPAC+WdB6jRLjhyxMxVgx1qBzZC vQHA== X-Gm-Message-State: AKaTC02fNvsFrLx/FjAztb25HhvYOjI9dJQ/oOgx/XD5jNGEG6tAek6qi60AOITrIgDO/DAY X-Received: by 10.159.32.99 with SMTP id 90mr20558268uam.138.1480508649598; Wed, 30 Nov 2016 04:24:09 -0800 (PST) Subject: Re: [PATCH 1/2] Enable ILP32 mode on aarch64, update abilist files To: libc-alpha@sourceware.org References: <1480445388.14808.16.camel@caviumnetworks.com> From: Adhemerval Zanella Message-ID: <053d72f5-13a8-ebe1-80ce-305226ecec64@linaro.org> Date: Wed, 30 Nov 2016 12:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-11/txt/msg01097.txt.bz2 On 29/11/2016 22:12, Joseph Myers wrote: > Please go through all the previous review comments on previous iterations > of ILP32 support (back to 2014) and make sure they are addressed. Some > haven't been. > > New comment: please include an addition of ILP32 builds, both LE and BE, > to build-many-glibcs.py. > > Possibly new comment: basing on top of Adhemerval's sysvipc consolidation > would be > better than adding new versions of various sysvipc files (if you think you > still need new versions after that patch, you need to work with Adhemerval > on making it more general). My understanding is, although not explicit state in this thread, ILP32 port is still based on my sysvipc consolidation (at least is what Yury was working with on previous iterations). I think my consolidation should take or current way of handling sysvipc on Linux kernel (direct syscalls and the {msg,sem,shm}ctl compatibility cases) and for ILP32 you will need only to take care of expected kernel value for __IPC_64. > > Examples of old comments, not necessarily exhaustive: use 10.0.0 as > arch_minimum_kernel until the required changes are actually in Linus's > tree; descriptive comments before copyright notices on each new C file; > GLIBC_2.25 as minimum symbol version (or GLIBC_2.26 if it doesn't get in > within the next month). > > Also make sure comments at top of source files are accurate; if you copied > a sysdeps/gnu file, don't keep the "GNU version." description, make it > reflect how it's now AArch64-specific. >