From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
libc-alpha@sourceware.org
Cc: nd@arm.com
Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions
Date: Wed, 11 Jul 2018 15:49:00 -0000 [thread overview]
Message-ID: <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> (raw)
In-Reply-To: <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org>
On 10/07/18 20:26, Adhemerval Zanella wrote:
>
>
> On 06/07/2018 09:46, Florian Weimer wrote:
>> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote:
>>> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pthread_mutex_getprioceiling \
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pthread_mutex_setprioceiling \
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pthread_setname pthread_getname \
>>> -Â Â Â Â Â Â Â Â Â Â Â Â Â pthread_setattr_default_np pthread_getattr_default_np
>>> +Â Â Â Â Â Â Â Â Â Â Â Â Â pthread_setattr_default_np pthread_getattr_default_np \
>>> +Â Â Â Â Â Â Â Â Â Â Â Â Â thrd_create thrd_current thrd_detach thrd_equal \
>>
>> thrd_current should live in libc, not in libpthread. Same for thrd_equal, I suppose. You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet.
>>
>> Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well.
>
> Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and
> thrd_yield) to libc on my personal branch [1] (the change is just to move
> the objects from libpthread-routines to routines rule in nptl/Makefile).
> I also adjusted the abilist patch with the change.
>
the abilist patch seems to add
sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist
i think you can drop that (and update the ChangeLog).
>
> [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/c11-threads
>
next prev parent reply other threads:[~2018-07-11 15:49 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 17:04 [PATCH v8 0/8] Add support for ISO C threads.h Adhemerval Zanella
2018-02-02 17:05 ` [PATCH v8 2/8] nptl: Add C11 threads mtx_* functions Adhemerval Zanella
2018-07-06 12:51 ` Florian Weimer
2018-07-10 12:35 ` Adhemerval Zanella
2018-07-12 18:39 ` Florian Weimer
2018-07-12 20:30 ` Adhemerval Zanella
2018-07-12 20:39 ` Florian Weimer
2018-07-13 13:08 ` Adhemerval Zanella
2018-07-13 13:10 ` Florian Weimer
2018-07-24 12:04 ` Adhemerval Zanella
2018-07-24 16:05 ` Carlos O'Donell
2018-02-02 17:05 ` [PATCH v8 6/8] nptl: Add abilist symbols for C11 threads Adhemerval Zanella
2018-07-13 9:50 ` Florian Weimer
2018-07-13 15:49 ` Adhemerval Zanella
2018-07-13 17:49 ` Florian Weimer
2018-07-13 18:47 ` Adhemerval Zanella
2018-07-13 20:00 ` Florian Weimer
2018-07-13 21:09 ` Adhemerval Zanella
2018-07-14 13:50 ` Florian Weimer
2018-07-18 17:40 ` Joseph Myers
2018-07-18 20:02 ` Adhemerval Zanella
2018-07-18 21:50 ` Florian Weimer
2018-02-02 17:05 ` [PATCH v8 5/8] nptl: Add C11 threads tss_* functions Adhemerval Zanella
2018-07-12 16:48 ` Florian Weimer
2018-07-12 20:32 ` Adhemerval Zanella
2018-07-12 20:38 ` Florian Weimer
2018-02-02 17:05 ` [PATCH v8 8/8] Add manual documentation for threads.h Adhemerval Zanella
2018-02-02 17:05 ` [PATCH v8 3/8] nptl: Add C11 threads call_once functions Adhemerval Zanella
2018-07-13 9:32 ` Florian Weimer
2018-02-02 17:05 ` [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions Adhemerval Zanella
2018-02-08 17:58 ` Gabriel F. T. Gomes
2018-02-09 12:11 ` Adhemerval Zanella
2018-02-26 13:43 ` Gabriel F. T. Gomes
2018-07-06 12:46 ` Florian Weimer
2018-07-10 19:26 ` Adhemerval Zanella
2018-07-11 15:49 ` Szabolcs Nagy [this message]
2018-07-11 16:24 ` Adhemerval Zanella
2018-07-12 12:19 ` Florian Weimer
2018-07-12 17:38 ` Adhemerval Zanella
2018-07-13 7:03 ` Florian Weimer
2018-07-12 16:46 ` Florian Weimer
2018-07-12 17:52 ` Adhemerval Zanella
2018-07-12 18:25 ` Florian Weimer
2018-07-12 19:19 ` Adhemerval Zanella
2018-07-12 19:26 ` Florian Weimer
2018-07-12 19:41 ` Adhemerval Zanella
2018-07-12 19:32 ` Adhemerval Zanella
2018-07-12 19:35 ` Florian Weimer
2018-07-12 19:43 ` Adhemerval Zanella
2018-07-13 9:45 ` Florian Weimer
2018-07-13 12:59 ` Adhemerval Zanella
2018-07-13 13:04 ` Florian Weimer
2018-07-13 13:18 ` Adhemerval Zanella
2018-07-13 13:22 ` Florian Weimer
2018-07-13 9:48 ` Florian Weimer
2018-07-25 7:20 ` Andreas Schwab
2018-07-25 7:38 ` Florian Weimer
2018-07-25 10:29 ` Joseph Myers
2018-02-02 17:05 ` [PATCH v8 7/8] nptl: Add test cases for ISO C11 threads Adhemerval Zanella
2018-07-13 9:31 ` Florian Weimer
2018-07-13 13:10 ` Adhemerval Zanella
2018-07-13 13:11 ` Florian Weimer
2018-07-13 13:29 ` Adhemerval Zanella
2018-07-17 13:53 ` Adhemerval Zanella
2018-02-02 17:05 ` [PATCH v8 4/8] nptl: Add C11 threads cnd_* functions Adhemerval Zanella
2018-06-27 13:40 ` [PATCH v8 0/8] Add support for ISO C threads.h Adhemerval Zanella
2018-07-19 17:47 ` Adhemerval Zanella
2018-07-19 18:44 ` Carlos O'Donell
2018-07-19 19:12 ` Rical Jasan
2018-07-19 19:58 ` Adhemerval Zanella
2018-07-21 0:26 ` Rical Jasan
2018-07-21 2:12 ` Carlos O'Donell
2018-07-21 6:22 ` Rical Jasan
2018-07-21 13:40 ` Adhemerval Zanella
2018-07-19 21:26 ` Joseph Myers
2018-07-20 12:32 ` Adhemerval Zanella
2018-07-20 13:22 ` Rical Jasan
2018-07-20 13:54 ` Rical Jasan
2018-07-20 14:04 ` Carlos O'Donell
2018-07-20 15:02 ` [PATCH v8 0/8] Add support for ISO C threads.h [thrd_exit] Rical Jasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).