From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 95D4F3858D38 for ; Mon, 12 Feb 2024 18:11:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95D4F3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95D4F3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707761502; cv=none; b=O9uXsAnglKxk+lCWiAZrQymSoAKQOVQhsexRq6zgo19oAigPVnlB6WJRURNyUyDfjbi9Kfi1ginujd7ZiDZO+MqmIuZ+cZnmaKE4T9Bkii6Evb+QoT64d+CVFQPnf1BcCYv3iCsmHzEgIi5S5p8cY5XjO0CUz+WWtBv8fKVwgiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707761502; c=relaxed/simple; bh=j3YuaEq+dQ6HUZGj0fz7FSrixnCBpFVoa+E0ZAFeew4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fGgvWeU69V3jYEP6Q1ffUWo2bAeWP/8c1jjim4SqAc9I5wKfGzqxmq4/FzFS903P+8c6C1XYg49VhtQSP2PvyzR72c+LNwRWTbgJfvfQVuSC/A2U76AxzfxANveY6sTFJEIzaBFHYRzbTDoOHLn4/78/cIYj4O51hIOPtbj2nwc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d731314e67so469635ad.1 for ; Mon, 12 Feb 2024 10:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707761498; x=1708366298; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=m47uLEK6FKadJ7vUQEtpYxaDmrk4gDCuASdtRJxk9qw=; b=qUTSfVynU9dgN7e7Ci6rn6zG5ktZlKN8N7+wkbCsjU8J0baR9jXyWc68a/9tNlEnw4 DdIJMt3Gf2AZy+/O7uErEqYpJ0RZjp4goIlZPvZ6bNn4QxAK47tbRnTZWiMuMzXm6jIV mZdIStTmZRiAmUPlMMHTLJsCymEIKR+fbCmTbIqh7zciZDmyhj4w2u7RMolR85xlsluN qcV3fsjRidmomvs0lP7PuqMKiLC3LXQPxDVUB9cJbE7q0dUh6PzLP/SoBBByAQIPkCv1 W0ne+os47lv61PL1neNVNu6kwom75RmhdlHby2VC87ni3yenhxUPrjynFqMtsTskjOyq 5WZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707761498; x=1708366298; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m47uLEK6FKadJ7vUQEtpYxaDmrk4gDCuASdtRJxk9qw=; b=Fdqn4Uzt4lNo1qes1qrcIeXs+0KX1iPDdN/36jgKEWrxyNVO42RWxQkJSdkIVgUymD HkdqqNkbc6nXBQl/Vqr4HRn7gD7BvgpNyqm1Q7HgXhfyYJWWiZ+lEIS/adOWgsiZuyz8 wEuN/85ewFyaaN/glq/tWy9qjZqu+GkgW434sfd3m/Y8fpWRxNMQZxMQfgLBwnpJ56OP j22KvexqmHcIk3W0I4BKlpr+cK9jhOf8IJ0sdgIZwim9+ezRncfrT083LbHDKjCuCkhW cDlVrxibh8RJzTFClu0GvtqW1SFv2wjIYg75wFnX9s+glOYnThXadKCx4Ai4EIzg6beY wMRQ== X-Gm-Message-State: AOJu0YyK17bat1R6swDhIAMfgJgd4gp9Rbj9evg98uK0GhM+ZK8cmNkS GuPHIReYCkaBVcM2uH8zcpJsYcNRY9aiX/OJ5GnNU8P09/dPqBOqqp+QVPmohyI= X-Google-Smtp-Source: AGHT+IEo/fhOWyqlyMWOk8X1Sc1+861FDMfkbmdc3UCkvA2fUkWi/PTTIBxdtn0wi8F0pLyKE2REVA== X-Received: by 2002:a17:903:22cd:b0:1d8:deb5:33a5 with SMTP id y13-20020a17090322cd00b001d8deb533a5mr8275662plg.6.1707761498511; Mon, 12 Feb 2024 10:11:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW7INDOSsRq4CiTyu3a5805bXQXRFxg8cChtlr+aPXzqfBQothodexY2qZECJB2P2MObuitjuk/OoWNSGLo4VDVFbpM/VlixnjJ5e/afbD0ID8bkAZioi9h1Vn3uhbiUHk9weTm5Lo= Received: from ?IPV6:2804:1b3:a7c0:378:a95e:7d43:370e:1d4c? ([2804:1b3:a7c0:378:a95e:7d43:370e:1d4c]) by smtp.gmail.com with ESMTPSA id h6-20020a170902eec600b001d932f1b92bsm623732plb.289.2024.02.12.10.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 10:11:37 -0800 (PST) Message-ID: <0587c512-557e-4349-9875-14bb02c3754d@linaro.org> Date: Mon, 12 Feb 2024 15:11:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sysdeps/unix/sysv/linux/syscall.c is not referenced anywhere, let's remove it Content-Language: en-US To: Askar Safin , carlos@redhat.com Cc: libc-alpha@sourceware.org, dalias@libc.org, fweimer@redhat.com References: <20240212180728.19099-1-safinaskar@zohomail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240212180728.19099-1-safinaskar@zohomail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/02/24 14:59, Askar Safin wrote: > sysdeps/unix/sysv/linux/syscall.c is not referenced anywhere. In particular, it is not > referenced in sysdeps/unix/sysv/linux/Makefile . So, this syscall.c is dead code, let's > remove it. > > Compile-tested on Linux x86_64 > > Signed-off-by: Askar Safin It is used by hppa, loongarch, mips o32, ork1, and riscv. PS: I think Rich is not really interested in this kind of discussion, so you can drop him from CC. > --- > > This is another small issue I found when I was writing that "syscall_no_errno" patch > > sysdeps/unix/sysv/linux/syscall.c | 43 ------------------------------- > 1 file changed, 43 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/syscall.c > > diff --git a/sysdeps/unix/sysv/linux/syscall.c b/sysdeps/unix/sysv/linux/syscall.c > deleted file mode 100644 > index 3cff1d970a..0000000000 > --- a/sysdeps/unix/sysv/linux/syscall.c > +++ /dev/null > @@ -1,43 +0,0 @@ > -/* Indirect system call. Linux generic implementation. > - Copyright (C) 1997-2024 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library. If not, see > - . */ > - > -#include > -#include > - > -long int > -syscall (long int number, ...) > -{ > - va_list args; > - > - va_start (args, number); > - long int a0 = va_arg (args, long int); > - long int a1 = va_arg (args, long int); > - long int a2 = va_arg (args, long int); > - long int a3 = va_arg (args, long int); > - long int a4 = va_arg (args, long int); > - long int a5 = va_arg (args, long int); > - va_end (args); > - > - long int r = INTERNAL_SYSCALL_NCS_CALL (number, a0, a1, a2, a3, a4, a5); > - if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (r))) > - { > - __set_errno (-r); > - return -1; > - } > - return r; > -}