From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 5/7] misc: syslog: Use static buffer
Date: Fri, 18 Feb 2022 19:45:52 -0800 [thread overview]
Message-ID: <0600985c-8cf8-5c92-7ea1-8b6abe905084@cs.ucla.edu> (raw)
In-Reply-To: <20220218142322.432304-6-adhemerval.zanella@linaro.org>
On 2/18/22 06:23, Adhemerval Zanella via Libc-alpha wrote:
> + /* Try to use a static buffer as an optimization. */
> + char bufs[bufs_size];
This is not a static buffer; it's a buffer whose size is static. Perhaps
change "static buffer" to "fixed-sized buffer" in the comment and commit
message.
> + int l = __snprintf (bufs, sizeof bufs,
> + SYSLOG_HEADER (pri, timestamp, &msgoff, pid));
> + if (l < sizeof (bufs))
"sizeof (bufs)" -> "sizeof bufs" for consistency and simplicity, both
here and elsewhere in the file.
next prev parent reply other threads:[~2022-02-19 3:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 14:23 [PATCH v2 0/7] Use RFC5424 for syslog Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 1/7] support: Add xmkfifo Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 2/7] misc: Add syslog test Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 3/7] misc: syslog: Fix indentation and style Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 4/7] misc: syslog: Simplify implementation Adhemerval Zanella
2022-02-19 3:15 ` Paul Eggert
2022-02-21 13:15 ` Adhemerval Zanella
2022-02-21 22:25 ` Paul Eggert
2022-02-21 14:06 ` Andreas Schwab
2022-02-21 22:23 ` Paul Eggert
2022-02-18 14:23 ` [PATCH v2 5/7] misc: syslog: Use static buffer Adhemerval Zanella
2022-02-19 3:45 ` Paul Eggert [this message]
2022-02-21 13:31 ` Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Adhemerval Zanella
2022-02-18 14:23 ` [PATCH v2 7/7] misc: syslog: Use RFC5424 Adhemerval Zanella
2022-02-19 3:50 ` Paul Eggert
2022-02-21 14:01 ` Adhemerval Zanella
2022-02-21 16:18 ` Adhemerval Zanella
2022-02-21 22:25 ` Paul Eggert
2022-02-19 20:35 ` Dan Raymond
2022-02-19 22:23 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0600985c-8cf8-5c92-7ea1-8b6abe905084@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).