From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129591 invoked by alias); 2 Nov 2016 13:22:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129552 invoked by uid 89); 2 Nov 2016 13:22:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=r0UJDyKcE2VkuwgLDuVvcVlJczYjgpaKEpusYPhsChc=; b=T1Erx0cHgBImrAJz3MtnY2LVgf8GkgQuuKXAKVGzv2sOUPCaeE8HEJanLa6IJh6WXN N4tsybb8MZw5zlYqo64A4BLAk929gW7C09Uf5eI0RWz+YWhGkUYj8Zcq2vjvwPVYsiEK Y+7nL2M6mvRzkxmiwkDKgnUzZDT0qGttJmSYGAgVzHSHCFkPrjeq9PFhqqhw2VO9m95M /E0LzPK0C0bpDWrOKfZFCiHrqbAHC6ljPriQep4wI3sGgpsV3egUglPEJzoXmNh36FTF tMGULbI4twobMrnOVKvjgfAnTgmFBk28zDF7i/JftsVGO9tv2jpDXZGhVVmZkC4+eTWF IS9g== X-Gm-Message-State: ABUngvciepC66LyDSFs25RZF4O4V3NF8iNrtkEtUcZ3VuLeKDokWNhI+W57Y4oPQD4J/e0Er X-Received: by 10.200.43.229 with SMTP id n34mr3123611qtn.154.1478092948889; Wed, 02 Nov 2016 06:22:28 -0700 (PDT) Subject: Re: [PATCH v4] Fix -Os related build and test failures. To: Joseph Myers , Andreas Schwab References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com> <87mvhjwod1.fsf@linux-m68k.org> Cc: Florian Weimer , GNU C Library From: Carlos O'Donell Message-ID: <069781c2-ea39-7c08-9b2e-f767693c43c7@redhat.com> Date: Wed, 02 Nov 2016 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00058.txt.bz2 On 11/01/2016 07:12 AM, Joseph Myers wrote: > On Tue, 1 Nov 2016, Andreas Schwab wrote: > >> On Okt 30 2016, Carlos O'Donell wrote: >> >>> diff --git a/resolv/res_send.c b/resolv/res_send.c >>> index 6d46bb2..4ec8c1a 100644 >>> --- a/resolv/res_send.c >>> +++ b/resolv/res_send.c >>> @@ -664,7 +664,7 @@ send_vc(res_state statp, >>> a false-positive. >>> */ >>> DIAG_PUSH_NEEDS_COMMENT; >>> - DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); >>> + DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); >>> int resplen; >>> DIAG_POP_NEEDS_COMMENT; >>> struct iovec iov[4]; >> >> That breaks powerpc and s390. >> >> res_send.c: In function 'send_vc': >> res_send.c:668:6: error: 'resplen' may be used uninitialized in this function [-Werror=maybe-uninitialized] >> int resplen; >> ^~~~~~~ > > And the other change to the same file introduces a new use of > DIAG_IGNORE_NEEDS_COMMENT with a comment that only mentions -Os. Was the > intent to edit the latter use to be DIAG_IGNORE_Os_NEEDS_COMMENT, with the > former one edited by mistake instead? It was indeed a mistake. I used a script to find and fix the uses I'd added, but here I made a mistake. I'm running a rawhide build check here to verify the fix fixes things for x86, x86_64, aarch64, arm, ppc64, ppc64le, and s390. Cheers, Carlos.