From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by sourceware.org (Postfix) with ESMTPS id 48A7C3858C2C for ; Thu, 30 Sep 2021 14:49:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48A7C3858C2C Received: by mail-ua1-x92c.google.com with SMTP id 20so4404492uaj.6 for ; Thu, 30 Sep 2021 07:49:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=35utz7EBvsNQn5KHnfpJjAW8610GpjfIuFR42OkkB58=; b=fbuhASWKpnOf1R1KwwrID3GotFD1dBKDBPmNDKbAeCp2dwrVmi9l1DZ9VitWW8wVwh XmhJFGCajOT2JNdwpaZOtXs+stGl6kHmr9NboZUvRBfECm+8d1yAFnmkZ9g64Cm/ULTO x77jQKr1YbcoHR5VhfQPTsME0WqeJRa+3drAIT3roCneDsrSpb4Wa70SlYAluKqZVY68 iXjbpSvIkB5cH6Yw/weAJ+JbV/AcK7ORZBHIZdOx/DON4u0HmHghnkyyTWBuIKKq0FGD +CxZZLmex2LcRHJvX78bix71/+CpoA1E+48xpTBIlsCUuqGX26qyl1lfBdoMAI49u+6o jBng== X-Gm-Message-State: AOAM532Cl8pHXIgQ2jcIyHKywLGwEjgb4YCLgF84m0O+uhJxb27pUX3a VTjNSoVIOmQUeXBFNCxawGdqog== X-Google-Smtp-Source: ABdhPJxn1j8t/IMeqNivIO+nExaSO/XcCJmzuHLVBvcvcg/Qytu1Rz5i+gfjd//oPuo89Ymq6PSKsw== X-Received: by 2002:a9f:384f:: with SMTP id q15mr5729205uad.136.1633013375348; Thu, 30 Sep 2021 07:49:35 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:b338:b20e:53f8:8b5:1bb2? ([2804:431:c7cb:b338:b20e:53f8:8b5:1bb2]) by smtp.gmail.com with ESMTPSA id b7sm1548855vsu.7.2021.09.30.07.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Sep 2021 07:49:35 -0700 (PDT) Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch To: libc-alpha@sourceware.org, Jonathan Wakely , Joseph Myers References: <87czoq4a44.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org> Date: Thu, 30 Sep 2021 11:49:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87czoq4a44.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 14:49:38 -0000 On 30/09/2021 07:43, Florian Weimer via Libc-alpha wrote: > * Jonathan Wakely via Libc-alpha: > >> diff --git a/bits/stdlib-bsearch.h b/bits/stdlib-bsearch.h >> index 4132dc6af0..d688ed2e15 100644 >> --- a/bits/stdlib-bsearch.h >> +++ b/bits/stdlib-bsearch.h >> @@ -29,14 +29,21 @@ bsearch (const void *__key, const void *__base, size_t __nmemb, size_t __size, >> while (__l < __u) >> { >> __idx = (__l + __u) / 2; >> - __p = (void *) (((const char *) __base) + (__idx * __size)); >> + __p = (const void *) (((const char *) __base) + (__idx * __size)); >> __comparison = (*__compar) (__key, __p); >> if (__comparison < 0) >> __u = __idx; >> else if (__comparison > 0) >> __l = __idx + 1; >> else >> +#if __GNUC_PREREQ(4, 6) >> +# pragma GCC diagnostic push >> +# pragma GCC diagnostic ignored "-Wcast-qual" >> +#endif >> return (void *) __p; >> +#if __GNUC_PREREQ(4, 6) >> +# pragma GCC diagnostic pop >> +#endif >> } >> >> return NULL; > > Patch looks okay, thanks. > > Reviewed-by: Florian Weimer > > Florian > I am seeing a lot of failure on x86_64 with gcc 11.1 after this patch landed: x86_64-linux-gnu$ grep ^FAIL tests.sum FAIL: catgets/de/libc.cat FAIL: catgets/test-gencat FAIL: catgets/test1.cat FAIL: catgets/tst-catgets FAIL: debug/tst-chk1 FAIL: debug/tst-chk2 FAIL: debug/tst-chk3 FAIL: debug/tst-chk4 FAIL: debug/tst-chk5 FAIL: debug/tst-chk6 FAIL: debug/tst-lfschk1 FAIL: debug/tst-lfschk2 FAIL: debug/tst-lfschk3 FAIL: debug/tst-lfschk4 FAIL: debug/tst-lfschk5 FAIL: debug/tst-lfschk6 [...] For instance some math tests shows ulps failures that does not make much sense: $ ./testrun.sh math/test-double-cacos testing double (without inline functions) Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.0000000000001p+0 i) Result: is: 8.8137358701954271e-01 0x1.c34366179d424p-1 should be: 8.8137358701954315e-01 0x1.c34366179d428p-1 difference: 4.4408920985006261e-16 0x1.0000000000000p-51 ulp : 4.0000 max.ulp : 3.0000 Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.000002p+0 i) Result: is: 8.8137367131323707e-01 0x1.c34368ebb10d9p-1 should be: 8.8137367131323751e-01 0x1.c34368ebb10ddp-1 difference: 4.4408920985006261e-16 0x1.0000000000000p-51 ulp : 4.0000 max.ulp : 3.0000 [...] Reverting fixes it.