From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id C42603858D37 for ; Tue, 5 Apr 2022 20:01:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C42603858D37 Received: by mail-ot1-x32f.google.com with SMTP id b17-20020a0568301df100b005ce0456a9efso274455otj.9 for ; Tue, 05 Apr 2022 13:01:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/ndpi/BN4Dm/Y7fXZXBJrmG1lNmQE8sQAOiw+zBV9ow=; b=WGb8ax/xutNVEgSQk801N9d4dzOL5yk32UlvXhpe5mS1rt5i0NveowfjaocYEv/lyT CfrrbTjFNZ6C7mPmLUBAXtutNESnMVcBBKQdZLl5qsZiooDKQb6Bn1RxZJDIz2T5KgK3 lrk7m2yCevn8KWpwFNtJv7RQmKeoAwXO6i4CE6Aq50o4mArrJaKAnqgZZmfvCmZggnK/ ghzouOwvuE0J+MBnAiL4ciixGJdseM7y2IfYPZWvRd2LtgolVDyaTJ9nQlGzmkoHJ77j ofeTCK2XV/ENQ+i7Q7doho/5m7aEBB58maaTEwWAqpswIt2pPkbL07jvB3e65i4xM76x qeug== X-Gm-Message-State: AOAM5319CYl4wpTep97IdTymYBAastlrsgj5d8bg2uPDaCfQt45XHF2T beXcPr//lgbUrX1SIh/QDWELNw== X-Google-Smtp-Source: ABdhPJyqP1y8b1oOBbmXEAsYvYbOfwsFgpWerxq9oVqkiVaxBtdtnIzyRHr786PfQoqnd3kGj/mhsg== X-Received: by 2002:a9d:7998:0:b0:5b2:2a01:e667 with SMTP id h24-20020a9d7998000000b005b22a01e667mr1873851otm.311.1649188911030; Tue, 05 Apr 2022 13:01:51 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2? ([2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2]) by smtp.gmail.com with ESMTPSA id o133-20020acaf08b000000b002ef7562e07csm5665755oih.41.2022.04.05.13.01.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 13:01:50 -0700 (PDT) Message-ID: <06ae38bd-cccb-9f00-b23a-5a1232a26763@linaro.org> Date: Tue, 5 Apr 2022 17:01:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] Remove fno-unit-at-a-time make variable Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20220330050729.2176630-1-maskray@google.com> <0295bfe2-2f44-c15e-1628-acaf94fc407c@linaro.org> <20220330162311.pwg52gcrr5vnlabe@google.com> <7e7fdfdc-ddc8-cf5a-0525-f927b4ae1e39@linaro.org> <20220331034302.rzcu6gllo7ltkhjh@google.com> <20220404155703.vefk66cwnsnkhsih@google.com> <22f8e3aa-5af9-93a2-65fc-1889674103d6@linaro.org> <4570fa06-24b0-873a-09b6-d57c85dd1191@linaro.org> <914158c4-f52d-21ee-73e5-6ffe30faa0d4@linaro.org> <87k0c3wh6a.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87k0c3wh6a.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 20:01:53 -0000 On 05/04/2022 14:53, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> This is not what I am seeing on my clang branch, where clang with integrated >> moves the global asm directives to the top of the file. And it makes >> check-abi fail due the _sys_errlist/sys_errlist being with wrong value. > > You can move the directives to the bottom of the file by creating a > temporary .s file and #include that from a wrapper .S file that > #includes the .s file. Not sure I am following your suggestion here, do you mean get the -S output file from compiler? > > Or perhaps generate the assembler file directly, as in > elf/dl-debug-symbols.S, which solves the same problem. Linux > should be includable directly from assembler, hopefully that's true for > the Hurd version as well. Making an assembly file is really tricky here because _sys_errlist_internal contains internal gap (the errno values are not strictly sequential). The compiler handles by adding '.zero' commands, which is not easily. I think we might generate it though a script.