From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>, libc-alpha@sourceware.org
Cc: fweimer@redhat.com, joseph@codesourcery.com
Subject: Re: [PATCH v3 2/2] x86 long double: Add tests for pseudo normal numbers
Date: Mon, 28 Dec 2020 14:04:37 -0300 [thread overview]
Message-ID: <06c21d75-72af-e712-a917-1cbeeb80bdb5@linaro.org> (raw)
In-Reply-To: <20201224024554.3579622-3-siddhesh@sourceware.org>
On 23/12/2020 23:45, Siddhesh Poyarekar wrote:
> Add some tests for fpclassify, isnan, isinf and issignaling.
>
> Co-authored-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
LGTM, thanks.
> ---
> math/libm-test-driver.c | 38 ++++++++++++++++++++++++++++++++++
> math/libm-test-fpclassify.inc | 14 +++++++++++++
> math/libm-test-isinf.inc | 14 +++++++++++++
> math/libm-test-isnan.inc | 14 +++++++++++++
> math/libm-test-issignaling.inc | 14 +++++++++++++
> 5 files changed, 94 insertions(+)
>
> diff --git a/math/libm-test-driver.c b/math/libm-test-driver.c
> index 11b541b2e7..7f1af071da 100644
> --- a/math/libm-test-driver.c
> +++ b/math/libm-test-driver.c
> @@ -19,6 +19,7 @@
> #include "libm-test-support.h"
>
> #include <math-tests-arch.h>
> +#include <nan-pseudo-number.h>
>
> /* Flags set by the including file. */
> const int flag_test_errno = TEST_ERRNO;
> @@ -122,6 +123,16 @@ const char qtype_str[] = TYPE_STR;
> /* For nexttoward tests. */
> #define snan_value_ld __builtin_nansl ("")
>
> +/* For pseudo-normal number tests. */
> +#if HANDLE_PSEUDO_NUMBERS
> +# include <math_ldbl.h>
> +#define pseudo_inf { .parts = { 0x00000000, 0x00000000, 0x7fff }}
> +#define pseudo_zero { .parts = { 0x00000000, 0x00000000, 0x0100 }}
> +#define pseudo_qnan { .parts = { 0x00000001, 0x00000000, 0x7fff }}
> +#define pseudo_snan { .parts = { 0x00000001, 0x40000000, 0x7fff }}
> +#define pseudo_unnormal { .parts = { 0x00000001, 0x40000000, 0x0100 }}
> +#endif
> +
> /* Structures for each kind of test. */
> /* Used for both RUN_TEST_LOOP_f_f and RUN_TEST_LOOP_fp_f. */
> struct test_f_f_data
> @@ -316,6 +327,19 @@ struct test_f_i_data
> int exceptions;
> } rd, rn, rz, ru;
> };
> +/* Used for RUN_TEST_LOOP_f_i_tg_u and RUN_TEST_LOOP_f_b_tg_u. */
> +#if HANDLE_PSEUDO_NUMBERS
> +struct test_f_i_data_u
> +{
> + const char *arg_str;
> + ieee_long_double_shape_type arg;
> + struct
> + {
> + int expected;
> + int exceptions;
> + } rd, rn, rz, ru;
> +};
> +#endif
> /* Used for RUN_TEST_LOOP_ff_b, RUN_TEST_LOOP_fpfp_b and
> RUN_TEST_LOOP_ff_i_tg. */
> struct test_ff_i_data
> @@ -832,6 +856,20 @@ struct test_Ff_b1_data
> (ARRAY)[i].RM_##ROUNDING_MODE.expected, \
> (ARRAY)[i].RM_##ROUNDING_MODE.exceptions); \
> ROUND_RESTORE_ ## ROUNDING_MODE
> +#define RUN_TEST_LOOP_f_b_tg_u(FUNC_NAME, ARRAY, ROUNDING_MODE) \
> + IF_ROUND_INIT_ ## ROUNDING_MODE \
> + for (size_t i = 0; i < sizeof (ARRAY) / sizeof (ARRAY)[0]; i++) \
> + RUN_TEST_f_b_tg ((ARRAY)[i].arg_str, FUNC_NAME, (ARRAY)[i].arg.value, \
> + (ARRAY)[i].RM_##ROUNDING_MODE.expected, \
> + (ARRAY)[i].RM_##ROUNDING_MODE.exceptions); \
> + ROUND_RESTORE_ ## ROUNDING_MODE
> +#define RUN_TEST_LOOP_f_i_tg_u(FUNC_NAME, ARRAY, ROUNDING_MODE) \
> + IF_ROUND_INIT_ ## ROUNDING_MODE \
> + for (size_t i = 0; i < sizeof (ARRAY) / sizeof (ARRAY)[0]; i++) \
> + RUN_TEST_f_i_tg ((ARRAY)[i].arg_str, FUNC_NAME, (ARRAY)[i].arg.value, \
> + (ARRAY)[i].RM_##ROUNDING_MODE.expected, \
> + (ARRAY)[i].RM_##ROUNDING_MODE.exceptions); \
> + ROUND_RESTORE_ ## ROUNDING_MODE
> #define RUN_TEST_ff_b(ARG_STR, FUNC_NAME, ARG1, ARG2, EXPECTED, \
> EXCEPTIONS) \
> do \
> diff --git a/math/libm-test-fpclassify.inc b/math/libm-test-fpclassify.inc
> index 96b557ecb4..480ccfe9cb 100644
> --- a/math/libm-test-fpclassify.inc
> +++ b/math/libm-test-fpclassify.inc
> @@ -37,10 +37,24 @@ static const struct test_f_i_data fpclassify_test_data[] =
> TEST_f_i (fpclassify, -min_subnorm_value, FP_SUBNORMAL, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> };
>
> +#if HANDLE_PSEUDO_NUMBERS
> +static const struct test_f_i_data_u fpclassify_test_data_u[] =
> + {
> + TEST_f_i (fpclassify, pseudo_zero, FP_NAN, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_i (fpclassify, pseudo_inf, FP_NAN, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_i (fpclassify, pseudo_qnan, FP_NAN, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_i (fpclassify, pseudo_snan, FP_NAN, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_i (fpclassify, pseudo_unnormal, FP_NAN, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + };
> +#endif
> +
> static void
> fpclassify_test (void)
> {
> ALL_RM_TEST (fpclassify, 1, fpclassify_test_data, RUN_TEST_LOOP_f_i_tg, END);
> +#if HANDLE_PSEUDO_NUMBERS
> + ALL_RM_TEST (fpclassify, 1, fpclassify_test_data_u, RUN_TEST_LOOP_f_i_tg_u, END);
> +#endif
> }
>
> static void
> diff --git a/math/libm-test-isinf.inc b/math/libm-test-isinf.inc
> index 6ecbf7ba6e..44cebd2198 100644
> --- a/math/libm-test-isinf.inc
> +++ b/math/libm-test-isinf.inc
> @@ -37,10 +37,24 @@ static const struct test_f_i_data isinf_test_data[] =
> TEST_f_b (isinf, -snan_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> };
>
> +#if HANDLE_PSEUDO_NUMBERS
> +static const struct test_f_i_data_u isinf_test_data_u[] =
> + {
> + TEST_f_b (isinf, pseudo_zero, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isinf, pseudo_inf, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isinf, pseudo_qnan, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isinf, pseudo_snan, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isinf, pseudo_unnormal, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + };
> +#endif
> +
> static void
> isinf_test (void)
> {
> ALL_RM_TEST (isinf, 1, isinf_test_data, RUN_TEST_LOOP_f_b_tg, END);
> +#if HANDLE_PSEUDO_NUMBERS
> + ALL_RM_TEST (isinf, 1, isinf_test_data_u, RUN_TEST_LOOP_f_b_tg_u, END);
> +#endif
> }
>
> static void
> diff --git a/math/libm-test-isnan.inc b/math/libm-test-isnan.inc
> index e6e2bb6a47..d8545c4dc5 100644
> --- a/math/libm-test-isnan.inc
> +++ b/math/libm-test-isnan.inc
> @@ -37,10 +37,24 @@ static const struct test_f_i_data isnan_test_data[] =
> TEST_f_b (isnan, -snan_value, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> };
>
> +#if HANDLE_PSEUDO_NUMBERS
> +static const struct test_f_i_data_u isnan_test_data_u[] =
> + {
> + TEST_f_b (isnan, pseudo_zero, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isnan, pseudo_inf, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isnan, pseudo_qnan, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isnan, pseudo_snan, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (isnan, pseudo_unnormal, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + };
> +#endif
> +
> static void
> isnan_test (void)
> {
> ALL_RM_TEST (isnan, 1, isnan_test_data, RUN_TEST_LOOP_f_b_tg, END);
> +#if HANDLE_PSEUDO_NUMBERS
> + ALL_RM_TEST (isnan, 1, isnan_test_data_u, RUN_TEST_LOOP_f_b_tg_u, END);
> +#endif
> }
>
> static void
> diff --git a/math/libm-test-issignaling.inc b/math/libm-test-issignaling.inc
> index a2bdcef265..80060dcb75 100644
> --- a/math/libm-test-issignaling.inc
> +++ b/math/libm-test-issignaling.inc
> @@ -39,10 +39,24 @@ static const struct test_f_i_data issignaling_test_data[] =
> TEST_f_b (issignaling, -snan_value_MACRO, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> };
>
> +#if HANDLE_PSEUDO_NUMBERS
> +static const struct test_f_i_data_u issignaling_test_data_u[] =
> + {
> + TEST_f_b (issignaling, pseudo_zero, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (issignaling, pseudo_inf, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (issignaling, pseudo_qnan, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (issignaling, pseudo_snan, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + TEST_f_b (issignaling, pseudo_unnormal, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
> + };
> +#endif
> +
> static void
> issignaling_test (void)
> {
> ALL_RM_TEST (issignaling, 1, issignaling_test_data, RUN_TEST_LOOP_f_b_tg, END);
> +#if HANDLE_PSEUDO_NUMBERS
> + ALL_RM_TEST (issignaling, 1, issignaling_test_data_u, RUN_TEST_LOOP_f_b_tg_u, END);
> +#endif
> }
>
> static void
>
next prev parent reply other threads:[~2020-12-28 17:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 2:45 [PATCH v3 0/2] x86 pseudo-normal numbers Siddhesh Poyarekar
2020-12-24 2:45 ` [PATCH v3 1/2] x86 long double: Consider pseudo numbers as signaling Siddhesh Poyarekar
2020-12-28 16:57 ` Adhemerval Zanella
2020-12-30 5:31 ` [COMMITTED] " Siddhesh Poyarekar
2020-12-31 22:58 ` [PATCH v3 1/2] " Joseph Myers
2020-12-31 23:23 ` Andreas Schwab
2021-01-04 9:30 ` [COMMITTED] Move generic nan-pseudo-number.h to ldbl-96 Siddhesh Poyarekar
2020-12-24 2:45 ` [PATCH v3 2/2] x86 long double: Add tests for pseudo normal numbers Siddhesh Poyarekar
2020-12-28 17:04 ` Adhemerval Zanella [this message]
2020-12-31 23:09 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06c21d75-72af-e712-a917-1cbeeb80bdb5@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).