From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Paul Zimmermann <Paul.Zimmermann@inria.fr>
Subject: Re: [PATCH v4 02/12] math: Use an improved algorithm for hypot (dbl-64)
Date: Fri, 3 Dec 2021 16:44:16 -0300 [thread overview]
Message-ID: <06d56547-46ef-2397-4669-4724acc4a5f4@linaro.org> (raw)
In-Reply-To: <VE1PR08MB55995B13E960393A2E36C47D836A9@VE1PR08MB5599.eurprd08.prod.outlook.com>
On 03/12/2021 10:41, Wilco Dijkstra wrote:
> Hi Adhemeval,
>
> + /* If ax is huge, scale both inputs down. */
> + if (__glibc_unlikely (ax > LARGE_VAL))
> {
> + if (__glibc_unlikely (ay <= ax * EPS))
> + return ax + ay;
> +
> + return kernel (ax * SCALE, ay * SCALE) / SCALE;
> }
>
> Both of these returns can overflow and thus should have a math_narrow_eval
> (only the case where we can't overflow or underflow doesn't). OK with that change.
Ack.
next prev parent reply other threads:[~2021-12-03 19:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 0:00 [PATCH v4 00/12] Improve hypot Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 01/12] math: Simplify hypotf implementation Adhemerval Zanella
2021-12-03 13:23 ` Wilco Dijkstra
2021-12-03 19:44 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 02/12] math: Use an improved algorithm for hypot (dbl-64) Adhemerval Zanella
2021-12-03 13:41 ` Wilco Dijkstra
2021-12-03 19:44 ` Adhemerval Zanella [this message]
2021-12-03 0:00 ` [PATCH v4 03/12] math: Improve hypot performance with FMA Adhemerval Zanella
2021-12-03 13:44 ` Wilco Dijkstra
2021-12-03 0:00 ` [PATCH v4 04/12] math: Use an improved algorithm for hypotl (ldbl-96) Adhemerval Zanella
2021-12-06 12:00 ` Wilco Dijkstra
2021-12-06 12:21 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 05/12] math: Use an improved algorithm for hypotl (ldbl-128) Adhemerval Zanella
2021-12-06 11:58 ` Wilco Dijkstra
2021-12-06 12:22 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 06/12] math: Remove powerpc e_hypot Adhemerval Zanella
2021-12-06 17:12 ` Adhemerval Zanella
2021-12-06 21:29 ` Paul A. Clarke
2021-12-07 13:19 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 07/12] i386: Move hypot implementation to C Adhemerval Zanella
2021-12-03 14:51 ` Wilco Dijkstra
2021-12-06 12:26 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 08/12] math: Add math-use-builtinds-fmax.h Adhemerval Zanella
2021-12-06 11:52 ` Wilco Dijkstra
2021-12-06 21:11 ` Joseph Myers
2021-12-07 13:21 ` Adhemerval Zanella
2021-12-03 0:01 ` [PATCH v4 09/12] math: Add math-use-builtinds-fmin.h Adhemerval Zanella
2021-12-06 11:50 ` Wilco Dijkstra
2021-12-03 0:01 ` [PATCH v4 10/12] aarch64: Add math-use-builtins-f{max,min}.h Adhemerval Zanella
2021-12-06 11:46 ` Wilco Dijkstra
2021-12-06 12:35 ` Adhemerval Zanella
2021-12-03 0:01 ` [PATCH v4 11/12] math: Use fmin/fmax on hypot Adhemerval Zanella
2021-12-06 11:44 ` Wilco Dijkstra
2021-12-03 0:01 ` [PATCH v4 12/12] math: Remove the error handling wrapper from hypot and hypotf Adhemerval Zanella
2021-12-03 8:51 ` [PATCH v4 00/12] Improve hypot Paul Zimmermann
2021-12-06 12:36 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06d56547-46ef-2397-4669-4724acc4a5f4@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).