From: Paul E Murphy <murphyp@linux.ibm.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCHv2] powerpc: Add support for POWER10
Date: Fri, 26 Jun 2020 15:48:11 -0500 [thread overview]
Message-ID: <07563377-b007-60eb-f2b7-42cadf9d25cb@linux.ibm.com> (raw)
In-Reply-To: <20200625230116.301613-1-tuliom@linux.ibm.com>
On 6/25/20 6:01 PM, Tulio Magno Quites Machado Filho wrote:
> Changes since v1:
> - Remove 2 directories from Implies. Added another directory that was
> missing.
> - Listed power10 in preconfigure.ac
>
> ---8<---
>
> 1. Add the directories to hold POWER10 files.
>
> 2. Print the correct values for AT_PLATFORM and AT_BASE_PLATFORM.
>
> 3. Let submachine=power10 be set automatically.
This patch LGTM.
> diff --git a/sysdeps/powerpc/powerpc64/le/power10/Implies b/sysdeps/powerpc/powerpc64/le/power10/Implies
> new file mode 100644
> index 0000000000..9e1b787348
> --- /dev/null
> +++ b/sysdeps/powerpc/powerpc64/le/power10/Implies
> @@ -0,0 +1,2 @@
> +powerpc/powerpc64/le/power9/fpu
OK, this is the newly added path mentioned above.
> diff --git a/sysdeps/powerpc/preconfigure b/sysdeps/powerpc/preconfigure
> diff --git a/sysdeps/powerpc/preconfigure.ac b/sysdeps/powerpc/preconfigure.ac
OK
next prev parent reply other threads:[~2020-06-26 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 0:10 [PATCH] " Tulio Magno Quites Machado Filho
2020-06-25 18:43 ` Paul E Murphy
2020-06-25 22:36 ` Tulio Magno Quites Machado Filho
2020-06-25 23:01 ` [PATCHv2] " Tulio Magno Quites Machado Filho
2020-06-26 19:09 ` Matheus Castanho
2020-06-26 20:48 ` Paul E Murphy [this message]
2020-06-29 13:20 ` Tulio Magno Quites Machado Filho
2020-06-25 18:47 ` [PATCH] " Matheus Castanho
2020-06-25 19:18 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07563377-b007-60eb-f2b7-42cadf9d25cb@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).