From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by sourceware.org (Postfix) with ESMTPS id CF5253858C20 for ; Tue, 7 Nov 2023 13:30:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF5253858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF5253858C20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699363838; cv=none; b=SFUKDRglIFEUY5STWGdSkMSsUO/XS8k2TQNh0EJJdDakYOriwLl53XVaToWrqWj6Sdctn4EHObvsvM5lROXQokbd9GT2IGVwatpznnYvugOV7/zI3RHh7KZDgi8kU7CygqMYHVnZRU6jSKr9XypGHZ+BYEvoc5Xus5plaUZraMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699363838; c=relaxed/simple; bh=0osnz2QJULwvktxARNjaKHls+cjgWPeDYf6vBpImWvU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LY/1h99pViBz+AlneaB/ufV6CS2KsPe/PHCEAMVFzNVmGQLsjGP5+q21DAwANtYvlpsL1Cr2HKfS0/aPzws22Sk0LDAY+nrhkqqUg4Kl8cvdN8Aqkj6B+Aywv2HHAH2LhCREivzzaxLWVSMtn6H6iHMBMddHGzHIBtdu/gVlLf0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5a822f96aedso68267707b3.2 for ; Tue, 07 Nov 2023 05:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699363836; x=1699968636; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=6mjz2vUaMCtDFRRsNYZDs1Z3Q//PWSjepfo48spa+o0=; b=XWtsPnAc4PIHnS1w+rAqUaRSQJRB68+tndGi+F0GF3nHVSBqsMCwQjYlH89bSiKMgV +aNjiNRHzEk8cjPnRdmsj0R5q8eGNytuVomVsMV5DX4DYX+StWNnLAJM+se/24lY9Gv6 mu71N9NY59tY1yfZOo+x+EVSqrGfe8DwFeTi8z2CPz0HuEG7abp/PPfsH+QoHz+mu9Ln lNARmhzD/c47sors3R4tZbFPlw2L6k//wNsaqkHYqEh9tDE20ykYK9PfrJB3YMdumsdR SaKofbSK8eWHBkgfbYOex5592IWjFAAQsoIiYiQ3qs5MBhbhZPXAnO+QOLqkTEPVBABs woXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699363836; x=1699968636; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6mjz2vUaMCtDFRRsNYZDs1Z3Q//PWSjepfo48spa+o0=; b=aVy4fhz6H78rrTaKraYscrEuOS0jbVdUunfIV6o50tfw/b5BBSSgwBfloD535ZbDqM ZXC3zaYJSCQmZzc9drtVdnh2ko+1BahiXx++9kSHDR3seYlQ7MLNts93iVdgc3l7GpJA wjspSixAjMwpldEg/isUjno19DKPm8XDKNjELSqDs0Y9FfX+alD/exTe52NdnIQN6kF4 q0TMOvvW3+7nykN8bHB0faFiKX559VqdCdVNBNoLc11M1ZjPu5R2KJBga+1wAh9De7RW 5IDJsL2KakpAJqOlpYG9iWzHCidzsj9q4ATS1gFgJpQcyeUuFd/v8/aPdzNqnbizTeuY OioQ== X-Gm-Message-State: AOJu0Yw9/sSB6xjOqkeVrxGNM6tjmOXnoMfJOjBHkMbtAw3DrQWtQTLo o+ZqbKX/UdguG9ljMCunN7+jd+6ab2fu9MmZQIwVlQ== X-Google-Smtp-Source: AGHT+IH9ARQRdCjFK4ie1hx15hQMGPd9k9O0EJtgpBg+zv0yMN1ajDizBUXLvoIwqk47trh99SMG0w== X-Received: by 2002:a0d:d40f:0:b0:5a8:874:bb3a with SMTP id w15-20020a0dd40f000000b005a80874bb3amr13474220ywd.31.1699363836157; Tue, 07 Nov 2023 05:30:36 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:a715:b54d:6aa1:153d:b806? ([2804:1b3:a7c0:a715:b54d:6aa1:153d:b806]) by smtp.gmail.com with ESMTPSA id z145-20020a0dd797000000b005a0f9718a5fsm5545177ywd.78.2023.11.07.05.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 05:30:35 -0800 (PST) Message-ID: <07625ec5-fd57-4801-91a9-a4fbe762271c@linaro.org> Date: Tue, 7 Nov 2023 10:30:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Monday Patch Queue Review update (2023-11-06) Content-Language: en-US To: Noah Goldstein Cc: libc-alpha@sourceware.org References: <35811050-1b16-40ae-94a1-72cdeecdefea@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/11/23 18:46, Noah Goldstein wrote: > On Mon, Nov 6, 2023 at 3:24 PM Adhemerval Zanella Netto > wrote: >> >> >> >> On 06/11/23 15:18, Noah Goldstein wrote: >>> On Mon, Nov 6, 2023 at 8:42 AM Carlos O'Donell wrote: >>>> >>>> Most recent meeting status is always here: >>>> https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update >>>> >>>> Meeting: 2023-11-06 @ 0900h EST5EDT >>>> >>>> Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu >>>> >>>> IRC: #glibc on OFTC. >>>> >>>> Review new patches and restart review at the top. >>>> >>>> * State NEW delegate NOBODY at 459 patches. >>>> * Carlos's SLI at 214 days average patch age in queue and 103254 accumulated patch days. >>>> * Starting at 79195. >>>> * v2: Multiple floating-point environment fixes (Adhemerval) >>>> * Carlos to look at the hppa code. >>>> * Update BAD_TYPECHECK to work on x86_64 (Flavio) >>>> * Needs Hurd review. >>>> * Remove ia64-linux-gnu (Adhemerval) >>>> * On thread discussion that upstream kernel support needed for a Linux port. >>>> * [1/6] aarch64: Add vector implementations of asin routines (Joe) >>>> * Szabolcs: More vector math functions. >>>> * x86: Only align destination to 1x VEC_SIZE in memset 4x loop (Noah) >>>> * x86: Fix unchecked AVX512-VBMI2 usage in strrchr-evex-base.S (Noah) >>>> * v3: Add a tunable to decorate anonymous memory maps (Adhemerval) >>>> * Missing 3 RBs for v3. >>>> * x86: Improve ERMS usage on Zen3+ (Adhemerval) >>>> * Would be valuable to reach out to AMD for feedback. >>> >>> Missed the meeting, but is there a bit more context to this? >> >> I wrote the patchset summary with my finding on a Zen3 core [1], but >> essentially what I have found is ERMS is not really an advantage on >> the sizes where it is being enabled for Zen3+ cores (between 2113, >> rep_movsb_threshold, and L2 cache size, rep_movsb_stop_threshold or >> 524288 on a Zen3 core). >> >> The provided microbenchmark provided by BZ#30995 shows that some >> alignments the resulting throughput is *really* bad; while for others >> is still slight worse than vectorized alternative. So the patchset >> just disables ERMS for Zen3+ cores, and I really seem even a small >> improvement on SPECcpu20017 502.gcc_r (which hits really hard memset). >> > > The BZ seem to be memcpy only, is this param being exported to memset > as well? If so we probably need to NT-store memset impl. We have x86_rep_stosb_threshold for memset and I have extended the memset comment to state how it is used [1]. [1] https://patchwork.sourceware.org/project/glibc/patch/20231031200925.3297456-5-adhemerval.zanella@linaro.org/