From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 628C83858280 for ; Fri, 2 Sep 2022 12:21:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 628C83858280 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-11eb8b133fbso4396515fac.0 for ; Fri, 02 Sep 2022 05:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=3Ox0SW724XoRd89VL300ShLMpIbfS1IOjF1gHRuLlWk=; b=MjUYqWHCilv1cJFegsZC/MUMcR309Cob4cWLn/sjClYSuQiriS6DNGUlQIcaODX6wa NQEo8dhfCdkrqz5bPLZFyDg/7QY0dnciIjlc7ML6SlNWgsHHDAfdj8qil0OfQGEsErwU ETgKglCgb45/olzv5z27QDSqCSFPlkTgYjcy/c6ZivhNCpV4x33ZzJat94MCpPrLJUrq xnvEc8UoyhtoxyeRYgvcr+xM3CZ32F2Wb2NfDl7Nvy0b4r4xWTvKeMPqVsiTnUb1j480 Wt78w7+pi0cGMLWnbRWkqm6/q1Pll/FU918o3Fp+WotvSphmBLwh8gqz4m6na4zYxk19 ncGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=3Ox0SW724XoRd89VL300ShLMpIbfS1IOjF1gHRuLlWk=; b=bgdhVGgXCBqGnsK9Vo5miB63mCECsqe/q4ZcHr/Nz9DH1picN+ZckGc4xg/JMuAa9g SkJrrgkliVXeSD2L0MxqOz4lpEzQeWmixLYbEL3HFrrrDaEOqLEdqojMcKlh6abgfXZE E8n3YutJlQDXYsevzLIJhLgaBt8Hrx94kszh2WfNy8HIhXD2nLJCUy2OqJVTHSc08sMm SoiXlbVKe7YWUmXV9YWzTaCSvpNyJZEognYTheCR93Wb4hBLiTU650jCMCMJgexJPLfI R6PG/rIzF5v9uKRbIn8Z9BLwNqRhuZQ39Evb7cOb0KOxyIvpM0yaoT/ACmBzKusqquHJ yHHQ== X-Gm-Message-State: ACgBeo0SF96eWDGH/vX1Si5VaYgxwbqLzdfcwj46P708rFhxPQPlezaV Ihcw9PzpCW3mX6BEohsPncVGLg== X-Google-Smtp-Source: AA6agR7ZOZU85NUI4s+XSvj4QMTruxfpgUOxYfooI2yKUdvrdXrWGMgVU1ffuu+ivRwRwRcgOpWGQg== X-Received: by 2002:a05:6808:f0d:b0:343:8cf1:770a with SMTP id m13-20020a0568080f0d00b003438cf1770amr1796886oiw.3.1662121272330; Fri, 02 Sep 2022 05:21:12 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:dfed:6168:b02a:5b73:f2ce? ([2804:1b3:a7c0:dfed:6168:b02a:5b73:f2ce]) by smtp.gmail.com with ESMTPSA id a19-20020a544e13000000b0033e8629b323sm864445oiy.35.2022.09.02.05.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Sep 2022 05:21:12 -0700 (PDT) Message-ID: <07bffaba-4b12-2493-f1bb-72e115d64e2b@linaro.org> Date: Fri, 2 Sep 2022 09:21:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] elf: Use C11 like atomics on _dl_mcount Content-Language: en-US To: Wilco Dijkstra Cc: 'GNU C Library' References: <59b9367c-08f1-4f38-7273-b5eca48be60e@linaro.org> <5fd88725-8bef-2e26-420a-1216ebfa5cec@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/09/22 20:18, Wilco Dijkstra wrote: > Hi Adhemerval, > >> Is the https://patchwork.sourceware.org/project/glibc/list/?series=10727 right? I >> think it has failed CI, could you submit again? > > I'll rebase it. I'll probably move the files that cause all the conflicts into a different > patch (an alternative would be to increase the vertical spacing between all the > defines first so that merge tools no longer get confused). > >> I thinking we are tracking two different issues, although they are correlated. >> My take is to first try to map the current code to a C11-like atomic, so we >> can always use compiler builtins where applicable (there are couple of >> architecture that we might avoid using libgcc for performance reasons), and >> then check if the atomic usage does make sense. > > Yes, so I first mapped them to an atomic with the most appropriate MO (since > the MO of many existing macros is not well defined). We should look at > correctness in a second pass since it is already clear there are many concurrency > bugs. And it seems that for 10727 series you didn't change the elf/dl-profile.c. With the relaxed MO for the counters, are you ok with the change?