From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 5713A388A43B for ; Wed, 3 Feb 2021 21:31:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5713A388A43B Received: by mail-wr1-x42a.google.com with SMTP id a1so965960wrq.6 for ; Wed, 03 Feb 2021 13:31:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6F4siZJxKQ3DkAo6krYsbG7sZzRpHMzfQO0FgWwFnPs=; b=oB3qweRB2huZcCYIDwgI8MsPTnljQrM7OsCRUMt83XvUjv/f1sfy+p/I89eOkV0EZv fLCVn7WB0Jr+rdZMU7ZBxM+o2gJzwdZnVelOpxxt7CWjTqHLae4ynY8pgDQdB1QXDg3d GngNMdiNr1ziui4x+rec5HDWw88vywM0nLFTJM8SPm/fORoKmXnOMGTz6rK9eswX7vAj IFdCh9/pqv53DjzwwtkyE5rRfRmBLbxVqL3CM1IAH0YTW+83pb2qqumFFB7g5wtABgcC 8mwaYAlgHPHJjJPb794nZm2FsT4xuJhhoiJKOManMNjEDroAR/YPp0c5F7fHtXFq7uNY ovbg== X-Gm-Message-State: AOAM53334pPrgHxO4o96sjsDvHpagivvJUoDo6mkEPQ3baILbczv4RGi ev60zrV757sBUqoV+AXJlW4= X-Google-Smtp-Source: ABdhPJxQReQDAjdiX6Iku66dDtAMDqXhXeamY2Z3A7uC1Xw8zx8r+Ii95bKINq9INW+I+2J1s6V5Kw== X-Received: by 2002:a5d:68c1:: with SMTP id p1mr5698776wrw.325.1612387868525; Wed, 03 Feb 2021 13:31:08 -0800 (PST) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with UTF8SMTPSA id r15sm5238875wrq.1.2021.02.03.13.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 13:31:08 -0800 (PST) Subject: Re: [PATCH] getsockname.2: Use restrict in prototypes To: mtk.manpages@gmail.com Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org, Heinrich Schuchardt References: <20210203212508.162239-1-alx.manpages@gmail.com> From: "Alejandro Colomar (man-pages)" Message-ID: <07cd0609-31d8-adbd-2549-dc4ad54bbd34@gmail.com> Date: Wed, 3 Feb 2021 22:31:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20210203212508.162239-1-alx.manpages@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2021 21:31:11 -0000 On 2/3/21 10:25 PM, Alejandro Colomar wrote: > POSIX specifies that the 2nd and 3rd parameters to getsockname() > shall be 'restrict'. Glibc uses 'restrict' too. > Let's use it here too. > > ...... > > .../glibc$ grep_syscall_wrapper getsockname > socket/sys/socket.h:116: > extern int getsockname (int __fd, __SOCKADDR_ARG __addr, > socklen_t *__restrict __len) __THROW; > .../glibc$ grep -rn '# *define __SOCKADDR_ARG' > socket/sys/socket.h:58: > # define __SOCKADDR_ARG struct sockaddr *__restrict > .../glibc$ > > function grep_syscall_wrapper() > { > if ! [ -v 1 ]; then > >&2 echo "Usage: ${FUNCNAME[0]} "; > return ${EX_USAGE}; > fi > > find * -type f \ > |grep '\.h$' \ > |sort -V \ > |xargs pcregrep -Mn \ > "(?s)^[^\s#][\w\s]+\s+\**${1}\s*\([\w\s()[\]*,]*?(...)?\)[\w\s()]*;" \ > |sed -E 's/^[^:]+:[0-9]+:/&\n/'; > } > > Signed-off-by: Alejandro Colomar Hi Michael, I forgot to actually add restrict to one of the parameters. Wait for v2 :) Cheers, Alex > --- > man2/getsockname.2 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man2/getsockname.2 b/man2/getsockname.2 > index 55db4b84c..034c9d4ac 100644 > --- a/man2/getsockname.2 > +++ b/man2/getsockname.2 > @@ -44,8 +44,8 @@ getsockname \- get socket name > .nf > .B #include > .PP > -.BI "int getsockname(int " sockfd ", struct sockaddr *" addr \ > -", socklen_t *" addrlen ); > +.BI "int getsockname(int " sockfd ", struct sockaddr *" addr , > +.BI " socklen_t *restrict " addrlen ); > .fi > .SH DESCRIPTION > .BR getsockname () > -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/