From: Xi Ruoyao <xry111@mengyan1223.wang>
To: libc-alpha@sourceware.org
Subject: [PATCH] mips: align stack in clone [BZ #28223]
Date: Fri, 13 Aug 2021 00:58:31 +0800 [thread overview]
Message-ID: <07cf2ef7f47070979089f880d91a0369c4efa978.camel@mengyan1223.wang> (raw)
The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32
ABI require 8 byte aligned stack. Previously if the caller passed an
unaligned stack to clone the the child misbehaved.
Fixes bug 28223.
---
sysdeps/unix/sysv/linux/mips/clone.S | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S
index 71d9dba8bd..9e5826aeba 100644
--- a/sysdeps/unix/sysv/linux/mips/clone.S
+++ b/sysdeps/unix/sysv/linux/mips/clone.S
@@ -55,6 +55,13 @@ NESTED(__clone,4*SZREG,sp)
.set at
#endif
+ /* Align stack to 4/8 bytes per the ABI */
+#if _MIPS_SIM == _ABIO32
+ li t0,-4
+#else
+ li t0,-8
+#endif
+ and a1,a1,t0
/* Sanity check arguments. */
li v0,EINVAL
--
2.32.0
next reply other threads:[~2021-08-12 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 16:58 Xi Ruoyao [this message]
2021-08-12 17:20 ` Joseph Myers
2021-08-12 17:27 ` Xi Ruoyao
2021-08-12 20:32 ` Joseph Myers
2021-08-13 10:43 ` [PATCH] mips: increase stack alignment in clone to match the ABI Xi Ruoyao
2021-08-13 12:04 ` [PATCH v2] " Xi Ruoyao
2021-08-13 16:02 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cf2ef7f47070979089f880d91a0369c4efa978.camel@mengyan1223.wang \
--to=xry111@mengyan1223.wang \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).