From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id E558B385840F for ; Tue, 22 Mar 2022 17:15:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E558B385840F Content-Type: multipart/signed; boundary="Apple-Mail=_138068DC-AD09-4BEC-AF47-778BC5ED209E"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH] configure.ac: fix bashism in configure.ac From: Sam James In-Reply-To: <6f05f963-9aa5-680e-60b1-7468a487a778@linaro.org> Date: Tue, 22 Mar 2022 17:15:32 +0000 Cc: libc-alpha@sourceware.org Message-Id: <080F1938-31C7-443A-8162-8BFC94126535@gentoo.org> References: <20220321230343.2582331-1-sam@gentoo.org> <6f05f963-9aa5-680e-60b1-7468a487a778@linaro.org> To: Adhemerval Zanella X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 17:15:39 -0000 --Apple-Mail=_138068DC-AD09-4BEC-AF47-778BC5ED209E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 22 Mar 2022, at 12:46, Adhemerval Zanella = wrote: >=20 >=20 >=20 > On 21/03/2022 20:03, Sam James via Libc-alpha wrote: >> configure scripts need to be runnable with a POSIX-compliant /bin/sh. >>=20 >> On many (but not all!) systems, /bin/sh is provided by Bash, so = errors >> like this aren't spotted. Notably Debian defaults to /bin/sh provided >> by dash which doesn't tolerate such bashisms as '=3D=3D'. >>=20 >> This retains compatibility with bash. >>=20 >> Fixes configure warnings/errors like: >> ``` >> checking if compiler warns about alias for function with incompatible = types... yes >> /var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: = 4209: test: xyes: unexpected operator >> ``` >>=20 >> Signed-off-by: Sam James >=20 > There are other occurrences of this bashism as on other configure.ac: >=20 > sysdeps/powerpc/powerpc64/le/configure.ac:66:AS_IF([test = "$libc_cv_compiler_powerpc64le_ldbl128_mabi" =3D=3D "no"], > = sysdeps/powerpc/powerpc64/le/fpu/multiarch/configure.ac:12:AS_IF([[test = "$libc_cv_mcpu_power10" =3D=3D "yes"]],[ >=20 > Should we fix it them as well? >=20 Thanks, I goofed up the grep. Fixed! > Beside LGTM, thanks. >=20 > Reviewed-by: Adhemerval Zanella I forgot to add your tag on sending v2, but I didn't want to send a v3 = for it (unless I should?) Best, sam --Apple-Mail=_138068DC-AD09-4BEC-AF47-778BC5ED209E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmI6BDRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDuS0wgAgExZwBGE3pJUl5JzMb2SGohtox53Uq7sshMQLTcxSiTderb0MfQT6tDG 68D1VrJTDCKgVNOzjaVXjcGBpMPv1gynoWmuY+ssoQNy4xCY21FzP3FH+I6+859u 3p3+kIwdOt1dpxCCmFn7oLA/8GJBhyDtho1ZFhhgYAJHSAOWN9feqOLAtZOXPgCM KPhb2I8JJF7FSBbs553wkRZfyZTpuCDbvsipjuOk5PlcJzTLbBmmTiPpBYd47gAl 1sSyyoqJ8jKStPuTjzeruEPka+EMRNMazSEOVVh32Yl70s2kfPq5QH7pHRNv5oZA 6LbJH24BOx5ZD/V7Qp6jF7Tmciny7g== =pJDL -----END PGP SIGNATURE----- --Apple-Mail=_138068DC-AD09-4BEC-AF47-778BC5ED209E--