From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 64A97385E00E for ; Mon, 15 Feb 2021 12:59:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64A97385E00E Received: by mail-qt1-x833.google.com with SMTP id b24so4685808qtp.13 for ; Mon, 15 Feb 2021 04:59:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ajhsG5ZYyed7ZY7qvzpHXc1iyrBV0KFz+DHvpXEStA4=; b=bgiCD820EU9cQKLVry6CRgZrUNIHSO+HerWGnjAkwrI4oS2kdMsfG+3zpoQ9paueJa iq4aSAqPKwwBQ+uByGUHO31KPvKIQp2xGhO9GbL9KbqrcLmdYxaqtLXYguLdfpjHUHrZ Ek1KkGp4rs1hdiBDQSr+SD40M499YoJ4ShTrk4VPMikCet+LrAU/ZzmPUTZ/u9P/SE0y +peDEZZG4dA+8aRGjsGvISbC6Et22/gGbH1WYKZxR2WM06O1Bn5bk+95m1v+LAITme2X OnFZpELTsHbgxuqajXiy8YDEXGPkbc+vPGx640csdapyZKBtQq1/remJEfEiNq4AuJR5 jDoA== X-Gm-Message-State: AOAM531e3hiP9pTAH0H4dEKUmNT4sYbCjsUob6nyE5Ni8mBVnOM/oyN5 GoTyH39cISew6rqMSz9Uwul7GaK0lNLQDw== X-Google-Smtp-Source: ABdhPJw/R2neVqha01jO6J61/KqyXL64zvJkZWCH+kbLLbJchYZGU5I3ncrH1e6uaxSCQ4t4t7C8Tg== X-Received: by 2002:ac8:745a:: with SMTP id h26mr13477457qtr.278.1613393989661; Mon, 15 Feb 2021 04:59:49 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id 76sm12239053qke.95.2021.02.15.04.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 04:59:49 -0800 (PST) Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING To: Naohiro Tamura , libc-alpha@sourceware.org References: <20210215123137.204048-1-naohirot@fujitsu.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <0820aeae-41c4-e751-e6b2-aaa83921fc41@linaro.org> Date: Mon, 15 Feb 2021 09:59:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210215123137.204048-1-naohirot@fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 12:59:52 -0000 On 15/02/2021 09:31, Naohiro Tamura wrote: > This patch replaced obsoleted AC_HELP_STRING to AS_HELP_STRING. > As of Glibc 2.33, INSTALL says "GNU 'autoconf' 2.69 (exactly)" is > required. So we can safely replace obsoleted macro without worrying > about older autoconf. > This change doesn't affect the contents of "configure" file. If this does not change or improve configure, why change configure.ac then? > --- > configure.ac | 60 ++++++++++++++++++++++++++-------------------------- > 1 file changed, 30 insertions(+), 30 deletions(-) > > diff --git a/configure.ac b/configure.ac > index dfebb8a7cc..b3f317f86b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -90,7 +90,7 @@ config_vars= > > # Check for a --with-gd argument and set libgd-LDFLAGS in config.make. > AC_ARG_WITH([gd], > - AC_HELP_STRING([--with-gd=DIR], > + AS_HELP_STRING([--with-gd=DIR], > [find libgd include dir and library with prefix DIR]), > [dnl > case "$with_gd" in > @@ -100,7 +100,7 @@ yes|''|no) ;; > esac > ]) > AC_ARG_WITH([gd-include], > - AC_HELP_STRING([--with-gd-include=DIR], > + AS_HELP_STRING([--with-gd-include=DIR], > [find libgd include files in DIR]), > [dnl > case "$with_gd_include" in > @@ -109,7 +109,7 @@ case "$with_gd_include" in > esac > ]) > AC_ARG_WITH([gd-lib], > - AC_HELP_STRING([--with-gd-lib=DIR], > + AS_HELP_STRING([--with-gd-lib=DIR], > [find libgd library files in DIR]), > [dnl > case "$with_gd_lib" in > @@ -129,18 +129,18 @@ fi > > dnl Arguments to specify presence of other packages/features. > AC_ARG_WITH([binutils], > - AC_HELP_STRING([--with-binutils=PATH], > + AS_HELP_STRING([--with-binutils=PATH], > [specify location of binutils (as and ld)]), > [path_binutils=$withval], > [path_binutils='']) > AC_ARG_WITH([selinux], > - AC_HELP_STRING([--with-selinux], > + AS_HELP_STRING([--with-selinux], > [if building with SELinux support]), > [with_selinux=$withval], > [with_selinux=auto]) > > AC_ARG_WITH([headers], > - AC_HELP_STRING([--with-headers=PATH], > + AS_HELP_STRING([--with-headers=PATH], > [location of system headers to use > (for example /usr/src/linux/include) > @<:@default=compiler default@:>@]), > @@ -150,56 +150,56 @@ AC_SUBST(sysheaders) > > AC_SUBST(use_default_link) > AC_ARG_WITH([default-link], > - AC_HELP_STRING([--with-default-link], > + AS_HELP_STRING([--with-default-link], > [do not use explicit linker scripts]), > [use_default_link=$withval], > [use_default_link=default]) > > dnl Additional build flags injection. > AC_ARG_WITH([nonshared-cflags], > - AC_HELP_STRING([--with-nonshared-cflags=CFLAGS], > + AS_HELP_STRING([--with-nonshared-cflags=CFLAGS], > [build nonshared libraries with additional CFLAGS]), > [extra_nonshared_cflags=$withval], > [extra_nonshared_cflags=]) > AC_SUBST(extra_nonshared_cflags) > > AC_ARG_ENABLE([sanity-checks], > - AC_HELP_STRING([--disable-sanity-checks], > + AS_HELP_STRING([--disable-sanity-checks], > [really do not use threads (should not be used except in special situations) @<:@default=yes@:>@]), > [enable_sanity=$enableval], > [enable_sanity=yes]) > > AC_ARG_ENABLE([shared], > - AC_HELP_STRING([--enable-shared], > + AS_HELP_STRING([--enable-shared], > [build shared library @<:@default=yes if GNU ld@:>@]), > [shared=$enableval], > [shared=yes]) > AC_ARG_ENABLE([profile], > - AC_HELP_STRING([--enable-profile], > + AS_HELP_STRING([--enable-profile], > [build profiled library @<:@default=no@:>@]), > [profile=$enableval], > [profile=no]) > AC_ARG_ENABLE([static-pie], > - AC_HELP_STRING([--enable-static-pie], > + AS_HELP_STRING([--enable-static-pie], > [enable static PIE support and use it in the testsuite @<:@default=no@:>@]), > [static_pie=$enableval], > [static_pie=no]) > AC_ARG_ENABLE([timezone-tools], > - AC_HELP_STRING([--disable-timezone-tools], > + AS_HELP_STRING([--disable-timezone-tools], > [do not install timezone tools @<:@default=install@:>@]), > [enable_timezone_tools=$enableval], > [enable_timezone_tools=yes]) > AC_SUBST(enable_timezone_tools) > > AC_ARG_ENABLE([hardcoded-path-in-tests], > - AC_HELP_STRING([--enable-hardcoded-path-in-tests], > + AS_HELP_STRING([--enable-hardcoded-path-in-tests], > [hardcode newly built glibc path in tests @<:@default=no@:>@]), > [hardcoded_path_in_tests=$enableval], > [hardcoded_path_in_tests=no]) > AC_SUBST(hardcoded_path_in_tests) > > AC_ARG_ENABLE([stackguard-randomization], > - AC_HELP_STRING([--enable-stackguard-randomization], > + AS_HELP_STRING([--enable-stackguard-randomization], > [initialize __stack_chk_guard canary with a random number at program start]), > [enable_stackguard_randomize=$enableval], > [enable_stackguard_randomize=no]) > @@ -208,7 +208,7 @@ if test "$enable_stackguard_randomize" = yes; then > fi > > AC_ARG_ENABLE([hidden-plt], > - AC_HELP_STRING([--disable-hidden-plt], > + AS_HELP_STRING([--disable-hidden-plt], > [do not hide internal function calls to avoid PLT]), > [hidden=$enableval], > [hidden=yes]) > @@ -217,7 +217,7 @@ if test "x$hidden" = xno; then > fi > > AC_ARG_ENABLE([bind-now], > - AC_HELP_STRING([--enable-bind-now], > + AS_HELP_STRING([--enable-bind-now], > [disable lazy relocations in DSOs]), > [bindnow=$enableval], > [bindnow=no]) > @@ -229,7 +229,7 @@ fi > dnl Build glibc with -fstack-protector, -fstack-protector-all, or > dnl -fstack-protector-strong. > AC_ARG_ENABLE([stack-protector], > - AC_HELP_STRING([--enable-stack-protector=@<:@yes|no|all|strong@:>@], > + AS_HELP_STRING([--enable-stack-protector=@<:@yes|no|all|strong@:>@], > [Use -fstack-protector[-all|-strong] to detect glibc buffer overflows]), > [enable_stack_protector=$enableval], > [enable_stack_protector=no]) > @@ -241,7 +241,7 @@ esac > dnl On some platforms we cannot use dynamic loading. We must provide > dnl static NSS modules. > AC_ARG_ENABLE([static-nss], > - AC_HELP_STRING([--enable-static-nss], > + AS_HELP_STRING([--enable-static-nss], > [build static NSS modules @<:@default=no@:>@]), > [static_nss=$enableval], > [static_nss=no]) > @@ -252,14 +252,14 @@ if test x"$static_nss" = xyes || test x"$shared" = xno; then > fi > > AC_ARG_ENABLE([force-install], > - AC_HELP_STRING([--disable-force-install], > + AS_HELP_STRING([--disable-force-install], > [don't force installation of files from this package, even if they are older than the installed files]), > [force_install=$enableval], > [force_install=yes]) > AC_SUBST(force_install) > > AC_ARG_ENABLE([maintainer-mode], > - AC_HELP_STRING([--enable-maintainer-mode], > + AS_HELP_STRING([--enable-maintainer-mode], > [enable make rules and dependencies not useful (and sometimes confusing) to the casual installer]), > [maintainer=$enableval], > [maintainer=no]) > @@ -267,7 +267,7 @@ AC_ARG_ENABLE([maintainer-mode], > dnl On some platforms we allow dropping compatibility with all kernel > dnl versions. > AC_ARG_ENABLE([kernel], > - AC_HELP_STRING([--enable-kernel=VERSION], > + AS_HELP_STRING([--enable-kernel=VERSION], > [compile for compatibility with kernel not older than VERSION]), > [minimum_kernel=$enableval], > []) > @@ -285,34 +285,34 @@ dnl For the development we sometimes want gcc to issue even more warnings. > dnl This is not the default since many of the extra warnings are not > dnl appropriate. > AC_ARG_ENABLE([all-warnings], > - AC_HELP_STRING([--enable-all-warnings], > + AS_HELP_STRING([--enable-all-warnings], > [enable all useful warnings gcc can issue]), > [all_warnings=$enableval], > []) > AC_SUBST(all_warnings) > > AC_ARG_ENABLE([werror], > - AC_HELP_STRING([--disable-werror], > + AS_HELP_STRING([--disable-werror], > [do not build with -Werror]), > [enable_werror=$enableval], > [enable_werror=yes]) > AC_SUBST(enable_werror) > > AC_ARG_ENABLE([multi-arch], > - AC_HELP_STRING([--enable-multi-arch], > + AS_HELP_STRING([--enable-multi-arch], > [enable single DSO with optimizations for multiple architectures]), > [multi_arch=$enableval], > [multi_arch=default]) > > AC_ARG_ENABLE([experimental-malloc], > - AC_HELP_STRING([--disable-experimental-malloc], > + AS_HELP_STRING([--disable-experimental-malloc], > [disable experimental malloc features]), > [experimental_malloc=$enableval], > [experimental_malloc=yes]) > AC_SUBST(experimental_malloc) > > AC_ARG_ENABLE([memory-tagging], > - AC_HELP_STRING([--enable-memory-tagging], > + AS_HELP_STRING([--enable-memory-tagging], > [enable memory tagging if supported by the architecture @<:@default=no@:>@]), > [memory_tagging=$enableval], > [memory_tagging=no]) > @@ -327,14 +327,14 @@ fi > AC_SUBST(memory_tagging) > > AC_ARG_ENABLE([crypt], > - AC_HELP_STRING([--disable-crypt], > + AS_HELP_STRING([--disable-crypt], > [do not build nor install the passphrase hashing library, libcrypt]), > [build_crypt=$enableval], > [build_crypt=yes]) > AC_SUBST(build_crypt) > > AC_ARG_ENABLE([nss-crypt], > - AC_HELP_STRING([--enable-nss-crypt], > + AS_HELP_STRING([--enable-nss-crypt], > [enable libcrypt to use nss]), > [nss_crypt=$enableval], > [nss_crypt=no]) > @@ -474,7 +474,7 @@ AC_TRY_COMPILE([], [ > [libc_cv_compiler_default_cet=no]) > > AC_ARG_ENABLE([cet], > - AC_HELP_STRING([--enable-cet], > + AS_HELP_STRING([--enable-cet], > [enable Intel Control-flow Enforcement Technology (CET), x86 only]), > [enable_cet=$enableval], > [enable_cet=$libc_cv_compiler_default_cet]) >