From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 09B583858D28 for ; Wed, 20 Jul 2022 17:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09B583858D28 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-10d8880d055so2504732fac.8 for ; Wed, 20 Jul 2022 10:19:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=aunEenTDUfapT5ah2L90R4fy3b6UWj7znoVGit89t5M=; b=1FIWiUj30NvU0wPKBxWfIwAWx3IYC5I8BDB6gblyTXgXETYb73cHMYdCwthdIF8lDY 04SJkv9876yIzQlIvCUIBCOlKSLD9I+CPcPOe1DGnJqIWw1QTxa3d0CZog4BQwPIYx/S 4p2xVreL6GG7APVi2rDZRx27+krRrPrNXqBEI/0y6yZ0hpnyt3ditLYX8aFhYhYQiZrj /6toOfHgVwsioAWRZ+nM5y7NWXZGJs7OhPisFGHb54VFSm79KakAWnSIAok89/gsh/ZQ M4KpD0GPzwaq+fMugahny4GgHQXUjR/+AqjIvQibfhDN2ypqZ1tybZETXs1f7Q9yU93Z idoA== X-Gm-Message-State: AJIora/djzao9yYH233GKdoUuZNvQwS0dZupcJg0S5rfSmBhYj3MFVBQ FShlgHJ92gXXexYB02wjG2UYJA== X-Google-Smtp-Source: AGRyM1uziS4bTs0FF3JwlgqF96fO492mkth20QbhSmKYJxGtVq3Hmp8KrsRzbqm4ib0tLr3MTmmflQ== X-Received: by 2002:a05:6870:a105:b0:10b:f1bb:6308 with SMTP id m5-20020a056870a10500b0010bf1bb6308mr3068909oae.91.1658337573342; Wed, 20 Jul 2022 10:19:33 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:8ded:dd7a:8a21:1a2b:76c5? ([2804:431:c7cb:8ded:dd7a:8a21:1a2b:76c5]) by smtp.gmail.com with ESMTPSA id r27-20020a056830237b00b0061c9159bb8asm5292118oth.61.2022.07.20.10.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 10:19:33 -0700 (PDT) Message-ID: <087092dc-2e2f-bb3e-74b9-a3462cff5763@linaro.org> Date: Wed, 20 Jul 2022 14:19:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name References: <20220719012056.1461897-1-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220719012056.1461897-1-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 17:19:35 -0000 On 18/07/22 22:20, caiyinyu wrote: > Hello, these are LoongArch patches v7, and we really need your futher suggestions: > > There are 6 parts in total. > > 1. HISTORY: > LoongArch patches v1: https://sourceware.org/pipermail/libc-alpha/2021-August/130262.html > LoongArch patches v2: https://sourceware.org/pipermail/libc-alpha/2021-December/134811.html > LoongArch patches v3: https://sourceware.org/pipermail/libc-alpha/2022-April/137888.html > LoongArch patches v4: https://sourceware.org/pipermail/libc-alpha/2022-May/subject.html > LoongArch patches v5: https://sourceware.org/pipermail/libc-alpha/2022-June/139262.html > LoongArch patches v6: https://sourceware.org/pipermail/libc-alpha/2022-July/140446.html > > 2. LoongArch-Doc: https://github.com/loongson/LoongArch-Documentation > > We add new section: procedure calling convention. > https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_procedure_calling_convention > > > 3. Linux kernel, GCC and Binutils Loongarch parts have been into GNU Open Source community. > > > 4. From Adhemerval Zanella Netto: >> I finished my review for the port and it looks ok in general, however there >> some pieces that would require a v7: >> >> 1. Add R_LARCH_NONE handling on bootstrap, binutils 2.38 does generated it >> and from previous discussion it should be considered a missed >> optimizations instead of a linker error. > > R_LARCH_NONE handling has been added on bootstrap. >> >> 2. Remove the __loongarch_soft_float parts, since there is no support for >> soft floating-point. > > All __loongarch_soft_float removed. >> >> 3. Remove sysdeps/unix/sysv/linux/loongarch/ldconfig.h, this file is not >> required. > > This file has been removed. >> >> 4. Some minor style issues. > > See previous emails. > https://sourceware.org/pipermail/libc-alpha/2022-July/thread.html >> >> 5. Either remove HAVE_GETTIMEOFDAY_VSYSCALL or add a gettimeofday ifunc >> optimization. > > Removed now. >> >> The only part really prevent port inclusion is 1. I am also assuming ifunc >> is support (at least you have added support on the Linux ABI part) with >> binutils 2.38. If not, you will need to remove support until you fix it on >> binutils. >> >> And also, you need to check and report the test results using the expected >> defined release branches, using out-of-tree branches are not acceptable for >> inclusion. > > 5. There are some new changes: This version looks good to me, everything I have pointed out in previous release was addressed, build-many-glibcs.py and make check does not trigger any issue, and some qemu tests show that the generated loader and binaries are corrected generated. If you want, I can push it upstream. Carlos is ok to install it?