From: Paul Eggert <eggert@cs.ucla.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] regex: fix buffer read overrun in search [BZ#28470]
Date: Fri, 26 Nov 2021 10:35:04 -0800 [thread overview]
Message-ID: <08a868e9-2395-532a-cd02-835e76c31da4@cs.ucla.edu> (raw)
In-Reply-To: <87mtlslibo.fsf@igel.home>
On 11/25/21 01:01, Andreas Schwab wrote:
>> Partly because it refuses to read past the bounds of an array, where the
>> old code would.
>
> That's just papering over a bug, not fixing it.
That's not clear to me. Perhaps you're right, but perhaps it really does
fix the bug.
>> And partly because it's been run through several tests - not just
>> glibc tests, but also grep and coreutils and probably some others by
>> now.
>
> How much coverage do they provide?
Someone who has more time could presumably determine this by looking at
the respective test suites. I forgot to mention, Gnulib also has its own
regex tests (which also pass).
> Also, you failed to add a test.
Yes, that's correct. It would be nice if someone could do that. However,
it'd be some work and like you I'm pressed for time.
next prev parent reply other threads:[~2021-11-26 18:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 22:15 Paul Eggert
2021-10-19 7:17 ` Andreas Schwab
2021-10-19 8:13 ` Paul Eggert
2021-10-19 8:25 ` Andreas Schwab
2021-10-19 8:57 ` Paul Eggert
2021-10-19 15:09 ` Andreas Schwab
2021-10-19 18:14 ` Paul Eggert
2021-11-24 22:27 ` Paul Eggert
2021-11-24 22:45 ` Andreas Schwab
2021-11-24 23:50 ` Paul Eggert
2021-11-25 9:01 ` Andreas Schwab
2021-11-26 18:35 ` Paul Eggert [this message]
2021-11-26 18:39 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a868e9-2395-532a-cd02-835e76c31da4@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).