From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id CBEB63858D39 for ; Fri, 26 Nov 2021 18:35:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBEB63858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0FBF9160100; Fri, 26 Nov 2021 10:35:06 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jiF-a3wxzRZg; Fri, 26 Nov 2021 10:35:05 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5B7E6160103; Fri, 26 Nov 2021 10:35:05 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gle03i5SlLYg; Fri, 26 Nov 2021 10:35:05 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 36920160100; Fri, 26 Nov 2021 10:35:05 -0800 (PST) Message-ID: <08a868e9-2395-532a-cd02-835e76c31da4@cs.ucla.edu> Date: Fri, 26 Nov 2021 10:35:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH] regex: fix buffer read overrun in search [BZ#28470] Content-Language: en-US To: Andreas Schwab Cc: libc-alpha@sourceware.org References: <20211018221548.76024-1-eggert@cs.ucla.edu> <8735oxsct4.fsf@igel.home> <87tuhdqv48.fsf@igel.home> <87k0i9oxus.fsf@igel.home> <3fb93832-1ff8-3615-6b1e-08961bb7d6ef@cs.ucla.edu> <87mtltgolf.fsf@igel.home> <87mtlslibo.fsf@igel.home> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <87mtlslibo.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 18:35:08 -0000 On 11/25/21 01:01, Andreas Schwab wrote: >> Partly because it refuses to read past the bounds of an array, where the >> old code would. > > That's just papering over a bug, not fixing it. That's not clear to me. Perhaps you're right, but perhaps it really does fix the bug. >> And partly because it's been run through several tests - not just >> glibc tests, but also grep and coreutils and probably some others by >> now. > > How much coverage do they provide? Someone who has more time could presumably determine this by looking at the respective test suites. I forgot to mention, Gnulib also has its own regex tests (which also pass). > Also, you failed to add a test. Yes, that's correct. It would be nice if someone could do that. However, it'd be some work and like you I'm pressed for time.