From: Carlos O'Donell <carlos@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] tunables: Disallow negative values for some tunables
Date: Wed, 10 Feb 2021 07:57:06 -0500 [thread overview]
Message-ID: <08dc8bf7-809f-2e3e-a9b5-c7f006258c36@redhat.com> (raw)
In-Reply-To: <20210205080929.3316869-1-siddhesh@sourceware.org>
On 2/5/21 3:09 AM, Siddhesh Poyarekar via Libc-alpha wrote:
> The glibc.malloc.mmap_max tunable as well as al of the INT_32 tunables
> don't have use for negative values, so pin the hardcoded limits in the
> non-negative range of INT. There's no real benefit in any of those
> use cases for the extended range of unsigned, so I have avoided added
> a new type to keep things simple.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> elf/dl-tunables.list | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list
> index 3cf0ad83ec..8ddd4a2314 100644
> --- a/elf/dl-tunables.list
> +++ b/elf/dl-tunables.list
> @@ -64,6 +64,7 @@ glibc {
> type: INT_32
> env_alias: MALLOC_MMAP_MAX_
> security_level: SXID_IGNORE
> + minval: 0
> }
> arena_max {
> type: SIZE_T
> @@ -109,22 +110,27 @@ glibc {
> skip_lock_busy {
> type: INT_32
> default: 3
> + minval: 0
> }
> skip_lock_internal_abort {
> type: INT_32
> default: 3
> + minval: 0
> }
> skip_lock_after_retries {
> type: INT_32
> default: 3
> + minval: 0
> }
> tries {
> type: INT_32
> default: 3
> + minval: 0
> }
> skip_trylock_internal_abort {
> type: INT_32
> default: 3
> + minval: 0
> }
> }
>
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2021-02-10 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 8:09 Siddhesh Poyarekar
2021-02-10 12:57 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08dc8bf7-809f-2e3e-a9b5-c7f006258c36@redhat.com \
--to=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).