From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id ABDC4398E45C for ; Wed, 10 Feb 2021 12:57:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ABDC4398E45C Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-94UmUr5XPYeJ--6J2Lc64A-1; Wed, 10 Feb 2021 07:57:09 -0500 X-MC-Unique: 94UmUr5XPYeJ--6J2Lc64A-1 Received: by mail-qk1-f197.google.com with SMTP id s66so1440245qkh.10 for ; Wed, 10 Feb 2021 04:57:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=n7ZkTKiA1ohj8k9a/47Af0EQI6eukAvcjTEDon7Ww7U=; b=jrL5fvrNFANPc0pzzsenok77QGdtYa5Ehny9uZilVbYKMR94NdN6SekSsa4rCgF2kJ j27stWipYk3IS0t5suBLZyu4MnZqRbLjk1w4EElkFq7uEBAnEXnnsmS8ZYn5kMGkMT/c GKbzbtejpkqqp1yFBlXnTx7Y1wiT0v7QaG840vZZXtJ4dBXXOXGu+CkvGPPWTckfNq9i 0SkkGWXh9V2yYgSrxmR/CYhDxwElfdvDG9tQpIOqnrDIJkvpArgp6g33qzDOp2ecbhCc lCX5w81qu2RMcfyi++XyGpT6abGb92RRjFI43P+AbwEz4lnvnJKLCpdoyqqTOpKjUlfx Fn0g== X-Gm-Message-State: AOAM531Va++hGpt4LSKhMmYtOPWb06FeOBTx6adAFfkKtHZZ7YKMlCrZ V1vzQc70JgQe26wrxGMheQ1zubZS+p/0Vat/WrfelqcOZJWL9sXEf17H7nrOdRxj9o1UHfI6eD+ 5/sD+QM2nhb2n7YuBcHQcP7DZkt032G1Dz9YvVECd8Fu0hMTjaVj5aYwhGeIOmDrNytsQuw== X-Received: by 2002:ac8:5d09:: with SMTP id f9mr2598693qtx.157.1612961828207; Wed, 10 Feb 2021 04:57:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxUDBv2NYNhezaRdVjjhs4PBgpwAZEE6kQp3TIY3XDuU5D4nWMuVl0cJwPHz6vQ6xFz9MLElQ== X-Received: by 2002:ac8:5d09:: with SMTP id f9mr2598664qtx.157.1612961827849; Wed, 10 Feb 2021 04:57:07 -0800 (PST) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id 14sm1138202qtx.84.2021.02.10.04.57.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 04:57:07 -0800 (PST) Subject: Re: [PATCH] tunables: Disallow negative values for some tunables To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20210205080929.3316869-1-siddhesh@sourceware.org> From: Carlos O'Donell Organization: Red Hat Message-ID: <08dc8bf7-809f-2e3e-a9b5-c7f006258c36@redhat.com> Date: Wed, 10 Feb 2021 07:57:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210205080929.3316869-1-siddhesh@sourceware.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 12:57:12 -0000 On 2/5/21 3:09 AM, Siddhesh Poyarekar via Libc-alpha wrote: > The glibc.malloc.mmap_max tunable as well as al of the INT_32 tunables > don't have use for negative values, so pin the hardcoded limits in the > non-negative range of INT. There's no real benefit in any of those > use cases for the extended range of unsigned, so I have avoided added > a new type to keep things simple. LGTM. Reviewed-by: Carlos O'Donell > --- > elf/dl-tunables.list | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list > index 3cf0ad83ec..8ddd4a2314 100644 > --- a/elf/dl-tunables.list > +++ b/elf/dl-tunables.list > @@ -64,6 +64,7 @@ glibc { > type: INT_32 > env_alias: MALLOC_MMAP_MAX_ > security_level: SXID_IGNORE > + minval: 0 > } > arena_max { > type: SIZE_T > @@ -109,22 +110,27 @@ glibc { > skip_lock_busy { > type: INT_32 > default: 3 > + minval: 0 > } > skip_lock_internal_abort { > type: INT_32 > default: 3 > + minval: 0 > } > skip_lock_after_retries { > type: INT_32 > default: 3 > + minval: 0 > } > tries { > type: INT_32 > default: 3 > + minval: 0 > } > skip_trylock_internal_abort { > type: INT_32 > default: 3 > + minval: 0 > } > } > > -- Cheers, Carlos.