From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 557C9383B423 for ; Tue, 20 Apr 2021 15:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 557C9383B423 Received: by mail-il1-x129.google.com with SMTP id v13so16316351ilj.8 for ; Tue, 20 Apr 2021 08:21:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/aJp36W7gjivCjOPar3FJXkasV0BtoFwP3AZ4CeaxT4=; b=X2FjivaNR0B9sE4aH3bMxK4CMIRoMxCwGr+j3tto/uos5jakHXn7SEUeUpmQ29gFhv wjACsBnNujptPPLfnpM3jp9RTABvgPAZYMiIgFuCOhUO/gq2c2w4/7ddRBLprXTB4LHi gkRcMQ+GwYYbPMArEkmGiShWmRNFHWA1Cmu5k7cf1K5xDpO6RARfKeSnSDMSi+KzmW+n B+HkL9MIZKbTyBDes+5JQDJ4j/QNcIwSCd/d6iQOLT2wlbIn2LYaFRDvgmp/49NxGiUs V4EJI0weYPHJGhUoIs0UXCm3EqniYJhFGZMdkZa961vYxcqq+vAHeH6iFjolHfNRHINy 9TQg== X-Gm-Message-State: AOAM531Hxf5QOZ3yHDCvtK/+m5uhYXGmue+YDATXfYfccKE7/ypbNiQF BIZH/bxnI5481sUBABQkTUQsBM2qpW4= X-Google-Smtp-Source: ABdhPJyg9qNKBGwf0CF3vKEgs1lXPKz1f2fBGYMB6h8vrP8laSy3NExdiIEr1zZgbPUP/CXFxKuc4A== X-Received: by 2002:a92:d488:: with SMTP id p8mr22646024ilg.149.1618932091851; Tue, 20 Apr 2021 08:21:31 -0700 (PDT) Received: from ?IPv6:2601:441:457f:c2fd:841:577:9473:19ae? ([2601:441:457f:c2fd:841:577:9473:19ae]) by smtp.gmail.com with ESMTPSA id b9sm8624773ilc.28.2021.04.20.08.21.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 08:21:31 -0700 (PDT) Message-ID: <0944bfee84afc05fcdaed38eacab3838e04317ea.camel@gmail.com> Subject: Re: [PATCH] Add RFC 8335 Definitions from Linux 5.12 From: Andreas Roeseler To: libc-alpha@sourceware.org Date: Tue, 20 Apr 2021 10:21:30 -0500 In-Reply-To: <20210413224255.1746849-1-andreas.a.roeseler@gmail.com> References: <20210413224255.1746849-1-andreas.a.roeseler@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 15:21:42 -0000 On Tue, 2021-04-13 at 17:42 -0500, Andreas Roeseler wrote: > RFC 8335 defines the network utility PROBE, which builds off of the > capabilities of Ping to query more detailed interface information > from > networking nodes. > > The definitions included in this patchset have been accepted into the > linux net-next branch and will be included in Linux 5.12. This > patchset adds the same definitions to the glibc for use in the > iputils package. > > The relevant commits for the Linux definitions can be found here: > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=2b246b2569cd2ac6ff700d0dce56b8bae29b1842 > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=750f4fc2a12f6632b5aa04526bf57fa06bfe8467 > > These changes have been tested by running the glibc tests on x86_64 > > Signed-off-by: Andreas Roeseler > --- >  inet/netinet/icmp6.h          |  2 ++ >  sysdeps/gnu/netinet/ip_icmp.h | 17 +++++++++++++++++ >  2 files changed, 19 insertions(+) > > diff --git a/inet/netinet/icmp6.h b/inet/netinet/icmp6.h > index 22b82335ec..f0df16123e 100644 > --- a/inet/netinet/icmp6.h > +++ b/inet/netinet/icmp6.h > @@ -69,6 +69,8 @@ struct icmp6_hdr >  #define MLD_LISTENER_QUERY          130 >  #define MLD_LISTENER_REPORT         131 >  #define MLD_LISTENER_REDUCTION      132 > +#define ICMP6_EXT_ECHO_REQUEST     160 > +#define ICMP6_EXT_ECHO_REPLY       161 >   >  #define ICMP6_DST_UNREACH_NOROUTE     0 /* no route to destination > */ >  #define ICMP6_DST_UNREACH_ADMIN       1 /* communication with > destination */ > diff --git a/sysdeps/gnu/netinet/ip_icmp.h > b/sysdeps/gnu/netinet/ip_icmp.h > index 5db7ac7c37..1fd6317df4 100644 > --- a/sysdeps/gnu/netinet/ip_icmp.h > +++ b/sysdeps/gnu/netinet/ip_icmp.h > @@ -89,6 +89,23 @@ struct icmphdr >  #define ICMP_EXC_TTL           0       /* TTL count > exceeded           */ >  #define ICMP_EXC_FRAGTIME      1       /* Fragment Reass time > exceeded */ >   > +/* Codes for EXT_ECHO (PROBE) */ > +#define ICMP_EXT_ECHO          42 > +#define ICMP_EXT_ECHOREPLY     43 > +#define ICMP_EXT_MAL_QUERY     1       /* Malformed Query */ > +#define ICMP_EXT_NO_IF         2       /* No such Interface */ > +#define ICMP_EXT_NO_TABLE_ENT  3       /* No such Table Entry */ > +#define ICMP_EXT_MULT_IFS      4       /* Multiple Interfaces > Satisfy Query */ > + > +/* Constants for EXT_ECHO (PROBE) */ > +#define EXT_ECHOREPLY_ACTIVE   (1 << 2)/* active bit in reply > message */ > +#define EXT_ECHOREPLY_IPV4     (1 << 1)/* ipv4 bit in reply message > */ > +#define EXT_ECHOREPLY_IPV6     1       /* ipv6 bit in reply message > */ > +#define EXT_ECHO_CTYPE_NAME    1 > +#define EXT_ECHO_CTYPE_INDEX   2 > +#define EXT_ECHO_CTYPE_ADDR    3 > +#define ICMP_AFI_IP            1       /* Address Family Identifier > for ipv4 */ > +#define ICMP_AFI_IP6           2       /* Address Family Identifier > for ipv6 */ >   >  #ifdef __USE_MISC >  /* Please let me know if there is any feedback/comments for this patch