From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 0427A3858418 for ; Sat, 3 Sep 2022 08:55:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0427A3858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x42a.google.com with SMTP id bp20so4491718wrb.9 for ; Sat, 03 Sep 2022 01:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=oZn5j0nezrEqFMjBBgqGo8KHsDBjwy46tYQ6ESI5aWs=; b=d5MrZ5OWtwnOYMVdFMA/JoUMmnS7KIYSLcIIdZ1yuKU0M56NFaaRc566IXIhzHYVTf nyWqiEIfCdRHV1xsxSeMLEiXJzdN/PifqqfFDIXwuttaIg+2kVHKgn6J5tLGr54gCbry ku9HlWYpLDyBpr8kVs4g8IX21JWJVWVPqmB9Xm7h/QBBH95FaJxWZSsoEAnF1JgY7713 zVMlbXpdIuHW3tKooaLXDHugpC+p7HjAxZAKMoTGkEflNSs1aT816Ti2JSwbSdqm2uEX igyW0+HNKuigGz7QJ6i4d2HySs8Ic2eUQJQbrQ6clHsvHum15ht045TeLVqnOWv03esU OaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=oZn5j0nezrEqFMjBBgqGo8KHsDBjwy46tYQ6ESI5aWs=; b=jGbNjHwe/8Oud9FoljgngDFqNvXJDbjQwvy6F3fyGU913dvxKkraQanNPH8mrk6KZg mIwvqF+IPDFyLnYQ/0Ee3j3mM5+j2LuE8DYR+AFdm5gCYc7HgzA7yvcNfwTTsA/lsIW6 wWSxmu7+IrsKVINeYF/Kk3p++/sisoOAgT1YUkv0jtmS6ZPtJStUAUkxH+o4hSLHY0Yl AnRaYPmei7Wx1BgPJKkGSJ8jbXCF1dMdRNjAJR8mtifcr3rMGLtQ7mt/5MOO7ho8+mt0 Kl63qbrpdMSawr3fBqQUBHg1nk51egKsDSaJmCrjUKH7V49SiALLJPw97FYux2a9DcEi qmKA== X-Gm-Message-State: ACgBeo3FmZD8JIxoTjPzXu5Pghqe+xq3S9gyT9sy8BqAIi17qiJSK5Qw bQhDOkoCryj6gx/8I1iQqcqBYg== X-Google-Smtp-Source: AA6agR4h3dTHAdS37yb1h+jp+Hg9cZ8KHE05DzPxWTJiofLYI4QNuE03iqj8bUaOVpxaRXIhNoom8Q== X-Received: by 2002:adf:fbc7:0:b0:220:6004:18ca with SMTP id d7-20020adffbc7000000b00220600418camr18817511wrs.632.1662195301616; Sat, 03 Sep 2022 01:55:01 -0700 (PDT) Received: from [192.168.5.67] ([154.59.132.152]) by smtp.gmail.com with ESMTPSA id c1-20020adfed81000000b0022860e8ae7csm671477wro.77.2022.09.03.01.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Sep 2022 01:55:00 -0700 (PDT) Message-ID: <095dbb7a-27bc-5866-98cd-cfedb84dbfdb@linaro.org> Date: Sat, 3 Sep 2022 09:54:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 09/17] string: Improve generic strcmp Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: Richard Henderson , Joseph Myers , caiyinyu References: <20220902203940.2385967-1-adhemerval.zanella@linaro.org> <20220902203940.2385967-10-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20220902203940.2385967-10-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/2/22 21:39, Adhemerval Zanella via Libc-alpha wrote: > +static inline int > +final_cmp (const op_t w1, const op_t w2) > +{ > + unsigned char c1, c2; > + for (size_t i = 0; i < sizeof (op_t); i++) > + { > + c1 = extractbyte (w1, i); > + c2 = extractbyte (w2, i); > + if (c1 == '\0' || c1 != c2) > + return c1 - c2; > + } > + return c1 - c2; > +} The loop should be replaced by i = index_first_zero_ne(w1, w2); r~