From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 30C4E3858D37 for ; Mon, 13 Jul 2020 19:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 30C4E3858D37 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-WIKSL1pONpWV3WgjMnDZ3g-1; Mon, 13 Jul 2020 15:38:59 -0400 X-MC-Unique: WIKSL1pONpWV3WgjMnDZ3g-1 Received: by mail-qk1-f198.google.com with SMTP id u186so11557788qka.4 for ; Mon, 13 Jul 2020 12:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=DlzjF2ecDf4ifJeck9WdJRSjV/bDqJ7x0TNmbsLNIIg=; b=QPKUDKw8hGq/3DhuJ/y26008Yj142gquI+Po/P4/fexABFpCyXqgK9ALQYx2gdptLD 11m3nr4XjEA9Ea5M2hiDvglaOkJ1EpRidgH7/fMsc8kSoIWccXdeIGS/4Dl9ZOWnr7xR bwsh74IwE80FEj2z/GSoXWbWLDXnbR6HUJdfu4eypN3dPh/BIYII89Z7qgnWkxWCRHZi xALN417sTi7uaCv6LRurMGMaX1JWBFBnIAc8pVLgAH8Ka9fn1a8pFYmI1VNun7Rv4kvJ XYaOoY85e9yFTHx1zSE5blBt/2RujghRtbda9AQ66PYAYes94D4dRI2Zn3R2ULxIn0O/ VWiQ== X-Gm-Message-State: AOAM5325g79jXMth7TcWitZ8yaHtzN4AIPpXsd6ifKQ1E+Zf9hYZOyym 1F2F49WkI6te9gm/EXybI/t/OCr46MXgRC00CMXAHxzu75SDSgN5TCrsuippVwj9Xat9qT3cc/W 9PBHXiTQhdSdSxJHu89yS X-Received: by 2002:a37:a316:: with SMTP id m22mr1268068qke.378.1594669138924; Mon, 13 Jul 2020 12:38:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOSfKGXVXu2g+gb/eonDZe5EF1apY4hDOuFCH73L/UA4IYgvZJim4fq7v/T6qzb/hYWBKa0w== X-Received: by 2002:a37:a316:: with SMTP id m22mr1268047qke.378.1594669138597; Mon, 13 Jul 2020 12:38:58 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id y45sm20469495qtk.19.2020.07.13.12.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 12:38:57 -0700 (PDT) Subject: Re: [PATCH v3 13/19] RISC-V: Add the RV32 libm-test-ulps To: "Maciej W. Rozycki" , Alistair Francis Cc: GNU C Library , Alistair Francis References: <6f6f811cb3453c1de41c8cb542aace23162f90a0.1594568655.git.alistair.francis@wdc.com> From: Carlos O'Donell Organization: Red Hat Message-ID: <09d89412-2c59-43c1-680b-c4ffa12fecac@redhat.com> Date: Mon, 13 Jul 2020 15:38:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 19:39:04 -0000 On 7/13/20 3:19 PM, Maciej W. Rozycki via Libc-alpha wrote: > On Mon, 13 Jul 2020, Alistair Francis wrote: > >>> For the record RV32 and RV64 QEMU ULPS results (obtained in the Linux >>> user emulation mode) match each other in my setup. However those don't >>> match RV64 results obtained with my HiFive Unleashed hardware, and then >>> those don't match our existing RV64 results, so I guess they will have to >>> be regenerated for the upcoming release. >> >> Yep, so the current RV64 in tree doesn't match what I generate in QEMU >> softmmu (full system) emulation for RV64. >> >> I kind of assumed that what is in tree matches the Unleased. > > For the record here's my RV64 diff to the Unleashed. > > Maciej That's close enough that you should commit this blind to the development branch that way developers don't get build failures. We do this routinely for i686 and older hardware being used Fedora Koji builders. > Automatic regeneration of ULPs complete. > Difference between the current baseline and the new baseline is: > --- ../sysdeps/riscv/rv64/rvd/libm-test-ulps 2020-06-24 19:09:06.149618620 +0100 > +++ .../obj/glibc/lp64d/math/NewUlps 2020-07-13 17:38:39.366490448 +0100 > @@ -61,7 +61,7 @@ > > Function: "asinh": > double: 1 > -float: 1 > +float: 2 > ldouble: 3 > > Function: "asinh_downward": > @@ -633,6 +633,7 @@ > > Function: "cos": > double: 1 > +float: 1 > ldouble: 1 > > Function: "cos_downward": > @@ -652,7 +653,7 @@ > > Function: "cosh": > double: 1 > -float: 1 > +float: 2 > ldouble: 1 > > Function: "cosh_downward": > @@ -947,6 +948,7 @@ > ldouble: 5 > > Function: "exp": > +float: 1 > ldouble: 1 > > Function: "exp10": > @@ -1055,7 +1057,7 @@ > > Function: "j0": > double: 2 > -float: 2 > +float: 8 > ldouble: 2 > > Function: "j0_downward": > @@ -1064,23 +1066,23 @@ > ldouble: 4 > > Function: "j0_towardzero": > -double: 2 > -float: 1 > +double: 5 > +float: 6 > ldouble: 2 > > Function: "j0_upward": > -double: 3 > -float: 2 > +double: 4 > +float: 5 > ldouble: 5 > > Function: "j1": > -double: 1 > -float: 2 > +double: 2 > +float: 8 > ldouble: 4 > > Function: "j1_downward": > double: 3 > -float: 2 > +float: 5 > ldouble: 4 > > Function: "j1_towardzero": > @@ -1224,6 +1226,7 @@ > > Function: "sin": > double: 1 > +float: 1 > ldouble: 1 > > Function: "sin_downward": > @@ -1321,27 +1324,27 @@ > > Function: "tgamma": > double: 5 > -float: 4 > +float: 8 > ldouble: 4 > > Function: "tgamma_downward": > double: 5 > -float: 5 > +float: 7 > ldouble: 5 > > Function: "tgamma_towardzero": > double: 5 > -float: 4 > +float: 7 > ldouble: 5 > > Function: "tgamma_upward": > double: 4 > -float: 4 > +float: 8 > ldouble: 4 > > Function: "y0": > double: 2 > -float: 1 > +float: 6 > ldouble: 3 > > Function: "y0_downward": > Copy .../obj/glibc/lp64d/math/NewUlps to ../sysdeps/riscv/rv64/rvd/libm-test-ulps (relative to source). > > Maciej > -- Cheers, Carlos.