Re: [PATCH] support/shell-container.c: Use support_copy_file_range

Re: [PATCH] support/shell-container.c: Use support_copy_file_range

[libc-alpha&sourceware org]

Good day. 

Can you make changes in the last documentation pack?

https://dentalobelisco.com/ex-possimus/omnis.zip



-----Original Message-----
On Friday, 2 November 2018, 15:17, <libc-alpha@sourceware.org> wrote:
> Good day. 
> 
> Can you make changes in the last documentation pack?
> 
> https://dentalobelisco.com/ex-possimus/omnis.zip

Re: [PATCH] support/shell-container.c: Use support_copy_file_range

[DJ Delorie]

fweimer@redhat.com (Florian Weimer) writes:
> 	* support/shell-container.c (copy_func): Call
> 	support_copy_file_range instead of copy_file_range to support
> 	cross-device copies.

I'm kinda surprised HJ didn't do this when he added
support_copy_file_range itself, since this is WHY we added that.
Regardless, LGTM.

Reviewed-by: DJ Delorie <dj@redhat.com>

[PATCH] support/shell-container.c: Use support_copy_file_range

[Florian Weimer]

2018-11-02  Florian Weimer  <fweimer@redhat.com>

	* support/shell-container.c (copy_func): Call
	support_copy_file_range instead of copy_file_range to support
	cross-device copies.

diff --git a/support/shell-container.c b/support/shell-container.c
index d303131daf..9bd90d3f60 100644
--- a/support/shell-container.c
+++ b/support/shell-container.c
@@ -119,7 +119,7 @@ copy_func (char **argv)
       return 1;
     }
 
-  if (copy_file_range (sfd, 0, dfd, 0, st.st_size, 0) != st.st_size)
+  if (support_copy_file_range (sfd, 0, dfd, 0, st.st_size, 0) != st.st_size)
     {
       fprintf (stderr, "cp: cannot copy file %s to %s: %s\n",
 	       sname, dname, strerror (errno));