public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 7/9] nptl: Move pthread_attr_setstack into libc
Date: Tue, 11 May 2021 14:35:56 -0300	[thread overview]
Message-ID: <0a03570f-894e-6109-48da-7d3895506815@linaro.org> (raw)
In-Reply-To: <87o8dhxjuk.fsf@oldenburg.str.redhat.com>



On 11/05/2021 14:26, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>>> +# endif /* OTHER_SHLIB_COMPAT */
>>> +#endif /* PTHREAD_STACK_MIN != 16384 */
>>
>> Double space before '*/'.
> 
> I don't think the double-space rule applies here.  It's ”.  */”, but
> these comments referencing expressions etc. generally do not end in a
> dot in existing code.

My impression is to always use a double space before comments ending,
regardless the sentence ending with a period or not (as least this is
the usual take I see in preprocessor comments like this).

  reply	other threads:[~2021-05-11 17:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 16:08 [PATCH 0/9] Move most pthread_attr_t functions " Florian Weimer
2021-05-10 16:08 ` [PATCH 1/9] nptl: Move pthread_attr_getaffinity_np " Florian Weimer
2021-05-11 13:35   ` Adhemerval Zanella
2021-05-10 16:08 ` [PATCH 2/9] nptl: Move pthread_attr_getguardsize " Florian Weimer
2021-05-11 17:04   ` Adhemerval Zanella
2021-05-10 16:08 ` [PATCH 3/9] nptl: Move pthread_attr_getstack " Florian Weimer
2021-05-11 17:06   ` Adhemerval Zanella
2021-05-10 16:08 ` [PATCH 4/9] nptl: Move pthread_attr_getstackaddr " Florian Weimer
2021-05-11 17:10   ` Adhemerval Zanella
2021-05-10 16:09 ` [PATCH 5/9] nptl: Move pthread_attr_getstacksize " Florian Weimer
2021-05-11 17:11   ` Adhemerval Zanella
2021-05-11 17:14   ` Adhemerval Zanella
2021-05-10 16:09 ` [PATCH 6/9] nptl: Move pthread_attr_setguardsize " Florian Weimer
2021-05-11 17:16   ` Adhemerval Zanella
2021-05-10 16:09 ` [PATCH 7/9] nptl: Move pthread_attr_setstack " Florian Weimer
2021-05-11 17:22   ` Adhemerval Zanella
2021-05-11 17:26     ` Florian Weimer
2021-05-11 17:35       ` Adhemerval Zanella [this message]
2021-05-11 17:38         ` Florian Weimer
2021-05-10 16:09 ` [PATCH 8/9] nptl: Move pthread_attr_setstackaddr " Florian Weimer
2021-05-11 17:22   ` Adhemerval Zanella
2021-05-10 16:09 ` [PATCH 9/9] nptl: Move pthread_attr_setstacksize " Florian Weimer
2021-05-11 17:24   ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a03570f-894e-6109-48da-7d3895506815@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).