From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id 8659D398B874 for ; Tue, 11 May 2021 17:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8659D398B874 Received: by mail-qk1-x734.google.com with SMTP id c20so8570544qkm.3 for ; Tue, 11 May 2021 10:35:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LbwhX8f5IZJ/vj0VaPRvenIFZD8cOKq29LtjaCYn8eg=; b=HCdDn/lZaB3BMutdtCiG7JIz/dnuNXW4sTH2bQPqnDrBXyeTO/Nfuxc9sFKLnSg5R2 6P1vJ1olSfgSCL2cqxIuATrQHRPZvontZeoJ4MmoZ7CmhkHLTv55OhaUZrKJfPufrvHf sp9ErZB4cdlUrBXNrY1tuwxYkZosO4Hn52k+JMCs2pm9L4ITbqihvtaVPNtK25dmGJYD Iv5xv2FlRxrFkYQlE+Cr9Eh5tek/VNZGqQLVa+zAevUoBnqJmbkuzXsYZ3jbifiRurAO 74kQrbNuyEqVlI/+DsFkfrmtFONQrYY0e+4N2REBQGY2TDXqo0JTTeMnUc9FsTd9dAne BRzw== X-Gm-Message-State: AOAM530oxCsf7yXtxWCU1cz/Yv7LF5Kfqry/FGQd1UFAz4sDIOZD2dHO OlhperBeuFCUmrvgomV/ZDHHC1qFnNiolQ== X-Google-Smtp-Source: ABdhPJxFdRvP1fJCx5Ev4jjTiNhwaRbA8vdMAejiGJvTEQX0vBAx/XyQx7zz5MUa4OgivHs2wRzrbQ== X-Received: by 2002:a37:2e81:: with SMTP id u123mr29618025qkh.218.1620754559030; Tue, 11 May 2021 10:35:59 -0700 (PDT) Received: from [192.168.1.4] ([177.194.37.86]) by smtp.gmail.com with ESMTPSA id p14sm10115096qki.27.2021.05.11.10.35.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 10:35:58 -0700 (PDT) Subject: Re: [PATCH 7/9] nptl: Move pthread_attr_setstack into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <5064d045f07070d2c20d24f4894976dbf80edc29.1620662729.git.fweimer@redhat.com> <87o8dhxjuk.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <0a03570f-894e-6109-48da-7d3895506815@linaro.org> Date: Tue, 11 May 2021 14:35:56 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87o8dhxjuk.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 17:36:01 -0000 On 11/05/2021 14:26, Florian Weimer wrote: > * Adhemerval Zanella: > >>> +# endif /* OTHER_SHLIB_COMPAT */ >>> +#endif /* PTHREAD_STACK_MIN != 16384 */ >> >> Double space before '*/'. > > I don't think the double-space rule applies here. It's ”. */”, but > these comments referencing expressions etc. generally do not end in a > dot in existing code. My impression is to always use a double space before comments ending, regardless the sentence ending with a period or not (as least this is the usual take I see in preprocessor comments like this).