From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: David Kilroy <David.Kilroy@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 2/3] elf: avoid redundant sort in dlopen
Date: Tue, 14 Jan 2020 19:42:00 -0000 [thread overview]
Message-ID: <0a4b41eb-0bc8-9f9e-6518-832edd51440c@linaro.org> (raw)
In-Reply-To: <1575394197-18006-3-git-send-email-david.kilroy@arm.com>
On 03/12/2019 14:30, David Kilroy wrote:
> l_initfini is already sorted by dependency in _dl_map_object_deps(),
> so avoid sorting again in dl_open_worker().
>
> Tested by running the testsuite on x86_64.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> elf/dl-open.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/elf/dl-open.c b/elf/dl-open.c
> index 9996fe9..c4d09c7c 100644
> --- a/elf/dl-open.c
> +++ b/elf/dl-open.c
> @@ -658,7 +658,6 @@ dl_open_worker (void *a)
> l = new->l_initfini[++j];
> }
> while (l != NULL);
> - _dl_sort_maps (maps, nmaps, NULL, false);
>
> int relocation_in_progress = 0;
>
>
next prev parent reply other threads:[~2020-01-14 19:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:30 [PATCH v3 0/3] elf: Allow dlopen of filter object to work [BZ #16272] David Kilroy
2019-12-03 17:30 ` [PATCH v3 1/3] " David Kilroy
2020-01-14 18:31 ` Adhemerval Zanella
2020-01-15 12:37 ` David Kilroy
2020-01-17 14:04 ` Adhemerval Zanella
2020-01-17 17:00 ` David Kilroy
2020-01-21 16:34 ` David Kilroy
2020-01-22 20:39 ` Adhemerval Zanella
2019-12-03 17:30 ` [PATCH v3 2/3] elf: avoid redundant sort in dlopen David Kilroy
2020-01-14 19:42 ` Adhemerval Zanella [this message]
2019-12-03 17:30 ` [PATCH v3 3/3] elf: avoid stack allocation in dl_open_worker David Kilroy
2020-01-14 20:04 ` Adhemerval Zanella
2019-12-18 16:32 ` [PATCH v3 0/3] elf: Allow dlopen of filter object to work [BZ #16272] David Kilroy
2019-12-18 19:33 ` Adhemerval Zanella
2019-12-19 11:43 ` David Kilroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4b41eb-0bc8-9f9e-6518-832edd51440c@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=David.Kilroy@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).