From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117466 invoked by alias); 14 Jan 2020 19:42:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117452 invoked by uid 89); 14 Jan 2020 19:42:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qv1-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Fny4HEYGY18HgcGcCtbKTinuIXIvluoSiKaCAqsExQA=; b=xOr3VQ9F8lKd62LDyzmqYAJHUL9ZvyoEiy1kdr+z75tU7tByEpLftqL/Yzwpm7Llwt 5uaPideohRUeVULarNsgInF+ylCBKlCu20+Lbdq0SisEWKmwNpw2+3M9Mnl1per5+NcG 1AOM/ugIDLpl4Ll7yj2ZTd+DwL7q9oSWfub1DXbSondZ6U+lmqxCVCmN95zE1W0v1DWK quQqCqdOyc/zzKVXOWJ2L01WpiiyEbFhxLKJJbh9K604HNUm2vYdYhEYloMSew5yUIvi jpDQaXdOAdNNoMgmlYyhqINELEskwEta+G5gl+vvi72nWW8nkStrzzul+O0SLnJPggkO meqA== Return-Path: Subject: Re: [PATCH v3 2/3] elf: avoid redundant sort in dlopen To: David Kilroy , "libc-alpha@sourceware.org" References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> <1575394197-18006-3-git-send-email-david.kilroy@arm.com> From: Adhemerval Zanella Message-ID: <0a4b41eb-0bc8-9f9e-6518-832edd51440c@linaro.org> Date: Tue, 14 Jan 2020 19:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1575394197-18006-3-git-send-email-david.kilroy@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00279.txt.bz2 On 03/12/2019 14:30, David Kilroy wrote: > l_initfini is already sorted by dependency in _dl_map_object_deps(), > so avoid sorting again in dl_open_worker(). > > Tested by running the testsuite on x86_64. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/dl-open.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/elf/dl-open.c b/elf/dl-open.c > index 9996fe9..c4d09c7c 100644 > --- a/elf/dl-open.c > +++ b/elf/dl-open.c > @@ -658,7 +658,6 @@ dl_open_worker (void *a) > l = new->l_initfini[++j]; > } > while (l != NULL); > - _dl_sort_maps (maps, nmaps, NULL, false); > > int relocation_in_progress = 0; > >