From: Stefan Liebler <stli@linux.ibm.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: [PATCH] Adjust name-prefix of ld.so in test-container.c.
Date: Mon, 03 Sep 2018 08:39:00 -0000 [thread overview]
Message-ID: <0a6087d9-08a2-d157-163f-25697e9e35e2@linux.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
Hi,
the test-container.c file assumes that ld.so is always named something
like /elf/ld-linux-*. But e.g. on s390x it is named ld64.so.1 or ld.so.1
on s390. There are other architectures like power or mips with similar
names.
This patch just changes the assumption to /elf/ld*. Without this patch,
test-container.c is searching invalid files / directories and fails to
find glibc/nss/tst-nss-test3.root/tst-nss-test3.script. Then the test
tst-nss-test3 fails!
Bye
Stefan
ChangeLog:
* support/test-container.c (main): Just search for /elf/ld
as ld.so in not names ld-linux* on all architectures.
[-- Attachment #2: 20180831_test_container.patch --]
[-- Type: text/x-patch, Size: 1358 bytes --]
commit 875af26b6e3a1ffd8bccc35e4a596853232bfb3c
Author: Stefan Liebler <stli@linux.ibm.com>
Date: Fri Aug 31 14:44:23 2018 +0200
Adjust name-prefix of ld.so in test-container.c.
The test-container.c file assumes that ld.so is always named
something like /elf/ld-linux-*.
But e.g. on s390x it is named ld64.so.1 or ld.so.1 on s390.
There are other architectures like power or mips with similar names.
This patch just changes the assumption to /elf/ld*.
Without this patch, test-container.c is searching invalid files / directories
and fails to find glibc/nss/tst-nss-test3.root/tst-nss-test3.script.
Then the test tst-nss-test3 fails!
ChangeLog:
* support/test-container.c (main): Just search for /elf/ld
as ld.so in not names ld-linux* on all architectures.
diff --git a/support/test-container.c b/support/test-container.c
index 2e91bdf9ec..8f7c3b076b 100644
--- a/support/test-container.c
+++ b/support/test-container.c
@@ -675,8 +675,8 @@ main (int argc, char **argv)
}
}
- if (strncmp (argv[1], concat (support_objdir_root, "/elf/ld-linux-", NULL),
- strlen (support_objdir_root) + 14) == 0)
+ if (strncmp (argv[1], concat (support_objdir_root, "/elf/ld", NULL),
+ strlen (support_objdir_root) + 7) == 0)
{
++argv;
--argc;
next reply other threads:[~2018-09-03 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 8:39 Stefan Liebler [this message]
2018-09-03 10:48 ` Florian Weimer
2018-09-03 14:13 ` Stefan Liebler
2018-09-04 16:38 ` DJ Delorie
2018-09-05 9:16 ` Stefan Liebler
2018-09-10 12:01 ` Stefan Liebler
2018-09-17 14:58 ` Carlos O'Donell
2018-10-04 11:41 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a6087d9-08a2-d157-163f-25697e9e35e2@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).