From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 837F73858D35 for ; Fri, 25 Feb 2022 15:39:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 837F73858D35 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-5ozBrFLTPQWrihcBbiR7fA-1; Fri, 25 Feb 2022 10:39:55 -0500 X-MC-Unique: 5ozBrFLTPQWrihcBbiR7fA-1 Received: by mail-qt1-f197.google.com with SMTP id p16-20020ac87410000000b002dde63e978cso2353463qtq.7 for ; Fri, 25 Feb 2022 07:39:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=N4arIrSUKUYE+wq2khsZ96gHfHNHCLs9Dv/1mLWKzX8=; b=5RottSIt+36n/TPzGGz1XE4tdMo6lNG1BZZkr8YyP5osfRw/JXEFk1SDVmNCXGpS0J Ri8r+OtcF0iubDtksfEm1H8GKxYd/kwjQp2zkrrgkm2tVYBG71YJZzlY6uQ38MePvS97 y+iW6+u9HThkHFWKGYwECFzZL+8anpIAhCxBHtOXbllytN0Tq2GXZKfS157x/bVMs221 NZ4Ii8QcA+fxDcRFFaKFjD2Hvk6WRB3aBgtG51G8Ielxm84MJfrPgtI98x3POThZzC82 Pjp8SUDdwvM+IlfD1P2iXPgILI/yHLYWrh8dxWR/zNCZDS/z5d+4x5u8HAgxEgwzy1dV dWag== X-Gm-Message-State: AOAM530jzVsYJGgYdrQ3GcJDMqbflSftZvj/qGyx9xQJaQDolSAnMOr3 shNR1SzjrsQPG7UzG9NZQNlUNeouxD33tCwH0MWgyRFr15z7dvjuubcG8UlYXmXusVvH/9u1koB MCocqTFprVpsKOeNdNeUW X-Received: by 2002:ae9:e301:0:b0:648:bb97:8bf7 with SMTP id v1-20020ae9e301000000b00648bb978bf7mr5158019qkf.335.1645803594331; Fri, 25 Feb 2022 07:39:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJx19UtcvTpH2bv2tkts7M16ydEfwdGXEUDyG0alVh2NfvFUqgcaNJK8Eeqx6qx2rPVq09y12w== X-Received: by 2002:ae9:e301:0:b0:648:bb97:8bf7 with SMTP id v1-20020ae9e301000000b00648bb978bf7mr5158007qkf.335.1645803594079; Fri, 25 Feb 2022 07:39:54 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id o18-20020a05622a045200b002dcebec5b45sm1717972qtx.36.2022.02.25.07.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 07:39:53 -0800 (PST) Message-ID: <0a7db2b8-7eb8-be3d-3e45-fb02a8344cb3@redhat.com> Date: Fri, 25 Feb 2022 10:39:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] benchtests: Generate .d dependency files [BZ #28922] To: "H.J. Lu" , libc-alpha@sourceware.org References: <20220224221035.987093-1-hjl.tools@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220224221035.987093-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 15:39:58 -0000 On 2/24/22 17:10, H.J. Lu via Libc-alpha wrote: > 1. Add all .o files to extra-objs. > 2. Include ../Rules after extra-objs has been set. LGTM. Fixes the ../Rules part. Still looks good. Reviewed-by: Carlos O'Donell > --- > benchtests/Makefile | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/benchtests/Makefile b/benchtests/Makefile > index 9b8df3b3f5..d513b29903 100644 > --- a/benchtests/Makefile > +++ b/benchtests/Makefile > @@ -296,11 +296,12 @@ bench-extra-objs = json-lib.o > extra-objs += $(bench-extra-objs) > others-extras = $(bench-extra-objs) > > -include ../Rules > - > binaries-bench := $(addprefix $(objpfx)bench-,$(bench)) > +extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench))) > binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset)) > +extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset))) > binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc)) > +extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc))) > > # The default duration: 1 seconds. > ifndef BENCH_DURATION > @@ -334,6 +335,9 @@ run-bench = $(test-wrapper-env) \ > $($*-ENV) $(test-via-rtld-prefix) $${run} > > timing-type := $(objpfx)bench-timing-type > +extra-objs += bench-timing-type.o > + > +include ../Rules > > # This makes sure CPPFLAGS-nonlib and CFLAGS-nonlib are passed > # for all these modules. -- Cheers, Carlos.