* [PATCH v2] Call the right helper function when setting mallopt M_ARENA_MAX
@ 2017-03-31 7:55 Wladimir J. van der Laan
2017-04-01 7:10 ` Siddhesh Poyarekar
0 siblings, 1 reply; 2+ messages in thread
From: Wladimir J. van der Laan @ 2017-03-31 7:55 UTC (permalink / raw)
To: libc-alpha; +Cc: Florian Weimer
Fixes a typo introduced in commit
be7991c0705e35b4d70a419d117addcd6c627319. This caused
mallopt(M_ARENA_MAX) as well as the environment variable
MALLOC_ARENA_MAX to not work as intended because it set the
wrong internal parameter.
[BZ# 21338]
* malloc/malloc.c: Call do_set_arena_max for M_ARENA_MAX
instead of incorrect do_set_arena_test
---
ChangeLog | 6 ++++++
malloc/malloc.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
Changes: added BZ reference
diff --git a/ChangeLog b/ChangeLog
index eaf7bb1..daa6437 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-03-30 Wladimir van der Laan <laanwj@gmail.com>
+
+ [BZ# 21338]
+ * malloc/malloc.c: Call do_set_arena_max for M_ARENA_MAX
+ instead of incorrect do_set_arena_test.
+
2017-03-30 Gabriel F. T. Gomes <gftg@linux.vnet.ibm.com>
* math/math.h: Include bits/math-finite.h once per
diff --git a/malloc/malloc.c b/malloc/malloc.c
index 994a232..4c40e2e 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -4904,7 +4904,7 @@ __libc_mallopt (int param_number, int value)
case M_ARENA_MAX:
if (value > 0)
- do_set_arena_test (value);
+ do_set_arena_max (value);
break;
}
__libc_lock_unlock (av->mutex);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Call the right helper function when setting mallopt M_ARENA_MAX
2017-03-31 7:55 [PATCH v2] Call the right helper function when setting mallopt M_ARENA_MAX Wladimir J. van der Laan
@ 2017-04-01 7:10 ` Siddhesh Poyarekar
0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2017-04-01 7:10 UTC (permalink / raw)
To: libc-alpha
On Friday 31 March 2017 01:25 PM, Wladimir J. van der Laan wrote:
> Fixes a typo introduced in commit
> be7991c0705e35b4d70a419d117addcd6c627319. This caused
> mallopt(M_ARENA_MAX) as well as the environment variable
> MALLOC_ARENA_MAX to not work as intended because it set the
> wrong internal parameter.
>
> [BZ# 21338]
> * malloc/malloc.c: Call do_set_arena_max for M_ARENA_MAX
> instead of incorrect do_set_arena_test
Thanks for catching this, I've pushed it.
Siddhesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-01 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 7:55 [PATCH v2] Call the right helper function when setting mallopt M_ARENA_MAX Wladimir J. van der Laan
2017-04-01 7:10 ` Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).