From: Alistair Francis <alistair.francis@wdc.com>
To: libc-alpha@sourceware.org
Cc: macro@wdc.com, alistair.francis@wdc.com, alistair23@gmail.com
Subject: [PATCH v4 07/18] sysv/linux: riscv: Fix dl-cache.h indentation
Date: Wed, 12 Aug 2020 07:41:14 -0700 [thread overview]
Message-ID: <0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com> (raw)
In-Reply-To: <cover.1597243100.git.alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
sysdeps/unix/sysv/linux/riscv/dl-cache.h | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/riscv/dl-cache.h b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
index 331e6015f4..d2adfbc301 100644
--- a/sysdeps/unix/sysv/linux/riscv/dl-cache.h
+++ b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
@@ -31,7 +31,7 @@
((flags) == _DL_CACHE_DEFAULT_ID)
/* If given a path to one of our library directories, adds every library
- directory via add_dir (), otherwise just adds the giver directory. On
+ directory via add_dir (), otherwise just adds the given directory. On
RISC-V, libraries can be found in paths ending in:
- /lib64/lp64d
- /lib64/lp64
@@ -41,15 +41,16 @@
so this will add all of those paths.
According to Joseph Myers:
- My reasoning for that would be: generic autoconf-configured (etc.)
- software may only know about using the lib directory, so you want the
- lib directory to be searched regardless of the ABI - but it's also
- useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
- architectures and have that automatically imply /usr/local/lib64/lp64d
- etc. so that libraries can be found that come from software that does
- use the ABI-specific directories. */
+ My reasoning for that would be: generic autoconf-configured (etc.)
+ software may only know about using the lib directory, so you want the
+ lib directory to be searched regardless of the ABI - but it's also
+ useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
+ architectures and have that automatically imply /usr/local/lib64/lp64d
+ etc. so that libraries can be found that come from software that does
+ use the ABI-specific directories. */
+
#define add_system_dir(dir) \
- do \
+ do \
{ \
static const char* lib_dirs[] = { \
"/lib64/lp64d", \
--
2.27.0
next prev parent reply other threads:[~2020-08-12 14:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:40 [PATCH v4 00/18] glibc port for 32-bit RISC-V (RV32) Alistair Francis
2020-08-12 14:40 ` [PATCH v4 01/18] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2020-08-12 14:40 ` [PATCH v4 02/18] RISC-V: Cleanup some of the sysdep.h code Alistair Francis
2020-08-17 13:53 ` Maciej W. Rozycki
2020-08-18 17:37 ` Carlos O'Donell
2020-08-21 17:13 ` Maciej W. Rozycki
2020-08-12 14:40 ` [PATCH v4 03/18] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port Alistair Francis
2020-08-17 14:07 ` Maciej W. Rozycki
2020-08-12 14:40 ` [PATCH v4 04/18] RISC-V: Add support for 32-bit vDSO calls Alistair Francis
2020-08-17 14:10 ` Maciej W. Rozycki
2020-08-18 1:35 ` Kito Cheng
2020-08-12 14:41 ` [PATCH v4 05/18] RISC-V: Support dynamic loader for the 32-bit Alistair Francis
2020-08-12 14:41 ` Alistair Francis [this message]
2020-08-17 14:21 ` [PATCH v4 07/18] sysv/linux: riscv: Fix dl-cache.h indentation Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 08/18] RISC-V: Add arch-syscall.h for RV32 Alistair Francis
2020-08-12 17:38 ` Joseph Myers
2020-08-12 18:14 ` Alistair Francis
2020-08-12 14:41 ` [PATCH v4 09/18] RISC-V: Support the 32-bit ABI implementation Alistair Francis
2020-08-18 13:35 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 10/18] RISC-V: Hard float support for 32-bit Alistair Francis
2020-08-18 14:37 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 11/18] RISC-V: Add 32-bit ABI lists Alistair Francis
2020-08-18 14:42 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 12/18] RISC-V: Add the RV32 libm-test-ulps Alistair Francis
2020-08-18 15:06 ` Maciej W. Rozycki
2020-08-18 15:02 ` Alistair Francis
2020-08-12 14:41 ` [PATCH v4 13/18] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2020-08-18 15:09 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 14/18] riscv32: Specify the arch_minimum_kernel as 5.4 Alistair Francis
2020-08-18 16:43 ` Maciej W. Rozycki
2020-08-12 14:41 ` [PATCH v4 16/18] RISC-V: Add rv32 path to RTLDLIST in ldd Alistair Francis
2020-08-18 23:52 ` Maciej W. Rozycki
2020-08-12 14:42 ` [PATCH v4 17/18] Documentation for the RISC-V 32-bit port Alistair Francis
2020-08-18 23:59 ` Maciej W. Rozycki
2020-08-12 14:42 ` [PATCH v4 18/18] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2020-08-19 0:00 ` Maciej W. Rozycki
2020-08-12 17:37 ` [PATCH v4 00/18] glibc port for 32-bit RISC-V (RV32) Joseph Myers
2020-08-13 14:59 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com \
--to=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=macro@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).